YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(chat): make jump-to-latest native behavior deterministic (#6697)
Louis Beaumont0f706060e4e0
diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.test.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.test.tsxindex 8cc4c97d5..19b83d7ad 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.test.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.test.tsx@@ -46,6 +46,7 @@ describe("ChatJumpToLatest", () => {expect(button.className).toContain("bottom-2");expect(button.className).toContain("rounded-none");expect(button.className).toContain("shadow-none");+ expect(button.className).not.toContain("transition-opacity");expect(button).toHaveAttribute("data-live", "false");fireEvent.click(button);expect(onJump).toHaveBeenCalledOnce();diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.tsxindex 44b709017..30b3b16e8 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/chat-jump-to-latest.tsx@@ -36,7 +36,7 @@ export function ChatJumpToLatest({tabIndex={visible ? 0 : -1}onClick={onJump}className={cn(- "absolute left-1/2 bottom-2 flex h-8 w-8 -translate-x-1/2 items-center justify-center rounded-none border bg-background text-foreground shadow-none transition-opacity duration-150 motion-reduce:transition-none",+ "absolute left-1/2 bottom-2 flex h-8 w-8 -translate-x-1/2 items-center justify-center rounded-none border bg-background text-foreground shadow-none","hover:bg-foreground hover:text-background","focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-foreground",liveVisiblediff --git a/apps/screenpipe-app-tauri/e2e/specs/chat-jump-to-latest.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/chat-jump-to-latest.spec.tsindex 76c22fee9..ce4d25be5 100644--- a/apps/screenpipe-app-tauri/e2e/specs/chat-jump-to-latest.spec.ts+++ b/apps/screenpipe-app-tauri/e2e/specs/chat-jump-to-latest.spec.ts@@ -23,6 +23,7 @@ import {const LEARNING_STORAGE_KEY = "screenpipe.first-run.learning-window.v1";type JumpMetrics = {+ className: string;opacity: number;pointerEvents: string;borderRadius: string;@@ -139,6 +140,7 @@ async function readJumpMetrics(): Promise<JumpMetrics | null> {const rect = button.getBoundingClientRect();const composerRect = composerRoot?.getBoundingClientRect();return {+ className: button.className,opacity: Number(style.opacity),pointerEvents: style.pointerEvents,borderRadius: style.borderRadius,@@ -195,6 +197,22 @@ async function scrollMessageRail(position: "top" | "bottom"): Promise<void> {);}+async function waitForRailNearBottom(): Promise<void> {+ await browser.waitUntil(+ async () =>+ (await browser.execute(() => {+ const viewport = document.querySelector<HTMLElement>('[data-testid="chat-message-scroll"]');+ if (!viewport) return false;+ return viewport.scrollHeight - viewport.scrollTop - viewport.clientHeight <= 150;+ })) as boolean,+ {+ timeout: t(5_000),+ interval: 50,+ timeoutMsg: "message rail did not reach the latest message after the jump",+ },+ );+}+describe("chat jump to latest", function () {this.timeout(90_000);@@ -205,7 +223,7 @@ describe("chat jump to latest", function () {await waitForChatSeedHooks();});- it("fades a quiet composer-anchored control until the user scrolls up, then jumps back", async () => {+ it("hides a quiet composer-anchored control until the user scrolls up, then jumps back", async () => {const sessionId = randomUUID();await seedLongConversation(sessionId);await waitForForegroundSession(sessionId);@@ -242,12 +260,7 @@ describe("chat jump to latest", function () {const afterClick = await waitForJumpState(false);expect(afterClick.opacity).toBeLessThan(0.1);- const nearBottom = (await browser.execute(() => {- const viewport = document.querySelector<HTMLElement>('[data-testid="chat-message-scroll"]');- if (!viewport) return false;- return viewport.scrollHeight - viewport.scrollTop - viewport.clientHeight <= 150;- })) as boolean;- expect(nearBottom).toBe(true);+ await waitForRailNearBottom();await saveScreenshot("chat-jump-to-latest-after-click");});});diff --git a/docs/pr-assets/chat-jump-to-latest/after-click.png b/docs/pr-assets/chat-jump-to-latest/after-click.pngindex 864d88c96..783a8a127 100644Binary files a/docs/pr-assets/chat-jump-to-latest/after-click.png and b/docs/pr-assets/chat-jump-to-latest/after-click.png differdiff --git a/docs/pr-assets/chat-jump-to-latest/after.png b/docs/pr-assets/chat-jump-to-latest/after.pngindex c810c2741..8ac270c25 100644Binary files a/docs/pr-assets/chat-jump-to-latest/after.png and b/docs/pr-assets/chat-jump-to-latest/after.png differdiff --git a/docs/pr-assets/chat-jump-to-latest/at-bottom.png b/docs/pr-assets/chat-jump-to-latest/at-bottom.pngindex 80ae79770..a1c50e2cb 100644Binary files a/docs/pr-assets/chat-jump-to-latest/at-bottom.png and b/docs/pr-assets/chat-jump-to-latest/at-bottom.png differdiff --git a/docs/pr-assets/chat-jump-to-latest/hover.png b/docs/pr-assets/chat-jump-to-latest/hover.pngindex 90265b1ed..6d5f4bd18 100644Binary files a/docs/pr-assets/chat-jump-to-latest/hover.png and b/docs/pr-assets/chat-jump-to-latest/hover.png differdiff --git a/docs/pr-assets/chat-jump-to-latest/short-chat.png b/docs/pr-assets/chat-jump-to-latest/short-chat.pngindex c6b76fd7d..f09282aa8 100644Binary files a/docs/pr-assets/chat-jump-to-latest/short-chat.png and b/docs/pr-assets/chat-jump-to-latest/short-chat.png differdiff --git a/evals/coding-agent/cases.json b/evals/coding-agent/cases.jsonindex 0d194131d..c6ecad2c9 100644--- a/evals/coding-agent/cases.json+++ b/evals/coding-agent/cases.json@@ -631,11 +631,11 @@"name": "Replace the chat new-content pill with a quiet jump control","source": {"kind": "git_regression",- "fix_commit": "e60ca3456109ab490520ce1ed9b460a8cd5576a0",+ "fix_commit": "a245a91bfc9b2aa1a944eb9ca40cc6a66c490132","pull_request": "https://github.com/screenpipe/screenpipe/pull/6690"},"base_ref": "fed5c6e37603a3fc8aeb0b6fd1b4ef2b041ebd60",- "oracle_ref": "e60ca3456109ab490520ce1ed9b460a8cd5576a0",+ "oracle_ref": "a245a91bfc9b2aa1a944eb9ca40cc6a66c490132","gate": "advisory","trigger_paths": ["apps/screenpipe-app-tauri/components/chat/standalone/chat-main-pane.tsx",