Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

test+docs: fmt pi.rs helper, regenerate tauri.ts, TESTING.md non-AVX2 entry, lockfile sync

Louis Beaumont0fcbb9a48b82
diff --git a/Cargo.lock b/Cargo.lock
index 06d4400db..9b009444a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -8561,7 +8561,7 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.25"
+version = "0.4.32"
[[package]]
name = "screenpipe-db"
diff --git a/TESTING.md b/TESTING.md
index f6fe62932..ee109b5bc 100644
--- a/TESTING.md
+++ b/TESTING.md
@@ -484,6 +484,7 @@ commits: `b3628788`, `738178da`
commits: `eea0c865`, `fe9060db`, `c99c3967`, `aeaa446b`, `5a219688`, `caae1ebc`, `67caf1d1`, `ff4af7b5`
+- [ ] **non-AVX2 CPU launch (compatibility mode)** — (#3125) On x86-64 CPUs without AVX2 (pre-2013 Intel, Atom-line Celeron/Pentium, QEMU `-cpu qemu64`), the app and CLI must LAUNCH and RECORD instead of dying with `0xC000001D STATUS_ILLEGAL_INSTRUCTION`. Local whisper/qwen3 STT is disabled at runtime (AVX2-compiled kernels); parakeet + cloud engines keep working; onboarding shows a "compatibility mode" notice. Guards: never set global `CFLAGS/CXXFLAGS=/arch:AVX2` in Windows release workflows (it poisons every cc/cmake dep incl. bundled SQLite → crash in static initializers before main); ONNX Runtime must stay on the MS DirectML DLL (import-table link, runtime CPUID dispatch) — pyke's `download-binaries` static libs are AVX2-only. CI: `release-cli.yml` runs the packaged exe under Intel SDE `-snb` (Sandy Bridge, no AVX2) on every Windows CLI build; reproduce locally with `sde -snb -- screenpipe.exe --version`, or QEMU `-cpu qemu64` for the app. Pipes/AI chat on such CPUs use bun's official `windows-x64-baseline` build (runtime-downloaded, mandatory SHA-256).
- [ ] **COM thread conflict** — audio and vision threads don't conflict on COM initialization (`eea0c865`).
- [ ] **high-DPI display (150%, 200%)** — OCR captures at correct resolution.
- [ ] **multiple monitors** — all detected and recorded.
diff --git a/apps/screenpipe-app-tauri/src-tauri/Cargo.lock b/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
index cc91c7a7f..f7cec44c4 100644
--- a/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
+++ b/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
@@ -11375,7 +11375,7 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.25"
+version = "0.4.32"
[[package]]
name = "screenpipe-db"
diff --git a/crates/screenpipe-core/src/agents/pi.rs b/crates/screenpipe-core/src/agents/pi.rs
index 03adedb75..d01143dbe 100644
--- a/crates/screenpipe-core/src/agents/pi.rs
+++ b/crates/screenpipe-core/src/agents/pi.rs
@@ -3259,14 +3259,14 @@ fn verify_sha256_or_delete(temp_file: &Path, expected: &str) -> std::result::Res
let mut file = std::fs::File::open(temp_file)?;
let mut hasher = Sha256::new();
std::io::copy(&mut file, &mut hasher)?;
- Ok(hasher.finalize().iter().fold(
- String::with_capacity(64),
- |mut hex, byte| {
+ Ok(hasher
+ .finalize()
+ .iter()
+ .fold(String::with_capacity(64), |mut hex, byte| {
use std::fmt::Write;
let _ = write!(hex, "{:02x}", byte);
hex
- },
- ))
+ }))
};
let digest = match compute() {
Ok(digest) => digest,
@@ -3513,6 +3513,47 @@ mod tests {
assert!(s.to_lowercase().contains("avx2"));
}
+ #[cfg(windows)]
+ #[test]
+ fn verify_sha256_accepts_matching_digest_case_insensitively() {
+ let dir = tempfile::tempdir().expect("tempdir");
+ let file = dir.path().join("payload.bin");
+ std::fs::write(&file, b"abc").unwrap();
+ // NIST test vector: SHA-256("abc")
+ const ABC: &str = "ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad";
+ verify_sha256_or_delete(&file, ABC).expect("exact-case match");
+ assert!(file.exists(), "matching digest must not delete the file");
+ verify_sha256_or_delete(&file, &ABC.to_uppercase()).expect("uppercase pin matches too");
+ }
+
+ #[cfg(windows)]
+ #[test]
+ fn verify_sha256_rejects_mismatch_and_deletes_the_download() {
+ let dir = tempfile::tempdir().expect("tempdir");
+ let file = dir.path().join("payload.bin");
+ std::fs::write(&file, b"tampered").unwrap();
+ let err = verify_sha256_or_delete(
+ &file,
+ "ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad",
+ )
+ .expect_err("mismatch must fail");
+ assert!(err.contains("SHA256 mismatch"));
+ assert!(!file.exists(), "mismatched download must be deleted");
+ }
+
+ #[cfg(windows)]
+ #[test]
+ fn verify_sha256_fails_closed_when_the_file_is_unreadable() {
+ let dir = tempfile::tempdir().expect("tempdir");
+ let missing = dir.path().join("never-downloaded.bin");
+ let err = verify_sha256_or_delete(
+ &missing,
+ "ba7816bf8f01cfea414140de5dae2223b00361a396177a9cb410ff61f20015ad",
+ )
+ .expect_err("unreadable file must fail, not proceed");
+ assert!(err.contains("couldn't hash"));
+ }
+
#[test]
fn describe_exit_status_code_plain_codes_unchanged() {
assert_eq!(describe_exit_status_code(0), "exit code 0");