Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(ci): stop forcing ort system static-linking on Windows (use download-binaries)

Louis Beaumont11566613b012
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 44ce4341e..f108bd44f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -222,8 +222,12 @@ jobs:
- name: Run specific Windows OCR cargo test
env:
RUSTFLAGS: "-C link-arg=/LTCG"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
# Use prebuilt NASM objects on Windows: https://aws.github.io/aws-lc-rs/requirements/windows.html#prebuilt-nasm-objects
AWS_LC_SYS_PREBUILT_NASM: "1"
run: cargo test -p screenpipe-screen test_process_ocr_task_windows --release --target x86_64-pc-windows-msvc
@@ -231,8 +235,12 @@ jobs:
- name: Run PII removal tests
env:
RUSTFLAGS: "-C link-arg=/LTCG"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
# Use prebuilt NASM objects on Windows: https://aws.github.io/aws-lc-rs/requirements/windows.html#prebuilt-nasm-objects
AWS_LC_SYS_PREBUILT_NASM: "1"
run: cargo test -p screenpipe-core pii_removal --release --target x86_64-pc-windows-msvc
@@ -240,8 +248,12 @@ jobs:
- name: Run PII redaction tests
env:
RUSTFLAGS: "-C link-arg=/LTCG"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
# Use prebuilt NASM objects on Windows: https://aws.github.io/aws-lc-rs/requirements/windows.html#prebuilt-nasm-objects
AWS_LC_SYS_PREBUILT_NASM: "1"
run: cargo test -p screenpipe-engine --lib pii_redaction_tests --release --target x86_64-pc-windows-msvc
diff --git a/.github/workflows/release-cli.yml b/.github/workflows/release-cli.yml
index d0a49b235..c3f405e8a 100644
--- a/.github/workflows/release-cli.yml
+++ b/.github/workflows/release-cli.yml
@@ -357,8 +357,12 @@ jobs:
GGML_AVX512_VNNI: "OFF"
GGML_AVX512_BF16: "OFF"
CMAKE_ARGS: "-DGGML_NATIVE=OFF -DGGML_AVX512=OFF -DGGML_AVX512_VBMI=OFF -DGGML_AVX512_VNNI=OFF -DGGML_AVX512_BF16=OFF -DCMAKE_C_FLAGS=/arch:AVX2 -DCMAKE_CXX_FLAGS=/arch:AVX2"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
OPENBLAS_PATH: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/openblas
# Use prebuilt NASM objects on Windows: https://aws.github.io/aws-lc-rs/requirements/windows.html#prebuilt-nasm-objects
AWS_LC_SYS_PREBUILT_NASM: "1"
diff --git a/.github/workflows/windows-integration-test.yml b/.github/workflows/windows-integration-test.yml
index 843b22051..c14dc8794 100644
--- a/.github/workflows/windows-integration-test.yml
+++ b/.github/workflows/windows-integration-test.yml
@@ -118,8 +118,12 @@ jobs:
- name: Build CLI
env:
RUSTFLAGS: "-C link-arg=/LTCG"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
OPENBLAS_PATH: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/openblas
# Use prebuilt NASM objects on Windows: https://aws.github.io/aws-lc-rs/requirements/windows.html#prebuilt-nasm-objects
AWS_LC_SYS_PREBUILT_NASM: "1"
@@ -130,8 +134,12 @@ jobs:
timeout-minutes: 10
env:
RUSTFLAGS: "-C link-arg=/LTCG"
- ORT_STRATEGY: system
- ORT_LIB_LOCATION: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-x64-1.24.2
+ # Link ONNX Runtime via ort's download-binaries (pyke prebuilt), same as the
+ # green release-app.yml. Setting ORT_LIB_LOCATION forces ort-sys into system
+ # static-linking, which needs onnxruntime_common.lib + the static _deps tree
+ # the dynamic MS prebuilt doesn't ship -> "ort-sys could not link" (#4173
+ # fallout, after Windows x86_64 moved off load-dynamic). The MS zip staged
+ # above still provides the runtime DLL.
OPENBLAS_PATH: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/openblas
AWS_LC_SYS_PREBUILT_NASM: "1"
run: |