YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(audio): stop ort load-dynamic hang on Windows ARM64 (link at build time) (#4176)
Louis Beaumont1c76617f3764
diff --git a/.github/workflows/release-app.yml b/.github/workflows/release-app.ymlindex 68877b617..55411263d 100644--- a/.github/workflows/release-app.yml+++ b/.github/workflows/release-app.yml@@ -863,6 +863,12 @@ jobs:GGML_AVX512_BF16: "OFF"CMAKE_ARGS: ${{ matrix.target == 'x86_64-pc-windows-msvc' && '-DGGML_NATIVE=OFF -DGGML_AVX512=OFF -DGGML_AVX512_VBMI=OFF -DGGML_AVX512_VNNI=OFF -DGGML_AVX512_BF16=OFF -DCMAKE_C_FLAGS=/arch:AVX2 -DCMAKE_CXX_FLAGS=/arch:AVX2' || '-DGGML_NATIVE=OFF' }}OPENBLAS_PATH: ${{ github.workspace }}/apps/screenpipe-app-tauri/src-tauri/openblas+ # ONNX Runtime link strategy. x86_64 pulls the pyke prebuilt+ # (download-binaries). ARM64 has no pyke prebuilt and load-dynamic hangs+ # with ort rc.12 (see #4173), so link the MS onnxruntime-win-arm64 DLL+ # downloaded by the "Download ONNX Runtime" step above.+ ORT_STRATEGY: ${{ matrix.target == 'aarch64-pc-windows-msvc' && 'system' || 'download' }}+ ORT_LIB_LOCATION: ${{ matrix.target == 'aarch64-pc-windows-msvc' && format('{0}/apps/screenpipe-app-tauri/src-tauri/onnxruntime-win-arm64-1.22.0', github.workspace) || '' }}run: bunx tauri build --verbose ${{ matrix.tauri-args }}- name: Sign NSIS installer with SSL.com EV (Windows)diff --git a/crates/screenpipe-audio/Cargo.toml b/crates/screenpipe-audio/Cargo.tomlindex 45917575f..d64511a9b 100644--- a/crates/screenpipe-audio/Cargo.toml+++ b/crates/screenpipe-audio/Cargo.toml@@ -119,9 +119,14 @@ ort = { workspace = true, features = ["download-binaries", "tls-native"] }samplerate = { workspace = true }libsamplerate-sys = { workspace = true }-# Windows ARM64: use our own ONNX Runtime DLL at runtime (load-dynamic); no compile-time link, no ort.pyke.io cache+# Windows ARM64: do NOT use `load-dynamic` — its runtime LoadLibrary of+# onnxruntime.dll hangs with ort rc.12 the same way it did on x86_64 (see #4173).+# ort links at build time instead; CI sets ORT_STRATEGY=system + ORT_LIB_LOCATION+# to the bundled MS onnxruntime-win-arm64 (pyke ships no arm64-windows prebuilt,+# so the `download-binaries` strategy that comes in transitively is overridden by+# ORT_STRATEGY=system).[target.'cfg(all(target_os = "windows", target_arch = "aarch64"))'.dependencies]-ort = { workspace = true, default-features = false, features = ["load-dynamic"] }+ort = { workspace = true, default-features = false, features = ["api-24", "tracing"] }ort-sys = { workspace = true }samplerate = { workspace = true }libsamplerate-sys = { workspace = true }