YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(meetings): force configured language on local live transcription (#6157)
Jitendra Verma24b36c3b97a7
diff --git a/crates/screenpipe-audio/src/meeting_streaming/selected_engine.rs b/crates/screenpipe-audio/src/meeting_streaming/selected_engine.rsindex 5efcc15b9..ad3d49198 100644--- a/crates/screenpipe-audio/src/meeting_streaming/selected_engine.rs+++ b/crates/screenpipe-audio/src/meeting_streaming/selected_engine.rs@@ -6,6 +6,7 @@ use std::sync::Arc;use anyhow::{anyhow, Context, Result};use chrono::{DateTime, Utc};+use screenpipe_core::Language;use tokio::{sync::{mpsc, RwLock},task::JoinHandle,@@ -73,7 +74,7 @@ async fn run_stream() -> Result<()> {// Bias the local live transcriber toward this meeting's keyterms (user// vocabulary + calendar attendee names) by seeding the session vocabulary.- let mut session = selected_engine_session(&engine_ref, &config.keyterms).await?;+ let mut session = selected_engine_session(&engine_ref, &config).await?;let model = selected_engine_model(&session);let mut buffer = LiveChunkBuffer::default();let mut resampler: Option<StreamResampler> = None;@@ -120,7 +121,7 @@ async fn run_stream(async fn selected_engine_session(engine_ref: &Arc<RwLock<Option<TranscriptionEngine>>>,- keyterms: &[String],+ config: &MeetingStreamingConfig,) -> Result<TranscriptionSession> {let engine = engine_ref.read()@@ -134,7 +135,27 @@ async fn selected_engine_session());}- engine.create_session_with_keyterms(keyterms)+ let mut session = engine.create_session_with_keyterms(&config.keyterms)?;+ // The cloud live path forces the configured language; the local path must+ // too, or Whisper auto-detects per short chunk and garbles non-english+ // speech into the wrong script (issue #5650).+ if let Some(language) = forced_language(config.language.as_deref()) {+ session.set_language(language);+ }+ Ok(session)+}++fn forced_language(language: Option<&str>) -> Option<Language> {+ let code = language.map(str::trim).filter(|s| !s.is_empty())?;+ match code.parse::<Language>() {+ Ok(language) => Some(language),+ Err(err) => {+ warn!(+ "meeting streaming: ignoring unknown live transcription language {code:?}: {err}"+ );+ None+ }+ }}fn selected_engine_model(session: &TranscriptionSession) -> Option<String> {@@ -350,4 +371,13 @@ mod tests {let mono = downmix_to_mono(&[1.0, -1.0, 0.25, 0.75], 2);assert_eq!(mono, vec![0.0, 0.5]);}++ #[test]+ fn forced_language_resolves_configured_language() {+ assert_eq!(forced_language(Some("ru")), Some(Language::Russian));+ assert_eq!(forced_language(Some("russian")), Some(Language::Russian));+ assert_eq!(forced_language(Some(" ")), None);+ assert_eq!(forced_language(None), None);+ assert_eq!(forced_language(Some("klingon")), None);+ }}diff --git a/crates/screenpipe-audio/src/transcription/engine.rs b/crates/screenpipe-audio/src/transcription/engine.rsindex 71ec7fc4b..857643a89 100644--- a/crates/screenpipe-audio/src/transcription/engine.rs+++ b/crates/screenpipe-audio/src/transcription/engine.rs@@ -605,6 +605,20 @@ pub enum TranscriptionSession {}impl TranscriptionSession {+ /// Force a single decoding language on this session, overriding the engine's+ /// configured languages. A single language makes Whisper skip per-chunk+ /// auto-detection (see `detect_language`) and pins the code on+ /// Deepgram/OpenAI-compatible requests. No-op for engines without a language+ /// selection.+ pub fn set_language(&mut self, language: Language) {+ match self {+ Self::Whisper { languages, .. }+ | Self::Deepgram { languages, .. }+ | Self::OpenAICompatible { languages, .. } => *languages = vec![language],+ _ => {}+ }+ }+pub async fn transcribe_detailed(&mut self,audio: &[f32],@@ -948,4 +962,24 @@ mod merge_keyterms_tests {let base = vec![v("Screenpipe")];assert_eq!(merge_keyterms(&base, &[]).len(), 1);}++ #[test]+ fn set_language_forces_single_language() {+ let mut session = TranscriptionSession::Deepgram {+ config: DeepgramTranscriptionConfig {+ endpoint: String::new(),+ auth_token: String::new(),+ auth_header_prefix: "Token",+ },+ languages: vec![Language::English, Language::Spanish],+ vocabulary: vec![],+ };+ session.set_language(Language::Russian);+ match session {+ TranscriptionSession::Deepgram { languages, .. } => {+ assert_eq!(languages, vec![Language::Russian]);+ }+ _ => panic!("expected deepgram session"),+ }+ }}