Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix: stop screen recording when screenshots are off (#5993)

Ezra Ellette2dba03b4183e
diff --git a/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx b/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
index 6a291b132..42a2bfe9a 100644
--- a/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
@@ -53,7 +53,7 @@ export const screenSearchIndex: SettingsField[] = [
{ label: "Screen context capture", keywords: ["screen", "video", "accessibility"] },
{ label: "Structured app context", keywords: ["semantic", "ai", "messages", "email", "tasks", "code"], conditional: true },
{ label: "Use it for", keywords: ["memory", "computer use", "automation", "agent", "skills"], conditional: true },
- { label: "Screenshot images", keywords: ["screenshot", "pixels", "ocr", "jpeg"] },
+ { label: "Screen recording", keywords: ["screenshot", "pixels", "ocr", "jpeg", "capture"] },
{ label: "Use all monitors", keywords: ["monitor", "display"], conditional: true },
// conditional: monitor picker only renders when "Use all monitors" is off — paired right under that toggle.
{ label: "Monitors", conditional: true },
@@ -3970,8 +3970,8 @@ Your screen is a pipe. Everything you see, hear, and type flows through it. Scre
<div className="flex items-center space-x-2.5">
<Monitor className="h-4 w-4 text-muted-foreground shrink-0" />
<div>
- <h3 className="text-sm font-medium text-foreground">Screenshot images</h3>
- <p className="text-xs text-muted-foreground">Capture screen pixels and store JPEG screenshots for visual evidence and OCR fallback</p>
+ <h3 className="text-sm font-medium text-foreground">Screen recording</h3>
+ <p className="text-xs text-muted-foreground">Record screen pixels for the timeline and image-only text. Turn this off to stop screen recording; accessibility text stays searchable.</p>
</div>
</div>
<ManagedSwitch
diff --git a/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
index ae1d3e094..3d91907b1 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
@@ -122,7 +122,7 @@ describe('Settings sections', () => {
await section.waitForExist({ timeout: 8_000 });
const sectionText = (await section.getText()).toLowerCase();
expect(sectionText).toContain('screen context capture');
- expect(sectionText).toContain('screenshot images');
+ expect(sectionText).toContain('screen recording');
expect(sectionText).not.toContain('audio recording');
expect(sectionText).not.toContain('live meeting notes');
diff --git a/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
index e3ae0a125..ddbf65d37 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
@@ -471,7 +471,7 @@ describe("Windows user journey", function () {
const sectionText = (await screenSection.getText()).toLowerCase();
return (
sectionText.includes("screen context capture") &&
- sectionText.includes("screenshot images") &&
+ sectionText.includes("screen recording") &&
!sectionText.includes("audio recording")
);
},
diff --git a/crates/screenpipe-engine/src/event_driven_capture.rs b/crates/screenpipe-engine/src/event_driven_capture.rs
index ec282f1d2..53a90bdd3 100644
--- a/crates/screenpipe-engine/src/event_driven_capture.rs
+++ b/crates/screenpipe-engine/src/event_driven_capture.rs
@@ -1063,7 +1063,7 @@ pub(crate) async fn event_driven_capture_loop(
None, // first capture — no elements ref
&mut walk_budget,
&mut ocr_gate,
- false, // screenshot enabled on startup
+ screenshot_disabled,
false, // hd not active at startup (Manual is dedup-exempt anyway)
false, // not in a meeting at startup
true, // focus unknown at startup — controller defaults to Active
diff --git a/crates/screenpipe-engine/src/vision_manager/manager.rs b/crates/screenpipe-engine/src/vision_manager/manager.rs
index eb6df4a37..0ab166a59 100644
--- a/crates/screenpipe-engine/src/vision_manager/manager.rs
+++ b/crates/screenpipe-engine/src/vision_manager/manager.rs
@@ -695,12 +695,10 @@ impl VisionManager {
let high_fps_controller = self.high_fps_controller.clone();
let semantic_tx = self.semantic_tx.clone();
- // Spawn the decoupled high-fps HD recorder alongside this monitor's
- // capture loop. It idles until an HD session is active, then records a
- // CFR H.264 chunk with NO OCR (the event loop above keeps indexing
- // sparsely). Shares the same Arc<SafeMonitor> + HighFpsController; runs
- // on its own task, aborted in `stop_monitor`.
- {
+ // Spawn the decoupled high-fps HD recorder only when screen pixels are
+ // enabled. Otherwise an active meeting could open its own OS capture
+ // stream despite `disableScreenshots`.
+ if !self.config.disable_screenshots {
let hd_config = crate::hd_recorder::HdRecorderConfig {
ignored_windows: self.config.ignored_windows.clone(),
included_windows: self.config.included_windows.clone(),