Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(meetings): match browser names at word boundaries (#6996) + detect meetings in Dia

Shaikh Abdul Mujeeb Masi332603b0c6a1
diff --git a/crates/screenpipe-engine/src/meeting_watcher/shared/ignore.rs b/crates/screenpipe-engine/src/meeting_watcher/shared/ignore.rs
index 9035b69f3..bf98a1536 100644
--- a/crates/screenpipe-engine/src/meeting_watcher/shared/ignore.rs
+++ b/crates/screenpipe-engine/src/meeting_watcher/shared/ignore.rs
@@ -49,7 +49,7 @@ pub(crate) fn browser_title_matches_pattern(title_lower: &str, pattern: &str) ->
pub(crate) fn is_browser_app(app_name: &str) -> bool {
BROWSER_NAMES
.iter()
- .any(|b| contains_case_insensitive(app_name, b))
+ .any(|b| contains_at_word_boundary(app_name, b))
|| ends_with_ascii_case_insensitive(app_name, ".exe")
&& [
"chrome.exe",
@@ -331,6 +331,52 @@ pub(crate) fn title_contains_meeting_code(title: &str) -> bool {
})
}
+/// Case-insensitive substring match that must land on word boundaries.
+///
+/// `BROWSER_NAMES` holds entries as short as `"dia"` and `"arc"`, which sit
+/// inside ordinary app names: `"nvidia"` and `"media"` both contain `dia`,
+/// `"search"` contains `arc`. A plain substring test therefore reports those
+/// windows as browsers, and a window classified as a browser has its title and
+/// URL matched against every meeting pattern — so the cost is false meeting
+/// detection on a per-window hot path, not just wasted work.
+///
+/// A match counts only when the characters on both sides are non-alphanumeric
+/// or absent, so `"Dia"` and `"Dia Browser"` match while `"NVIDIA"` does not.
+pub(crate) fn contains_at_word_boundary(haystack: &str, needle: &str) -> bool {
+ if needle.is_empty() {
+ return false;
+ }
+
+ if haystack.is_ascii() && needle.is_ascii() {
+ let needle = needle.as_bytes();
+ let bytes = haystack.as_bytes();
+ if bytes.len() < needle.len() {
+ return false;
+ }
+ return (0..=bytes.len() - needle.len()).any(|start| {
+ let end = start + needle.len();
+ bytes[start..end].eq_ignore_ascii_case(needle)
+ && (start == 0 || !bytes[start - 1].is_ascii_alphanumeric())
+ && (end == bytes.len() || !bytes[end].is_ascii_alphanumeric())
+ });
+ }
+
+ let haystack_lower = haystack.to_lowercase();
+ let needle_lower = needle.to_lowercase();
+ haystack_lower
+ .match_indices(&needle_lower)
+ .any(|(start, matched)| {
+ haystack_lower[..start]
+ .chars()
+ .next_back()
+ .is_none_or(|c| !c.is_alphanumeric())
+ && haystack_lower[start + matched.len()..]
+ .chars()
+ .next()
+ .is_none_or(|c| !c.is_alphanumeric())
+ })
+}
+
pub(crate) fn contains_case_insensitive(haystack: &str, needle: &str) -> bool {
if needle.is_empty() {
return false;
diff --git a/crates/screenpipe-engine/src/meeting_watcher/shared/profiles.rs b/crates/screenpipe-engine/src/meeting_watcher/shared/profiles.rs
index 4228a23e4..4a5001cfa 100644
--- a/crates/screenpipe-engine/src/meeting_watcher/shared/profiles.rs
+++ b/crates/screenpipe-engine/src/meeting_watcher/shared/profiles.rs
@@ -94,6 +94,7 @@ pub struct MeetingDetectionProfile {
pub(crate) const BROWSER_NAMES: &[&str] = &[
"google chrome",
"arc",
+ "dia",
"firefox",
"safari",
"microsoft edge",
diff --git a/crates/screenpipe-engine/src/meeting_watcher/ui_scan/macos.rs b/crates/screenpipe-engine/src/meeting_watcher/ui_scan/macos.rs
index 0ea246be8..a84c0c8f1 100644
--- a/crates/screenpipe-engine/src/meeting_watcher/ui_scan/macos.rs
+++ b/crates/screenpipe-engine/src/meeting_watcher/ui_scan/macos.rs
@@ -366,7 +366,7 @@ pub fn find_running_meeting_apps(
// Check browser URL patterns — only if this is a browser
if !profile.app_identifiers.browser_url_patterns.is_empty()
- && BROWSER_NAMES.iter().any(|b| name_lower.contains(b))
+ && is_browser_app(&name_lower)
&& has_browser_meeting_url(pid, profile)
{
results.push(RunningMeetingApp {
@@ -652,7 +652,7 @@ mod live_tests {
let app = &running[i];
let name = process_name_for_pid(app.pid()).unwrap_or_default();
let name_lower = name.to_lowercase();
- if BROWSER_NAMES.iter().any(|b| name_lower.contains(b)) {
+ if is_browser_app(&name_lower) {
println!("\nBROWSER: {} (pid={})", name, app.pid());
let ax_app = cidre::ax::UiElement::with_app_pid(app.pid());
let _ = ax_app.set_messaging_timeout_secs(2.0);
diff --git a/crates/screenpipe-engine/src/meeting_watcher/ui_scan/tests.rs b/crates/screenpipe-engine/src/meeting_watcher/ui_scan/tests.rs
index a5e2c8c95..70a9e4930 100644
--- a/crates/screenpipe-engine/src/meeting_watcher/ui_scan/tests.rs
+++ b/crates/screenpipe-engine/src/meeting_watcher/ui_scan/tests.rs
@@ -315,9 +315,27 @@ fn browser_app_detection_is_case_insensitive() {
assert!(is_browser_app("CHROME.EXE"));
assert!(is_browser_app("Microsoft Edge Helper"));
assert!(is_browser_app("brave.exe"));
+ assert!(is_browser_app("Dia"));
assert!(!is_browser_app("Zoom.exe"));
}
+/// Short `BROWSER_NAMES` entries are substrings of ordinary app names, so an
+/// unanchored match reports NVIDIA and Media Player as browsers. A window
+/// classified as a browser has its title and URL run against every meeting
+/// pattern, so a false positive there becomes a false meeting.
+#[test]
+fn browser_app_detection_requires_word_boundaries() {
+ assert!(!is_browser_app("NVIDIA GeForce Experience"));
+ assert!(!is_browser_app("Windows Media Player"));
+ assert!(!is_browser_app("Search"));
+ assert!(!is_browser_app("Diagnostics"));
+
+ assert!(is_browser_app("Dia"));
+ assert!(is_browser_app("Dia Browser"));
+ assert!(is_browser_app("Arc"));
+ assert!(is_browser_app("Arc Browser"));
+}
+
#[test]
fn attr_needs_empty_signal_set_needs_nothing() {
let needs = AttrNeeds::from_call_signals(std::iter::empty());