YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
test(app): close gaps in the webview remote IPC guard
Manas Raghuwanshi453a39b43971
diff --git a/.github/workflows/test-frontend.yml b/.github/workflows/test-frontend.ymlindex d8b45eb54..be3026f08 100644--- a/.github/workflows/test-frontend.yml+++ b/.github/workflows/test-frontend.yml@@ -20,7 +20,9 @@ on:- 'apps/screenpipe-app-tauri/vitest.config.ts'- 'apps/screenpipe-app-tauri/tsconfig*.json'- 'apps/screenpipe-app-tauri/src-tauri/capabilities/**'- - 'apps/screenpipe-app-tauri/src-tauri/tauri*.conf.json'+ - 'apps/screenpipe-app-tauri/src-tauri/tauri*.json'+ - 'apps/screenpipe-app-tauri/src-tauri/build.rs'+ - 'apps/screenpipe-app-tauri/src-tauri/src/**/*.rs'- '.github/workflows/test-frontend.yml'pull_request:paths:@@ -37,7 +39,9 @@ on:- 'apps/screenpipe-app-tauri/vitest.config.ts'- 'apps/screenpipe-app-tauri/tsconfig*.json'- 'apps/screenpipe-app-tauri/src-tauri/capabilities/**'- - 'apps/screenpipe-app-tauri/src-tauri/tauri*.conf.json'+ - 'apps/screenpipe-app-tauri/src-tauri/tauri*.json'+ - 'apps/screenpipe-app-tauri/src-tauri/build.rs'+ - 'apps/screenpipe-app-tauri/src-tauri/src/**/*.rs'- '.github/workflows/test-frontend.yml'concurrency:diff --git a/apps/screenpipe-app-tauri/lib/__tests__/webview-remote-ipc.test.ts b/apps/screenpipe-app-tauri/lib/__tests__/webview-remote-ipc.test.tsindex 969af2bf2..79ddedae1 100644--- a/apps/screenpipe-app-tauri/lib/__tests__/webview-remote-ipc.test.ts+++ b/apps/screenpipe-app-tauri/lib/__tests__/webview-remote-ipc.test.ts@@ -11,9 +11,19 @@ import { resolve } from "node:path";// process plugins only because no capability lists a remote origin: a remote// URL listed there gets every permission in that capability on every window.+type Capability = { identifier?: string; remote?: unknown };+const srcTauri = resolve(process.cwd(), "src-tauri");const capabilitiesDir = resolve(srcTauri, "capabilities");+// Mirrors tauri-utils `CapabilityFile`: a file holds one capability, a list of+// them, or `{ "capabilities": [...] }`.+function capabilitiesIn(file: string): Capability[] {+ const parsed = JSON.parse(readFileSync(resolve(capabilitiesDir, file), "utf8"));+ if (Array.isArray(parsed)) return parsed;+ return Array.isArray(parsed.capabilities) ? parsed.capabilities : [parsed];+}+function rustSourceFiles(directory: string): string[] {return readdirSync(directory, { withFileTypes: true }).flatMap((dirent) => {const path = resolve(directory, dirent.name);@@ -23,6 +33,20 @@ function rustSourceFiles(directory: string): string[] {}describe("webview remote IPC", () => {+ it("compiles in only capability files this test reads", () => {+ // build.rs picks the files Tauri loads; they must stay inside the+ // directory checked below. A dynamic pattern would bypass this check.+ const patterns = [+ ...readFileSync(resolve(srcTauri, "build.rs"), "utf8").matchAll(+ /capabilities_path_pattern\(\s*([^)]*)\)/g,+ ),+ ].map((match) => match[1].trim());+ expect(patterns.length).toBeGreaterThan(0);+ for (const pattern of patterns) {+ expect(pattern).toMatch(/^"(?:\.\/)?capabilities\/[^/"]+"$/);+ }+ });+it("keeps every capability file in a format this test reads", () => {const files = readdirSync(capabilitiesDir);expect(files.length).toBeGreaterThan(0);@@ -30,14 +54,16 @@ describe("webview remote IPC", () => {});it("grants no capability to remote origins", () => {- const remote = readdirSync(capabilitiesDir).filter(- (file) => "remote" in JSON.parse(readFileSync(resolve(capabilitiesDir, file), "utf8")),+ const remote = readdirSync(capabilitiesDir).flatMap((file) =>+ capabilitiesIn(file)+ .filter((capability) => "remote" in capability)+ .map((capability) => `${file}: ${capability.identifier}`),);expect(remote).toEqual([]);});it("defines no inline capabilities in any Tauri config", () => {- const configs = readdirSync(srcTauri).filter((file) => /^tauri\.(?:.+\.)?conf\.json$/.test(file));+ const configs = readdirSync(srcTauri).filter((file) => /^tauri\..+\.json$/.test(file));expect(configs).toContain("tauri.conf.json");for (const file of configs) {const config = JSON.parse(readFileSync(resolve(srcTauri, file), "utf8"));