Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(workflows): keep inline block editing borderless (#7517)

Louis Beaumont474086ebb277
diff --git a/docs/pr-assets/borderless-blocks/README.md b/docs/pr-assets/borderless-blocks/README.md
new file mode 100644
index 000000000..5a2434865
--- /dev/null
+++ b/docs/pr-assets/borderless-blocks/README.md
@@ -0,0 +1,9 @@
+# Borderless block editing
+
+Real shared Workflows components in the maintained `/preview` browser route, using fictional fixture data. These are browser previews, not captures of an installed desktop build.
+
+- Before: base `a979c5cfe`, focused first instruction in Research synthesis.
+- After: the same fixture, viewport (1280 × 720), scroll position and focus. The focused block's dimensions and text position are unchanged.
+- Additional states: existing block menu, SOP insert menu, and a newly inserted text block being edited.
+
+Verified by interacting with the rendered components: native editing, autosave and reopening, keyboard block reorder and undo, title and rich-text focus, adding a text block, and visible keyboard focus on the block type selector. The caret indicates text focus; action controls retain their existing focus outlines.
diff --git a/docs/pr-assets/borderless-blocks/desktop-added-text.png b/docs/pr-assets/borderless-blocks/desktop-added-text.png
new file mode 100644
index 000000000..fc80d6f2f
Binary files /dev/null and b/docs/pr-assets/borderless-blocks/desktop-added-text.png differ
diff --git a/docs/pr-assets/borderless-blocks/desktop-after.png b/docs/pr-assets/borderless-blocks/desktop-after.png
new file mode 100644
index 000000000..e2e1cdc7f
Binary files /dev/null and b/docs/pr-assets/borderless-blocks/desktop-after.png differ
diff --git a/docs/pr-assets/borderless-blocks/desktop-before.png b/docs/pr-assets/borderless-blocks/desktop-before.png
new file mode 100644
index 000000000..ee5c97346
Binary files /dev/null and b/docs/pr-assets/borderless-blocks/desktop-before.png differ
diff --git a/docs/pr-assets/borderless-blocks/desktop-block-menu.png b/docs/pr-assets/borderless-blocks/desktop-block-menu.png
new file mode 100644
index 000000000..a20769264
Binary files /dev/null and b/docs/pr-assets/borderless-blocks/desktop-block-menu.png differ
diff --git a/docs/pr-assets/borderless-blocks/desktop-insert-menu.png b/docs/pr-assets/borderless-blocks/desktop-insert-menu.png
new file mode 100644
index 000000000..19afd07c5
Binary files /dev/null and b/docs/pr-assets/borderless-blocks/desktop-insert-menu.png differ
diff --git a/packages/workflows-ui/src/document-block-editor.module.css b/packages/workflows-ui/src/document-block-editor.module.css
index 8a82f485c..5adff159b 100644
--- a/packages/workflows-ui/src/document-block-editor.module.css
+++ b/packages/workflows-ui/src/document-block-editor.module.css
@@ -136,11 +136,8 @@
border-radius: 4px;
padding: 3px 5px;
}
-.block textarea:hover {
- background: var(--soft, #f1f2ec);
-}
.block textarea:focus-visible {
- outline: 1px solid var(--muted, #777b70);
+ outline: none;
}
.block textarea.heading { font-size:24px; font-weight:600; line-height:1.4; }
diff --git a/packages/workflows-ui/src/rich-text.module.css b/packages/workflows-ui/src/rich-text.module.css
index 487912df5..073120a31 100644
--- a/packages/workflows-ui/src/rich-text.module.css
+++ b/packages/workflows-ui/src/rich-text.module.css
@@ -12,8 +12,10 @@
outline: none;
overflow-wrap: anywhere;
}
-.editable :global(.ProseMirror):focus-visible {
- border-color: currentColor;
+/* The caret identifies text focus; keep the document surface unchanged. */
+.editable :global(.ProseMirror) {
+ cursor: text;
+ caret-color: currentColor;
}
.document :global(.ProseMirror) > * + * {
margin-top: 0.65em;
diff --git a/packages/workflows-ui/src/sop-document.module.css b/packages/workflows-ui/src/sop-document.module.css
index 76eb5c151..cab267e16 100644
--- a/packages/workflows-ui/src/sop-document.module.css
+++ b/packages/workflows-ui/src/sop-document.module.css
@@ -41,7 +41,6 @@
}
.title:focus-visible {
outline: none;
- border-color: var(--muted, currentColor);
}
.subtitle {
margin: 12px 0 0 5px;
diff --git a/packages/workflows-ui/src/workflow-editor.module.css b/packages/workflows-ui/src/workflow-editor.module.css
index 5b6a27322..667893066 100644
--- a/packages/workflows-ui/src/workflow-editor.module.css
+++ b/packages/workflows-ui/src/workflow-editor.module.css
@@ -23,7 +23,8 @@
padding: 3px 5px; background: transparent; color: var(--ink);
font: inherit; font-size: 14px; line-height: 1.6;
}
-.editor textarea:focus-visible { outline: none; border-color: var(--muted); }
+/* Text focus uses the caret; buttons and selectors retain their focus rings. */
+.editor textarea:focus-visible { outline: none; }
.editor textarea::placeholder { color: var(--muted); }
.toolbar { display: flex; flex-wrap: wrap; align-items: center; justify-content: space-between; gap: 8px; padding: 0 0 12px; margin-bottom: 8px; }
.toolbar > div { display: flex; align-items: center; gap: 6px; }
diff --git a/packages/workflows-ui/src/workflow-guide.module.css b/packages/workflows-ui/src/workflow-guide.module.css
index 79200a26d..c9e80dae3 100644
--- a/packages/workflows-ui/src/workflow-guide.module.css
+++ b/packages/workflows-ui/src/workflow-guide.module.css
@@ -354,7 +354,6 @@
}
.guide textarea:focus-visible {
outline: none;
- border-color: var(--muted);
}
.guide textarea::placeholder {
color: var(--muted);