YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(overlay): stack the live-meeting dot under the bell's unread dot (#6020)
Louis Beaumont4a34c82fea25
diff --git a/apps/screenpipe-app-tauri/app/shortcut-reminder/page.test.tsx b/apps/screenpipe-app-tauri/app/shortcut-reminder/page.test.tsxindex d74fef53e..5ac608144 100644--- a/apps/screenpipe-app-tauri/app/shortcut-reminder/page.test.tsx+++ b/apps/screenpipe-app-tauri/app/shortcut-reminder/page.test.tsx@@ -156,6 +156,36 @@ describe("recording health hover detail", () => {expect(mocks.stopMeeting).toHaveBeenCalledTimes(1);});+ it("stacks the meeting dot under the unread dot on the notifications bell", async () => {+ mocks.getRecordingHealthState.mockResolvedValue("normal");+ mocks.meetingOverlayState.active = true;+ mocks.meetingOverlayState.activeMeetingId = 42;+ mocks.meetingOverlayState.stoppableMeetingId = 42;+ vi.stubGlobal(+ "fetch",+ vi.fn().mockResolvedValue({+ ok: true,+ json: async () => [{ read: false, priority: "high" }],+ }),+ );++ render(<ShortcutReminderPage />);++ const meetingDot = await screen.findByRole("status", { name: "Meeting live" });+ const bell = screen.getByTitle("notifications");+ // Both live signals hang off the same bell, so a running meeting never+ // moves the "we are live" marker somewhere else in the pill.+ expect(bell).toContainElement(meetingDot);+ const unreadDot = bell.querySelector("span.bg-white");+ expect(unreadDot).not.toBeNull();++ // Mirrored: unread sits top right, meeting sits bottom right, same column.+ expect(meetingDot).toHaveStyle({ bottom: "-1px", right: "-1px" });+ expect(unreadDot).toHaveStyle({ top: "-1px", right: "-1px" });+ // The dot must never eat the click that opens the inbox.+ expect(meetingDot.className).toContain("pointer-events-none");+ });+it("keeps recording health ahead of the meeting preview", async () => {mocks.meetingOverlayState.active = true;mocks.meetingOverlayState.activeMeetingId = 42;diff --git a/apps/screenpipe-app-tauri/app/shortcut-reminder/page.tsx b/apps/screenpipe-app-tauri/app/shortcut-reminder/page.tsxindex 9731b509d..75ba34cb9 100644--- a/apps/screenpipe-app-tauri/app/shortcut-reminder/page.tsx+++ b/apps/screenpipe-app-tauri/app/shortcut-reminder/page.tsx@@ -558,15 +558,6 @@ export default function ShortcutReminderPage() {active={overlayData.audioActive}speechRatio={overlayData.speechRatio}/>- {meetingOverlay.active && (- <span- role="status"- aria-label="Meeting live"- title="Meeting live — hover for transcript"- className="ml-auto rounded-full bg-red-500 shrink-0"- style={{ width: `${dotPx}px`, height: `${dotPx}px` }}- />- )}</div><div className="bg-white/15" /><div className="min-w-0 overflow-hidden flex items-center" style={{ padding: `${padY}px ${padX}px` }}>@@ -595,6 +586,18 @@ export default function ShortcutReminderPage() {style={{ top: -1, right: -1, width: `${dotPx}px`, height: `${dotPx}px` }}/>)}+ {/* Live meeting mirrors the unread dot on the same bell, so both+ "we are live" signals share one column instead of the meeting+ dot floating in the audio cell. */}+ {meetingOverlay.active && (+ <span+ role="status"+ aria-label="Meeting live"+ title="Meeting live — hover for transcript"+ className="absolute rounded-full bg-red-500 pointer-events-none"+ style={{ bottom: -1, right: -1, width: `${dotPx}px`, height: `${dotPx}px` }}+ />+ )}<Bellstyle={{ width: `${smIconPx}px`, height: `${smIconPx}px` }}className={inboxUnread ? "text-white" : "text-white/60 hover:text-white"}diff --git a/apps/screenpipe-app-tauri/src-tauri/swift/shortcut_reminder.swift b/apps/screenpipe-app-tauri/src-tauri/swift/shortcut_reminder.swiftindex d1c777961..c593d944a 100644--- a/apps/screenpipe-app-tauri/src-tauri/swift/shortcut_reminder.swift+++ b/apps/screenpipe-app-tauri/src-tauri/swift/shortcut_reminder.swift@@ -490,19 +490,9 @@ struct ShortcutReminderView: View {HStack(spacing: s(3)) {AudioEqualizerView(active: metrics.audioActive, speechRatio: metrics.speechRatio).frame(width: s(18), height: s(12))- ZStack(alignment: .topTrailing) {- ScreenMatrixView(active: metrics.screenActive, captureFps: metrics.captureFps)- .frame(width: s(18), height: s(12))- .clipShape(RoundedRectangle(cornerRadius: 1))- if metrics.meetingActive {- Circle()- .fill(Color.red)- .frame(width: s(5), height: s(5))- .overlay(Circle().stroke(Color.black.opacity(0.75), lineWidth: s(1)))- .offset(x: s(2), y: -s(2))- .help("meeting live — hover for transcript")- }- }+ ScreenMatrixView(active: metrics.screenActive, captureFps: metrics.captureFps)+ .frame(width: s(18), height: s(12))+ .clipShape(RoundedRectangle(cornerRadius: 1))}.padding(.horizontal, s(3)).frame(maxHeight: .infinity)@@ -510,6 +500,7 @@ struct ShortcutReminderView: View {CollapsedBellButton(unread: metrics.inboxUnread,+ meetingActive: metrics.meetingActive,scale: scale,action: { onAction("open_inbox") })@@ -541,6 +532,9 @@ struct ShortcutReminderView: View {.frame(width: s(24), height: s(12)).padding(.horizontal, s(3))+ // The expanded bar keeps the meeting dot on the screen matrix: its+ // bell already carries an unread dot at an unscaled 1pt offset, so+ // a second dot there collides with the glyph at larger sizes.ZStack(alignment: .topTrailing) {ScreenMatrixView(active: metrics.screenActive, captureFps: metrics.captureFps).frame(width: s(24), height: s(12))@@ -741,9 +735,15 @@ struct CollapsedAppIconButton: View {// inbox; the dot mirrors the pipes-store bell's unread marker. Crucially:// no .onHover wired to isExpanded — clicking it opens the inbox without// forcing the user through the expanded layout.+//+// Both live signals sit in one column on the bell: unread notifications is+// the white dot above it, a live meeting is the red dot mirrored below it.+// Before, the meeting dot floated over the screen matrix mid-pill, so "we+// are live" moved around depending on which signal fired.@available(macOS 13.0, *)struct CollapsedBellButton: View {let unread: Bool+ let meetingActive: Boollet scale: CGFloatlet action: () -> Void@State private var hovered = false@@ -762,6 +762,12 @@ struct CollapsedBellButton: View {.frame(width: 4 * scale, height: 4 * scale).offset(x: 5 * scale, y: -5 * scale)}+ if meetingActive {+ Circle().fill(Color.red)+ .frame(width: 4 * scale, height: 4 * scale)+ .offset(x: 5 * scale, y: 5 * scale)+ .help("meeting live — hover for transcript")+ }}.frame(width: 14 * scale).frame(maxHeight: .infinity)