YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(activity): use runtime app icon port (#6397)
Ezra Ellette4f30af9cfc42
diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsxindex a86c6545f..43aef4ca6 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx@@ -17,6 +17,7 @@ Element.prototype.scrollIntoView ||= () => {};const mocks = vi.hoisted(() => ({emit: vi.fn(),+ getAppServerBaseUrl: vi.fn(),loadPersistedActivityHistory: vi.fn(),localFetch: vi.fn(),posthogCapture: vi.fn(),@@ -62,6 +63,9 @@ vi.mock("@/lib/api", () => ({ localFetch: mocks.localFetch }));vi.mock("@/lib/chat-utils", () => ({showChatWithPrefill: mocks.showChatWithPrefill,}));+vi.mock("@/lib/notifications/app-server", () => ({+ getAppServerBaseUrl: mocks.getAppServerBaseUrl,+}));vi.mock("@/lib/daily-summary-pi", () => ({runDailySummaryWithPi: mocks.runDailySummaryWithPi,}));@@ -243,6 +247,7 @@ const LEDGER_ARTIFACTS_RESPONSE = {beforeEach(() => {vi.useFakeTimers({ shouldAdvanceTime: true });vi.setSystemTime(new Date("2026-08-17T20:00:00Z"));+ mocks.getAppServerBaseUrl.mockResolvedValue("http://localhost:11535");mocks.settings.enhancedAI = true;const values = new Map<string, string>();Object.defineProperty(window, "localStorage", {@@ -975,9 +980,11 @@ describe("ActivityLedger", () => {name: /Open github.com at .* in Timeline/,});expect(appArtifact).toHaveAttribute("href", "screenpipe://frame/12345");- expect(appArtifact.querySelector("img")).toHaveAttribute(- "src",- "http://localhost:11435/app-icon?name=Arc",+ await waitFor(() =>+ expect(appArtifact.querySelector("img")).toHaveAttribute(+ "src",+ "http://localhost:11535/app-icon?name=Arc",+ ),);expect(transcriptArtifact).toHaveAttribute("href",diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.tsxindex ce5349c19..fe20dfc8c 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.tsx@@ -54,9 +54,9 @@ import {import { localFetch } from "@/lib/api";import { showChatWithPrefill } from "@/lib/chat-utils";import { runDailySummaryWithPi } from "@/lib/daily-summary-pi";-import { appIconUrl } from "@/lib/first-run/recent-activity";import { useSettings } from "@/lib/hooks/use-settings";import { useTimelineStore } from "@/lib/hooks/use-timeline-store";+import { getAppServerBaseUrl } from "@/lib/notifications/app-server";import { cn } from "@/lib/utils";import type { AIPreset } from "@/lib/utils/tauri";@@ -495,7 +495,20 @@ export function artifactsForHistoryEntry(function EvidenceArtifactIcon({ evidence }: { evidence: ActivityArtifact }) {const [iconFailed, setIconFailed] = useState(false);+ const [appServerBaseUrl, setAppServerBaseUrl] = useState<string | null>(null);const domain = siteDomain(evidence.browser_url);++ useEffect(() => {+ if (!evidence.app_name || domain) return;+ let active = true;+ void getAppServerBaseUrl().then((baseUrl) => {+ if (active) setAppServerBaseUrl(baseUrl);+ });+ return () => {+ active = false;+ };+ }, [domain, evidence.app_name]);+if (evidence.kind === "meeting") {return <Users className="h-4 w-4" aria-hidden="true" />;}@@ -509,10 +522,10 @@ function EvidenceArtifactIcon({ evidence }: { evidence: ActivityArtifact }) {/>);}- if (evidence.app_name && !iconFailed) {+ if (evidence.app_name && appServerBaseUrl && !iconFailed) {return (<img- src={appIconUrl(evidence.app_name)}+ src={`${appServerBaseUrl}/app-icon?name=${encodeURIComponent(evidence.app_name)}`}alt=""className="h-full w-full object-contain"onError={() => setIconFailed(true)}