Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(app): spawn update relaunch in its own process group (#5260)

Divanshu5feb6a395b82
diff --git a/apps/screenpipe-app-tauri/src-tauri/src/process_exit.rs b/apps/screenpipe-app-tauri/src-tauri/src/process_exit.rs
index 74f26b0ef..77f4c698e 100644
--- a/apps/screenpipe-app-tauri/src-tauri/src/process_exit.rs
+++ b/apps/screenpipe-app-tauri/src-tauri/src/process_exit.rs
@@ -170,14 +170,26 @@ fn relaunch_binary(app: &AppHandle) -> Option<PathBuf> {
/// running C/C++ atexit handlers. Tauri's built-in restart uses
/// `std::process::exit`, which can abort in ORT/ggml teardown after the new app
/// has already launched.
+///
+/// The replacement gets its own process group: launchd kills a job's whole
+/// process group when the job exits, so an inherited group dies with us.
pub fn force_app_relaunch(app: AppHandle, status: i32) -> ! {
let env = app.env();
if let Some(binary) = relaunch_binary(&app) {
- if let Err(err) = Command::new(&binary)
- .args(env.args_os.iter().skip(1))
- .spawn()
+ let mut command = Command::new(&binary);
+ command.args(env.args_os.iter().skip(1));
+ #[cfg(unix)]
{
- warn!("safe relaunch: failed to spawn {}: {err}", binary.display());
+ use std::os::unix::process::CommandExt;
+ command.process_group(0);
+ }
+ match command.spawn() {
+ Ok(child) => info!(
+ "safe relaunch: spawned replacement {} (pid {})",
+ binary.display(),
+ child.id()
+ ),
+ Err(err) => warn!("safe relaunch: failed to spawn {}: {err}", binary.display()),
}
}