Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(audio): gate Windows out of the meeting piggyback until the supervisor lands

Ezra Ellette6309a0c0ffd2
diff --git a/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx b/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
index 943794d09..196670e24 100644
--- a/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/recording-settings.tsx
@@ -3551,10 +3551,11 @@ Your screen is a pipe. Everything you see, hear, and type flows through it. Scre
)}
{/* Meeting piggyback (experimental): during meetings, capture only the
- meeting app's audio and the mic it actually uses. Windows always has
- a piggyback path (WASAPI session capture); macOS needs the CoreAudio
- Process Tap. */}
- {!settings.disableAudio && (isWindows || coreaudioTapAvailable) && (
+ meeting app's audio and the mic it actually uses. macOS-only for now
+ (needs the CoreAudio Process Tap); Windows is re-enabled once the
+ per-process capture supervisor lands (see TESTING.md "Windows
+ supervisor DEFERRED"). */}
+ {!settings.disableAudio && coreaudioTapAvailable && (
<Card className="border-border bg-card">
<CardContent className="px-3 py-2.5">
<div className="flex items-center justify-between">
@@ -3565,7 +3566,7 @@ Your screen is a pipe. Everything you see, hear, and type flows through it. Scre
meeting piggyback (experimental)
</h3>
<p className="text-xs text-muted-foreground">
- during meetings, capture only the meeting app&apos;s audio and the microphone it actually uses. falls back to standard capture automatically if unavailable.
+ during meetings, capture only the meeting app&apos;s audio and the microphone it actually uses. falls back to standard capture automatically if unavailable. only active when audio capture mode is set to meetings-only.
</p>
</div>
</div>
diff --git a/crates/screenpipe-audio/src/audio_manager/meeting_piggyback.rs b/crates/screenpipe-audio/src/audio_manager/meeting_piggyback.rs
index 81dbbf7b2..ef09fc387 100644
--- a/crates/screenpipe-audio/src/audio_manager/meeting_piggyback.rs
+++ b/crates/screenpipe-audio/src/audio_manager/meeting_piggyback.rs
@@ -318,11 +318,19 @@ pub(crate) struct PiggybackState {
/// available. The `process_tap` module (and thus `is_process_tap_available`)
/// only exists on macOS and Windows; elsewhere the tap can't be built, so the
/// observation simply never piggybacks and rides the stable path.
-#[cfg(any(target_os = "macos", target_os = "windows"))]
+///
+/// Windows is force-gated OFF here: the Windows per-process capture supervisor
+/// (target-exit detection, endpoint re-anchor, silence watchdog) was deferred
+/// (see TESTING.md "Windows supervisor DEFERRED" — the re-enable checklist).
+/// Without it the per-pid tap can zombie or double-capture, so a Windows user
+/// with the flag on must land on WarnUnavailableOnce + the stable path, i.e.
+/// exactly today's behavior. Re-enable by returning the real availability once
+/// the supervisor lands and its checklist is verified on a real machine.
+#[cfg(target_os = "macos")]
fn tap_available() -> bool {
crate::core::process_tap::is_process_tap_available()
}
-#[cfg(not(any(target_os = "macos", target_os = "windows")))]
+#[cfg(not(target_os = "macos"))]
fn tap_available() -> bool {
false
}