Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(app): keep Live View model control visible

Louis Beaumont6809ff60c651
diff --git a/apps/screenpipe-app-tauri/components/rewind/ai-presets-selector.test.tsx b/apps/screenpipe-app-tauri/components/rewind/ai-presets-selector.test.tsx
index a3a9bc2bc..80663884d 100644
--- a/apps/screenpipe-app-tauri/components/rewind/ai-presets-selector.test.tsx
+++ b/apps/screenpipe-app-tauri/components/rewind/ai-presets-selector.test.tsx
@@ -11,6 +11,7 @@ const { updateSettings } = vi.hoisted(() => ({
}));
let presetProvider: "screenpipe-cloud" | "pi" = "screenpipe-cloud";
+let presetModel = "auto";
vi.mock("@/lib/hooks/use-settings", () => ({
useSettings: () => ({
@@ -19,7 +20,7 @@ vi.mock("@/lib/hooks/use-settings", () => ({
{
id: "screenpipe-cloud default",
provider: presetProvider,
- model: "auto",
+ model: presetModel,
defaultPreset: true,
prompt: "",
apiKey: null,
@@ -58,13 +59,19 @@ import { AIPresetsSelector } from "./ai-presets-selector";
describe("AIPresetsSelector model-only mode", () => {
beforeEach(() => {
updateSettings.mockClear();
- updateSettings.mockResolvedValue(undefined);
+ updateSettings.mockImplementation(async (updates) => {
+ const nextPreset = updates.aiPresets?.find(
+ (preset: { id: string }) => preset.id === "screenpipe-cloud default",
+ );
+ if (nextPreset?.model) presetModel = nextPreset.model;
+ });
presetProvider = "screenpipe-cloud";
+ presetModel = "auto";
});
it("lets a cloud user switch models without creating another preset", async () => {
const onControlledSelect = vi.fn();
- render(
+ const { rerender } = render(
<AIPresetsSelector
compact
showModelOnly
@@ -87,6 +94,16 @@ describe("AIPresetsSelector model-only mode", () => {
});
});
expect(onControlledSelect).toHaveBeenCalledWith("screenpipe-cloud default");
+
+ rerender(
+ <AIPresetsSelector
+ compact
+ showModelOnly
+ controlledPresetId="screenpipe-cloud default"
+ onControlledSelect={onControlledSelect}
+ />,
+ );
+ expect(screen.getByRole("combobox")).toHaveTextContent("claude-sonnet-5");
});
it("lets legacy pi presets change hosted models", async () => {
diff --git a/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx b/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx
index 6f8acc429..37ec3ab12 100644
--- a/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx
@@ -878,7 +878,7 @@ describe("BrainOverview", () => {
expect(prompt.rows).toBe(1);
expect(screen.getByTestId("live-view-ai-options")).toHaveAttribute(
"aria-hidden",
- "true",
+ "false",
);
fireEvent.focus(prompt);
expect(screen.getByTestId("live-view-ai-options")).toHaveAttribute(
@@ -890,7 +890,7 @@ describe("BrainOverview", () => {
expect(prompt.rows).toBe(1);
expect(screen.getByTestId("live-view-ai-options")).toHaveAttribute(
"aria-hidden",
- "true",
+ "false",
);
await openDashboardMenu();
diff --git a/apps/screenpipe-app-tauri/components/settings/__tests__/live-view-ai-composer.test.tsx b/apps/screenpipe-app-tauri/components/settings/__tests__/live-view-ai-composer.test.tsx
index 6e9683882..222b8c2b9 100644
--- a/apps/screenpipe-app-tauri/components/settings/__tests__/live-view-ai-composer.test.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/__tests__/live-view-ai-composer.test.tsx
@@ -44,7 +44,7 @@ vi.mock("@/components/rewind/ai-presets-selector", () => ({
import { LiveViewAiComposer } from "../live-view-ai-composer";
describe("LiveViewAiComposer", () => {
- it("keeps compact model options mounted while the model popover has focus", () => {
+ it("keeps compact model options visible while focus moves into the model popover", () => {
render(
<LiveViewAiComposer
busy={false}
@@ -63,13 +63,16 @@ describe("LiveViewAiComposer", () => {
document.body.appendChild(portaledInput);
fireEvent.blur(modelSelector, { relatedTarget: portaledInput });
- expect(screen.getByTestId("live-view-ai-options")).toBeInTheDocument();
+ expect(screen.getByTestId("live-view-ai-options")).toHaveAttribute(
+ "aria-hidden",
+ "false",
+ );
expect(screen.getByTestId("model-selector")).toBeInTheDocument();
portaledInput.remove();
});
- it("does not unmount the model picker when the compact prompt collapses", () => {
+ it("does not hide the model picker when the compact prompt collapses", () => {
render(
<LiveViewAiComposer
busy={false}
@@ -82,7 +85,7 @@ describe("LiveViewAiComposer", () => {
const prompt = screen.getByTestId("live-view-ai-prompt");
const options = screen.getByTestId("live-view-ai-options");
- expect(options).toHaveAttribute("aria-hidden", "true");
+ expect(options).toHaveAttribute("aria-hidden", "false");
expect(screen.getByTestId("model-selector")).toBeInTheDocument();
fireEvent.focus(prompt);
@@ -92,7 +95,7 @@ describe("LiveViewAiComposer", () => {
document.body.appendChild(outside);
fireEvent.blur(prompt, { relatedTarget: outside });
- expect(options).toHaveAttribute("aria-hidden", "true");
+ expect(options).toHaveAttribute("aria-hidden", "false");
expect(screen.getByTestId("model-selector")).toBeInTheDocument();
outside.remove();
});
diff --git a/apps/screenpipe-app-tauri/components/settings/live-view-ai-composer.tsx b/apps/screenpipe-app-tauri/components/settings/live-view-ai-composer.tsx
index eef17b699..9b9fe40f5 100644
--- a/apps/screenpipe-app-tauri/components/settings/live-view-ai-composer.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/live-view-ai-composer.tsx
@@ -117,7 +117,6 @@ export function LiveViewAiComposer({
);
const [prompt, setPrompt] = useState("");
const [compactFocused, setCompactFocused] = useState(false);
- const [modelSelectorOpen, setModelSelectorOpen] = useState(false);
const selectedPreset = presets.find(
(preset) => preset.id === selectedPresetId,
@@ -147,8 +146,12 @@ export function LiveViewAiComposer({
const compactExpanded =
compact &&
!hostedUsageExhausted &&
- (compactFocused || modelSelectorOpen || busy || Boolean(feedback));
- const compactOptionsVisible = compactExpanded && !busy && !feedback;
+ (compactFocused || busy || Boolean(feedback));
+ // Keep the model control independent from the textarea's focus disclosure.
+ // Radix renders its menu in a portal, so hiding this row on blur can make the
+ // trigger disappear while the user is moving focus into the menu.
+ const compactOptionsVisible =
+ compact && !hostedUsageExhausted && !busy && !feedback;
const intent = inferLiveViewGenerationIntent(
prompt,
Boolean(currentViewTitle),
@@ -283,7 +286,6 @@ export function LiveViewAiComposer({
showLoginCta
containerClassName="w-auto min-w-36"
triggerClassName="h-8 rounded-none"
- onOpenChange={setModelSelectorOpen}
/>
{prompt.trim() && (
<span