Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

feat(app): add more remote safety controls

Louis Beaumont685caab9fa36
diff --git a/apps/screenpipe-app-tauri/components/desktop-remote-control.test.tsx b/apps/screenpipe-app-tauri/components/desktop-remote-control.test.tsx
index 0f193f162..331b53fc4 100644
--- a/apps/screenpipe-app-tauri/components/desktop-remote-control.test.tsx
+++ b/apps/screenpipe-app-tauri/components/desktop-remote-control.test.tsx
@@ -65,6 +65,8 @@ describe("DesktopRemoteControl", () => {
enableSemanticContext: false,
experimentalCoreaudioSystemAudio: true,
experimentalMeetingPiggyback: false,
+ filterMusic: true,
+ prioritizeInputLatency: false,
aecMode: "off",
screenpipeAecEnabled: false,
macosInputVpioEnabled: false,
@@ -93,6 +95,14 @@ describe("DesktopRemoteControl", () => {
defaultEnabled: true,
forceDisabled: false,
},
+ "music-filter-control": {
+ defaultEnabled: false,
+ forceDisabled: false,
+ },
+ "input-latency-control": {
+ defaultEnabled: true,
+ forceDisabled: false,
+ },
"aec-mode-control": {
defaultValue: "macos",
forceDisabled: false,
@@ -107,6 +117,7 @@ describe("DesktopRemoteControl", () => {
enableSemanticContext: true,
experimentalCoreaudioSystemAudio: false,
experimentalMeetingPiggyback: true,
+ filterMusic: false,
aecMode: "macos",
macosInputVpioEnabled: true,
}),
@@ -117,19 +128,43 @@ describe("DesktopRemoteControl", () => {
expect(mocks.stopScreenpipe).toHaveBeenCalledTimes(1);
});
+ it("applies the input-latency default only on Windows", async () => {
+ mocks.settings = { ...mocks.settings, platform: "windows" };
+ mocks.payloads = {
+ "input-latency-control": {
+ defaultEnabled: true,
+ forceDisabled: false,
+ },
+ };
+
+ render(<DesktopRemoteControl enabled />);
+
+ await waitFor(() =>
+ expect(mocks.updateSettings).toHaveBeenCalledWith(
+ expect.objectContaining({ prioritizeInputLatency: true }),
+ ),
+ );
+ await waitFor(() => expect(mocks.spawnScreenpipe).toHaveBeenCalled());
+ });
+
it("persists every force-off without restarting deliberately paused capture", async () => {
mocks.settings = {
...mocks.settings,
enableSemanticContext: true,
experimentalCoreaudioSystemAudio: true,
experimentalMeetingPiggyback: true,
- aecMode: "macos",
- macosInputVpioEnabled: true,
+ filterMusic: true,
+ prioritizeInputLatency: true,
+ platform: "windows",
+ aecMode: "windows",
+ windowsInputAecEnabled: true,
remoteControlPreferences: {
semanticContext: true,
coreAudioSystemAudio: true,
smartRecording: true,
- aecMode: "macos",
+ filterMusic: true,
+ prioritizeInputLatency: true,
+ aecMode: "windows",
},
};
mocks.payloads = {
@@ -145,6 +180,14 @@ describe("DesktopRemoteControl", () => {
defaultEnabled: false,
forceDisabled: true,
},
+ "music-filter-control": {
+ defaultEnabled: true,
+ forceDisabled: true,
+ },
+ "input-latency-control": {
+ defaultEnabled: true,
+ forceDisabled: true,
+ },
"aec-mode-control": {
defaultValue: "off",
forceDisabled: true,
@@ -160,11 +203,14 @@ describe("DesktopRemoteControl", () => {
enableSemanticContext: false,
experimentalCoreaudioSystemAudio: false,
experimentalMeetingPiggyback: false,
+ filterMusic: false,
+ prioritizeInputLatency: false,
aecMode: "off",
- macosInputVpioEnabled: false,
+ windowsInputAecEnabled: false,
}),
),
);
+ await waitFor(() => expect(mocks.isCapturePaused).toHaveBeenCalled());
expect(mocks.stopScreenpipe).not.toHaveBeenCalled();
expect(mocks.spawnScreenpipe).not.toHaveBeenCalled();
});
diff --git a/apps/screenpipe-app-tauri/components/desktop-remote-control.tsx b/apps/screenpipe-app-tauri/components/desktop-remote-control.tsx
index 14dc70f4a..3c8e55799 100644
--- a/apps/screenpipe-app-tauri/components/desktop-remote-control.tsx
+++ b/apps/screenpipe-app-tauri/components/desktop-remote-control.tsx
@@ -83,9 +83,7 @@ export function DesktopRemoteControl({ enabled }: { enabled: boolean }) {
settingsRef.current = effective;
const engineRestarted =
- changedControls.length > 0
- ? await restartRunningCapture()
- : false;
+ changedControls.length > 0 ? await restartRunningCapture() : false;
if (sendExposure) {
posthog.capture("desktop_remote_control_applied", {
@@ -106,6 +104,10 @@ export function DesktopRemoteControl({ enabled }: { enabled: boolean }) {
effective_smart_recording: Boolean(
effective.experimentalMeetingPiggyback,
),
+ effective_music_filter: Boolean(effective.filterMusic),
+ effective_prioritize_input_latency: Boolean(
+ effective.prioritizeInputLatency,
+ ),
effective_aec_mode: effective.aecMode ?? "off",
preference_semantic_context:
preferences.semanticContext === null
@@ -125,6 +127,18 @@ export function DesktopRemoteControl({ enabled }: { enabled: boolean }) {
: preferences.smartRecording
? "on"
: "off",
+ preference_music_filter:
+ preferences.filterMusic === null
+ ? "unset"
+ : preferences.filterMusic
+ ? "on"
+ : "off",
+ preference_prioritize_input_latency:
+ preferences.prioritizeInputLatency === null
+ ? "unset"
+ : preferences.prioritizeInputLatency
+ ? "on"
+ : "off",
preference_aec_mode: preferences.aecMode ?? "unset",
engine_restarted: engineRestarted,
});
diff --git a/apps/screenpipe-app-tauri/lib/desktop-remote-control.test.ts b/apps/screenpipe-app-tauri/lib/desktop-remote-control.test.ts
index ae628060d..ae85b72a7 100644
--- a/apps/screenpipe-app-tauri/lib/desktop-remote-control.test.ts
+++ b/apps/screenpipe-app-tauri/lib/desktop-remote-control.test.ts
@@ -12,6 +12,7 @@ import {
parseAecModeRemotePolicy,
parseBooleanRemotePolicy,
resolveAecModeRemoteValue,
+ resolveBooleanRemoteControlValue,
resolveBooleanRemoteValue,
type DesktopRemotePolicySnapshot,
} from "./desktop-remote-control";
@@ -22,10 +23,20 @@ describe("desktop remote control", () => {
defaultEnabled: false,
forceDisabled: false,
});
- expect(parseBooleanRemotePolicy("coreAudioSystemAudio", undefined)).toEqual({
+ expect(parseBooleanRemotePolicy("coreAudioSystemAudio", undefined)).toEqual(
+ {
+ defaultEnabled: true,
+ forceDisabled: false,
+ },
+ );
+ expect(parseBooleanRemotePolicy("filterMusic", undefined)).toEqual({
defaultEnabled: true,
forceDisabled: false,
});
+ expect(parseBooleanRemotePolicy("prioritizeInputLatency", null)).toEqual({
+ defaultEnabled: false,
+ forceDisabled: false,
+ });
expect(
parseBooleanRemotePolicy("smartRecording", {
defaultEnabled: true,
@@ -78,12 +89,34 @@ describe("desktop remote control", () => {
).toBe("screenpipe");
});
+ it("keeps the input-latency optimization Windows-only", () => {
+ const defaultOn = { defaultEnabled: true, forceDisabled: false };
+ expect(
+ resolveBooleanRemoteControlValue(
+ "prioritizeInputLatency",
+ null,
+ defaultOn,
+ "macos",
+ ),
+ ).toBe(false);
+ expect(
+ resolveBooleanRemoteControlValue(
+ "prioritizeInputLatency",
+ null,
+ defaultOn,
+ "windows",
+ ),
+ ).toBe(true);
+ });
+
it("preserves existing values while new stores inherit remote defaults", () => {
expect(
normalizeDesktopRemotePreferences({
enableSemanticContext: true,
experimentalCoreaudioSystemAudio: false,
experimentalMeetingPiggyback: true,
+ filterMusic: false,
+ prioritizeInputLatency: true,
aecMode: "screenpipe",
platform: "linux",
}),
@@ -91,6 +124,8 @@ describe("desktop remote control", () => {
semanticContext: true,
coreAudioSystemAudio: false,
smartRecording: true,
+ filterMusic: false,
+ prioritizeInputLatency: true,
aecMode: "screenpipe",
});
@@ -119,6 +154,33 @@ describe("desktop remote control", () => {
});
});
+ it("fills new controls into older valid schema-v1 snapshots", () => {
+ const legacySnapshot = {
+ schemaVersion: 1,
+ boolean: {
+ semanticContext: { defaultEnabled: true, forceDisabled: true },
+ coreAudioSystemAudio: {
+ defaultEnabled: true,
+ forceDisabled: false,
+ },
+ smartRecording: { defaultEnabled: false, forceDisabled: false },
+ },
+ aecMode: { defaultValue: "off", forceDisabled: false },
+ };
+
+ expect(normalizeDesktopRemotePolicySnapshot(legacySnapshot)).toEqual({
+ ...legacySnapshot,
+ boolean: {
+ ...legacySnapshot.boolean,
+ filterMusic: { defaultEnabled: true, forceDisabled: false },
+ prioritizeInputLatency: {
+ defaultEnabled: false,
+ forceDisabled: false,
+ },
+ },
+ });
+ });
+
it("builds one bounded patch and reports only effective engine changes", () => {
const policy: DesktopRemotePolicySnapshot = {
schemaVersion: 1,
@@ -129,6 +191,11 @@ describe("desktop remote control", () => {
forceDisabled: false,
},
smartRecording: { defaultEnabled: true, forceDisabled: false },
+ filterMusic: { defaultEnabled: false, forceDisabled: false },
+ prioritizeInputLatency: {
+ defaultEnabled: false,
+ forceDisabled: false,
+ },
},
aecMode: { defaultValue: "macos", forceDisabled: false },
};
@@ -140,6 +207,8 @@ describe("desktop remote control", () => {
enableSemanticContext: false,
experimentalCoreaudioSystemAudio: true,
experimentalMeetingPiggyback: false,
+ filterMusic: true,
+ prioritizeInputLatency: false,
aecMode: "off",
screenpipeAecEnabled: false,
macosInputVpioEnabled: false,
@@ -153,6 +222,7 @@ describe("desktop remote control", () => {
enableSemanticContext: true,
experimentalCoreaudioSystemAudio: false,
experimentalMeetingPiggyback: true,
+ filterMusic: false,
aecMode: "macos",
screenpipeAecEnabled: false,
macosInputVpioEnabled: true,
@@ -162,6 +232,7 @@ describe("desktop remote control", () => {
"semanticContext",
"coreAudioSystemAudio",
"smartRecording",
+ "filterMusic",
"aecMode",
]);
});
@@ -176,6 +247,11 @@ describe("desktop remote control", () => {
forceDisabled: false,
},
smartRecording: { defaultEnabled: true, forceDisabled: false },
+ filterMusic: { defaultEnabled: false, forceDisabled: false },
+ prioritizeInputLatency: {
+ defaultEnabled: true,
+ forceDisabled: false,
+ },
},
aecMode: { defaultValue: "screenpipe", forceDisabled: false },
};
@@ -185,18 +261,24 @@ describe("desktop remote control", () => {
semanticContext: false,
coreAudioSystemAudio: true,
smartRecording: false,
+ filterMusic: true,
+ prioritizeInputLatency: false,
aecMode: "off" as const,
},
remoteControlPolicy: LOCAL_DESKTOP_REMOTE_POLICY,
enableSemanticContext: false,
experimentalCoreaudioSystemAudio: true,
experimentalMeetingPiggyback: false,
+ filterMusic: true,
+ prioritizeInputLatency: false,
aecMode: "off" as const,
screenpipeAecEnabled: false,
macosInputVpioEnabled: false,
windowsInputAecEnabled: false,
};
- expect(buildDesktopRemoteControlPatch(settings, policy).changedControls).toEqual([]);
+ expect(
+ buildDesktopRemoteControlPatch(settings, policy).changedControls,
+ ).toEqual([]);
});
});
diff --git a/apps/screenpipe-app-tauri/lib/desktop-remote-control.ts b/apps/screenpipe-app-tauri/lib/desktop-remote-control.ts
index 875444ea9..7b42494f9 100644
--- a/apps/screenpipe-app-tauri/lib/desktop-remote-control.ts
+++ b/apps/screenpipe-app-tauri/lib/desktop-remote-control.ts
@@ -4,6 +4,13 @@
export type AecMode = "off" | "screenpipe" | "macos" | "windows";
+type BooleanRemoteControlDefinition = {
+ flagKey: string;
+ settingKey: string;
+ shippedDefault: boolean;
+ supportedPlatforms?: readonly string[];
+};
+
export const BOOLEAN_REMOTE_CONTROL_DEFINITIONS = {
semanticContext: {
flagKey: "semantic-context-control",
@@ -20,7 +27,18 @@ export const BOOLEAN_REMOTE_CONTROL_DEFINITIONS = {
settingKey: "experimentalMeetingPiggyback",
shippedDefault: false,
},
-} as const;
+ filterMusic: {
+ flagKey: "music-filter-control",
+ settingKey: "filterMusic",
+ shippedDefault: true,
+ },
+ prioritizeInputLatency: {
+ flagKey: "input-latency-control",
+ settingKey: "prioritizeInputLatency",
+ shippedDefault: false,
+ supportedPlatforms: ["windows"],
+ },
+} as const satisfies Record<string, BooleanRemoteControlDefinition>;
export const AEC_MODE_CONTROL_FLAG_KEY = "aec-mode-control";
@@ -47,6 +65,8 @@ export type DesktopRemotePreferences = {
semanticContext: boolean | null;
coreAudioSystemAudio: boolean | null;
smartRecording: boolean | null;
+ filterMusic: boolean | null;
+ prioritizeInputLatency: boolean | null;
aecMode: AecMode | null;
};
@@ -60,25 +80,21 @@ export type RemoteControllableSettings = {
enableSemanticContext?: boolean;
experimentalCoreaudioSystemAudio?: boolean;
experimentalMeetingPiggyback?: boolean;
+ filterMusic?: boolean;
+ prioritizeInputLatency?: boolean;
aecMode?: AecMode;
screenpipeAecEnabled?: boolean;
macosInputVpioEnabled?: boolean;
windowsInputAecEnabled?: boolean;
};
-const AEC_MODES = new Set<AecMode>([
- "off",
- "screenpipe",
- "macos",
- "windows",
-]);
+const AEC_MODES = new Set<AecMode>(["off", "screenpipe", "macos", "windows"]);
function localBooleanPolicy(
control: BooleanRemoteControlKey,
): BooleanRemotePolicy {
return {
- defaultEnabled:
- BOOLEAN_REMOTE_CONTROL_DEFINITIONS[control].shippedDefault,
+ defaultEnabled: BOOLEAN_REMOTE_CONTROL_DEFINITIONS[control].shippedDefault,
forceDisabled: false,
};
}
@@ -89,6 +105,8 @@ export const LOCAL_DESKTOP_REMOTE_POLICY: DesktopRemotePolicySnapshot = {
semanticContext: localBooleanPolicy("semanticContext"),
coreAudioSystemAudio: localBooleanPolicy("coreAudioSystemAudio"),
smartRecording: localBooleanPolicy("smartRecording"),
+ filterMusic: localBooleanPolicy("filterMusic"),
+ prioritizeInputLatency: localBooleanPolicy("prioritizeInputLatency"),
},
aecMode: {
defaultValue: "off",
@@ -96,12 +114,15 @@ export const LOCAL_DESKTOP_REMOTE_POLICY: DesktopRemotePolicySnapshot = {
},
};
-export const NEW_INSTALL_REMOTE_CONTROL_PREFERENCES: DesktopRemotePreferences = {
- semanticContext: null,
- coreAudioSystemAudio: null,
- smartRecording: null,
- aecMode: null,
-};
+export const NEW_INSTALL_REMOTE_CONTROL_PREFERENCES: DesktopRemotePreferences =
+ {
+ semanticContext: null,
+ coreAudioSystemAudio: null,
+ smartRecording: null,
+ filterMusic: null,
+ prioritizeInputLatency: null,
+ aecMode: null,
+ };
function hasOnlyKeys(candidate: Record<string, unknown>, keys: string[]) {
const actual = Object.keys(candidate).sort();
@@ -137,11 +158,17 @@ function cloneLocalDesktopRemotePolicy(): DesktopRemotePolicySnapshot {
return {
schemaVersion: 1,
boolean: {
- semanticContext: { ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.semanticContext },
+ semanticContext: {
+ ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.semanticContext,
+ },
coreAudioSystemAudio: {
...LOCAL_DESKTOP_REMOTE_POLICY.boolean.coreAudioSystemAudio,
},
smartRecording: { ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.smartRecording },
+ filterMusic: { ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.filterMusic },
+ prioritizeInputLatency: {
+ ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.prioritizeInputLatency,
+ },
},
aecMode: { ...LOCAL_DESKTOP_REMOTE_POLICY.aecMode },
};
@@ -206,26 +233,28 @@ export function normalizeDesktopRemotePolicySnapshot(
return fallback;
}
const boolean = candidate.boolean as Record<string, unknown>;
+ const controlKeys = Object.keys(
+ BOOLEAN_REMOTE_CONTROL_DEFINITIONS,
+ ) as BooleanRemoteControlKey[];
if (
- !hasOnlyKeys(boolean, [
- "semanticContext",
- "coreAudioSystemAudio",
- "smartRecording",
- ]) ||
- !isBooleanRemotePolicy(boolean.semanticContext) ||
- !isBooleanRemotePolicy(boolean.coreAudioSystemAudio) ||
- !isBooleanRemotePolicy(boolean.smartRecording) ||
+ Object.keys(boolean).some(
+ (key) => !controlKeys.includes(key as BooleanRemoteControlKey),
+ ) ||
!isAecModeRemotePolicy(candidate.aecMode)
) {
return fallback;
}
+ const normalizedBoolean = { ...fallback.boolean };
+ for (const control of controlKeys) {
+ const storedPolicy = boolean[control];
+ // Older schema-v1 snapshots legitimately lack newly reviewed controls.
+ if (storedPolicy === undefined) continue;
+ if (!isBooleanRemotePolicy(storedPolicy)) return fallback;
+ normalizedBoolean[control] = { ...storedPolicy };
+ }
return {
schemaVersion: 1,
- boolean: {
- semanticContext: { ...boolean.semanticContext },
- coreAudioSystemAudio: { ...boolean.coreAudioSystemAudio },
- smartRecording: { ...boolean.smartRecording },
- },
+ boolean: normalizedBoolean,
aecMode: { ...candidate.aecMode },
};
}
@@ -254,6 +283,16 @@ export function readDesktopRemotePolicySnapshot(
BOOLEAN_REMOTE_CONTROL_DEFINITIONS.smartRecording.flagKey,
),
),
+ filterMusic: parseBooleanRemotePolicy(
+ "filterMusic",
+ payloadForFlag(BOOLEAN_REMOTE_CONTROL_DEFINITIONS.filterMusic.flagKey),
+ ),
+ prioritizeInputLatency: parseBooleanRemotePolicy(
+ "prioritizeInputLatency",
+ payloadForFlag(
+ BOOLEAN_REMOTE_CONTROL_DEFINITIONS.prioritizeInputLatency.flagKey,
+ ),
+ ),
},
aecMode: parseAecModeRemotePolicy(
payloadForFlag(AEC_MODE_CONTROL_FLAG_KEY),
@@ -272,6 +311,25 @@ export function resolveBooleanRemoteValue(
return preference ?? policy.defaultEnabled;
}
+export function resolveBooleanRemoteControlValue(
+ control: BooleanRemoteControlKey,
+ preference: boolean | null | undefined,
+ policy: BooleanRemotePolicy,
+ platform?: string,
+ managedValue?: boolean,
+): boolean {
+ const definition = BOOLEAN_REMOTE_CONTROL_DEFINITIONS[
+ control
+ ] as BooleanRemoteControlDefinition;
+ if (
+ definition.supportedPlatforms &&
+ !definition.supportedPlatforms.includes(platform ?? "unknown")
+ ) {
+ return false;
+ }
+ return resolveBooleanRemoteValue(preference, policy, managedValue);
+}
+
export function normalizeAecModeForPlatform(
mode: AecMode | null | undefined,
platform?: string,
@@ -307,7 +365,10 @@ function validBooleanPreference(value: unknown): value is boolean | null {
}
function validAecPreference(value: unknown): value is AecMode | null {
- return value === null || (typeof value === "string" && AEC_MODES.has(value as AecMode));
+ return (
+ value === null ||
+ (typeof value === "string" && AEC_MODES.has(value as AecMode))
+ );
}
/**
@@ -325,17 +386,26 @@ export function normalizeDesktopRemotePreferences(
: validBooleanPreference(legacySemanticPreference)
? legacySemanticPreference
: Boolean(settings.enableSemanticContext ?? false),
- coreAudioSystemAudio: validBooleanPreference(
- current?.coreAudioSystemAudio,
- )
+ coreAudioSystemAudio: validBooleanPreference(current?.coreAudioSystemAudio)
? current.coreAudioSystemAudio
: Boolean(settings.experimentalCoreaudioSystemAudio ?? true),
smartRecording: validBooleanPreference(current?.smartRecording)
? current.smartRecording
: Boolean(settings.experimentalMeetingPiggyback ?? false),
+ filterMusic: validBooleanPreference(current?.filterMusic)
+ ? current.filterMusic
+ : Boolean(settings.filterMusic ?? true),
+ prioritizeInputLatency: validBooleanPreference(
+ current?.prioritizeInputLatency,
+ )
+ ? current.prioritizeInputLatency
+ : Boolean(settings.prioritizeInputLatency ?? false),
aecMode: validAecPreference(current?.aecMode)
? current.aecMode
- : normalizeAecModeForPlatform(settings.aecMode ?? "off", settings.platform),
+ : normalizeAecModeForPlatform(
+ settings.aecMode ?? "off",
+ settings.platform,
+ ),
};
}
@@ -382,21 +452,41 @@ export function buildDesktopRemoteControlPatch(
const preferences = normalizeDesktopRemotePreferences(settings);
const managed = settings.enterpriseManagedSettings ?? {};
const effective = {
- semanticContext: resolveBooleanRemoteValue(
+ semanticContext: resolveBooleanRemoteControlValue(
+ "semanticContext",
preferences.semanticContext,
policy.boolean.semanticContext,
+ settings.platform,
parseManagedBoolean(managed.enableSemanticContext),
),
- coreAudioSystemAudio: resolveBooleanRemoteValue(
+ coreAudioSystemAudio: resolveBooleanRemoteControlValue(
+ "coreAudioSystemAudio",
preferences.coreAudioSystemAudio,
policy.boolean.coreAudioSystemAudio,
+ settings.platform,
parseManagedBoolean(managed.experimentalCoreaudioSystemAudio),
),
- smartRecording: resolveBooleanRemoteValue(
+ smartRecording: resolveBooleanRemoteControlValue(
+ "smartRecording",
preferences.smartRecording,
policy.boolean.smartRecording,
+ settings.platform,
parseManagedBoolean(managed.experimentalMeetingPiggyback),
),
+ filterMusic: resolveBooleanRemoteControlValue(
+ "filterMusic",
+ preferences.filterMusic,
+ policy.boolean.filterMusic,
+ settings.platform,
+ parseManagedBoolean(managed.filterMusic),
+ ),
+ prioritizeInputLatency: resolveBooleanRemoteControlValue(
+ "prioritizeInputLatency",
+ preferences.prioritizeInputLatency,
+ policy.boolean.prioritizeInputLatency,
+ settings.platform,
+ parseManagedBoolean(managed.prioritizeInputLatency),
+ ),
aecMode: resolveAecModeRemoteValue(
preferences.aecMode,
policy.aecMode,
@@ -420,18 +510,23 @@ export function buildDesktopRemoteControlPatch(
changedControls.push("semanticContext");
}
if (
- settings.experimentalCoreaudioSystemAudio !==
- effective.coreAudioSystemAudio
+ settings.experimentalCoreaudioSystemAudio !== effective.coreAudioSystemAudio
) {
patch.experimentalCoreaudioSystemAudio = effective.coreAudioSystemAudio;
changedControls.push("coreAudioSystemAudio");
}
- if (
- settings.experimentalMeetingPiggyback !== effective.smartRecording
- ) {
+ if (settings.experimentalMeetingPiggyback !== effective.smartRecording) {
patch.experimentalMeetingPiggyback = effective.smartRecording;
changedControls.push("smartRecording");
}
+ if (settings.filterMusic !== effective.filterMusic) {
+ patch.filterMusic = effective.filterMusic;
+ changedControls.push("filterMusic");
+ }
+ if (settings.prioritizeInputLatency !== effective.prioritizeInputLatency) {
+ patch.prioritizeInputLatency = effective.prioritizeInputLatency;
+ changedControls.push("prioritizeInputLatency");
+ }
const aecSettings = getAecModeSettings(effective.aecMode);
if (
diff --git a/apps/screenpipe-app-tauri/lib/hooks/__tests__/default-settings-remote-controls.test.ts b/apps/screenpipe-app-tauri/lib/hooks/__tests__/default-settings-remote-controls.test.ts
index 09bf4691d..a95bf3b56 100644
--- a/apps/screenpipe-app-tauri/lib/hooks/__tests__/default-settings-remote-controls.test.ts
+++ b/apps/screenpipe-app-tauri/lib/hooks/__tests__/default-settings-remote-controls.test.ts
@@ -16,6 +16,8 @@ describe("default settings: remote controls", () => {
expect(settings.enableSemanticContext).toBe(false);
expect(settings.experimentalCoreaudioSystemAudio).toBe(true);
expect(settings.experimentalMeetingPiggyback).toBe(false);
+ expect(settings.filterMusic).toBe(true);
+ expect(settings.prioritizeInputLatency).toBe(false);
expect(settings.aecMode).toBe("off");
expect(settings.remoteControlPreferences).toEqual(
NEW_INSTALL_REMOTE_CONTROL_PREFERENCES,
diff --git a/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx b/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx
index 765d6ad0b..a515d0e52 100644
--- a/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx
+++ b/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx
@@ -755,6 +755,12 @@ let DEFAULT_SETTINGS: Settings = {
smartRecording: {
...LOCAL_DESKTOP_REMOTE_POLICY.boolean.smartRecording,
},
+ filterMusic: {
+ ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.filterMusic,
+ },
+ prioritizeInputLatency: {
+ ...LOCAL_DESKTOP_REMOTE_POLICY.boolean.prioritizeInputLatency,
+ },
},
aecMode: { ...LOCAL_DESKTOP_REMOTE_POLICY.aecMode },
},
@@ -776,6 +782,7 @@ let DEFAULT_SETTINGS: Settings = {
cloudArchiveRetentionDays: 7,
meetingSummaryPipeSlug: "meeting-summary",
filterMusic: true,
+ prioritizeInputLatency: false,
ignoreIncognitoWindows: true,
enhancedIncognitoDetection: false,
pauseOnDrmContent: false,
diff --git a/apps/screenpipe-app-tauri/src-tauri/src/store.rs b/apps/screenpipe-app-tauri/src-tauri/src/store.rs
index 27b3f48ac..cbc591d2e 100644
--- a/apps/screenpipe-app-tauri/src-tauri/src/store.rs
+++ b/apps/screenpipe-app-tauri/src-tauri/src/store.rs
@@ -1410,6 +1410,8 @@ Rules:
"semanticContext": null,
"coreAudioSystemAudio": null,
"smartRecording": null,
+ "filterMusic": null,
+ "prioritizeInputLatency": null,
"aecMode": null,
}),
),
@@ -1430,6 +1432,14 @@ Rules:
"defaultEnabled": false,
"forceDisabled": false,
},
+ "filterMusic": {
+ "defaultEnabled": true,
+ "forceDisabled": false,
+ },
+ "prioritizeInputLatency": {
+ "defaultEnabled": false,
+ "forceDisabled": false,
+ },
},
"aecMode": {
"defaultValue": "off",
@@ -1679,6 +1689,12 @@ impl SettingsStore {
if boolean_force_disabled("smartRecording") {
settings.experimental_meeting_piggyback = false;
}
+ if boolean_force_disabled("filterMusic") {
+ settings.filter_music = false;
+ }
+ if boolean_force_disabled("prioritizeInputLatency") {
+ settings.prioritize_input_latency = false;
+ }
if policy
.pointer("/aecMode/forceDisabled")
.and_then(Value::as_bool)
@@ -3298,6 +3314,8 @@ mod tests {
store.recording.enable_semantic_context = true;
store.recording.experimental_coreaudio_system_audio = true;
store.recording.experimental_meeting_piggyback = true;
+ store.recording.filter_music = true;
+ store.recording.prioritize_input_latency = true;
store.recording.aec_mode = screenpipe_config::AecMode::Macos;
store.recording.macos_input_vpio_enabled = true;
store.extra.insert(
@@ -3308,6 +3326,8 @@ mod tests {
"semanticContext": {"defaultEnabled": true, "forceDisabled": true},
"coreAudioSystemAudio": {"defaultEnabled": true, "forceDisabled": true},
"smartRecording": {"defaultEnabled": true, "forceDisabled": true},
+ "filterMusic": {"defaultEnabled": true, "forceDisabled": true},
+ "prioritizeInputLatency": {"defaultEnabled": true, "forceDisabled": true},
},
"aecMode": {"defaultValue": "macos", "forceDisabled": true},
}),
@@ -3317,6 +3337,8 @@ mod tests {
assert!(!effective.enable_semantic_context);
assert!(!effective.experimental_coreaudio_system_audio);
assert!(!effective.experimental_meeting_piggyback);
+ assert!(!effective.filter_music);
+ assert!(!effective.prioritize_input_latency);
assert_eq!(effective.aec_mode, screenpipe_config::AecMode::Off);
assert!(!effective.screenpipe_aec_enabled);
assert!(!effective.macos_input_vpio_enabled);
@@ -3352,6 +3374,20 @@ mod tests {
.and_then(|preferences| preferences.get("coreAudioSystemAudio")),
Some(&Value::Null),
);
+ assert_eq!(
+ store
+ .extra
+ .get("remoteControlPreferences")
+ .and_then(|preferences| preferences.get("filterMusic")),
+ Some(&Value::Null),
+ );
+ assert_eq!(
+ store
+ .extra
+ .get("remoteControlPreferences")
+ .and_then(|preferences| preferences.get("prioritizeInputLatency")),
+ Some(&Value::Null),
+ );
assert_eq!(
store
.extra