YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(chat): scope AI limit banner to hosted presets (#6619)
Louis Beaumont69fe4caecc9e
diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/chat-composer.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/chat-composer.tsxindex f4c6df35e..4ad713f72 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/chat-composer.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/chat-composer.tsx@@ -82,7 +82,7 @@ export function ChatComposer({isDragging={input.isDragging}/>- <UpgradeQuotaBanner />+ <UpgradeQuotaBanner activePreset={modelControls.activePreset} /><FreePlanWallStrip /><FreeUpgradeSheet />diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.test.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.test.tsxindex be866831f..228b04657 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.test.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.test.tsx@@ -4,6 +4,7 @@import { fireEvent, render, screen, waitFor } from "@testing-library/react";import { beforeEach, describe, expect, it, vi } from "vitest";+import type { AIPreset } from "@/lib/utils/tauri";import { UpgradeQuotaBanner } from "./upgrade-quota-banner";const mocks = vi.hoisted(() => ({@@ -14,6 +15,7 @@ const mocks = vi.hoisted(() => ({clearQuotaUpgrade: vi.fn(),openExternalUrl: vi.fn(),openBusinessUpgradeSurface: vi.fn(),+ usageQueryEnabled: undefined as boolean | undefined,}));vi.mock("@/lib/hooks/use-settings", () => ({@@ -29,7 +31,10 @@ vi.mock("@/lib/hooks/use-settings", () => ({}));vi.mock("@/lib/hooks/use-usage-status", () => ({- useUsageStatus: () => mocks.usageState,+ useUsageStatusQuery: (enabled: boolean) => {+ mocks.usageQueryEnabled = enabled;+ return { usage: enabled ? mocks.usageState : null };+ },formatResetTime: () => "5:00 PM",formatAllowanceReset: () => "Aug 17, 5:00 PM",formatUsagePercent: (percent: number) => `${percent}%`,@@ -68,6 +73,12 @@ function expectNeutralPrimary(button: HTMLElement) {);}+const hostedPreset = { provider: "screenpipe-cloud" } as AIPreset;++function renderBanner(activePreset: AIPreset = hostedPreset) {+ return render(<UpgradeQuotaBanner activePreset={activePreset} />);+}+describe("UpgradeQuotaBanner", () => {beforeEach(() => {mocks.usageState = {@@ -82,6 +93,7 @@ describe("UpgradeQuotaBanner", () => {};mocks.gateState = false;mocks.seenEligibility = undefined;+ mocks.usageQueryEnabled = undefined;mocks.blockedUpgrade = null;mocks.clearQuotaUpgrade.mockReset();mocks.openExternalUrl.mockReset();@@ -91,11 +103,49 @@ describe("UpgradeQuotaBanner", () => {});it("does not render while hydrated eligibility gates are unresolved or false", () => {- render(<UpgradeQuotaBanner />);+ renderBanner();expect(mocks.seenEligibility).toBe(true);expect(screen.queryByText(/out of premium AI/i)).toBeNull();});+ it.each([+ ["Cursor ACP", { provider: "acp", acpAgent: { id: "cursor" } }],+ [+ "own-account Claude ACP",+ {+ provider: "acp",+ acpAgent: { id: "claude-acp", useScreenpipeCloud: false },+ },+ ],+ ["a custom provider", { provider: "custom" }],+ ] as const)("stays hidden for %s", (_label, activePreset) => {+ mocks.gateState = true;+ mocks.blockedUpgrade = {+ requiredPlan: "business_ultra",+ upgradeUrl:+ "https://screenpipe.com/account/billing?target_plan=pro_ultra&interval=month",+ resetsAt: null,+ };++ renderBanner(activePreset as AIPreset);++ expect(mocks.usageQueryEnabled).toBe(false);+ expect(screen.queryByRole("alert")).toBeNull();+ expect(screen.queryByRole("button", { name: /upgrade/i })).toBeNull();+ });++ it("shows for an ACP agent explicitly routed through Screenpipe Cloud", () => {+ mocks.gateState = true;++ renderBanner({+ provider: "acp",+ acpAgent: { id: "claude-acp", useScreenpipeCloud: true },+ } as AIPreset);++ expect(mocks.usageQueryEnabled).toBe(true);+ expect(screen.getByRole("button", { name: "View Business" })).toBeTruthy();+ });+it.each(["business_max", "business_ultra"])("never shows the proactive Business prompt to %s",(tier) => {@@ -106,7 +156,7 @@ describe("UpgradeQuotaBanner", () => {upgrade_eligible: true,};mocks.gateState = true;- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.queryByText(/out of premium AI/i)).toBeNull();expect(screen.queryByRole("button", { name: "View Business" })).toBeNull();},@@ -114,7 +164,7 @@ describe("UpgradeQuotaBanner", () => {it("renders for exhausted Basic/Lifetime eligibility and opens the native Business offer", async () => {mocks.gateState = true;- render(<UpgradeQuotaBanner />);+ renderBanner();const upgrade = screen.getByRole("button", { name: "View Business" });expectNeutralPrimary(upgrade);@@ -156,7 +206,7 @@ describe("UpgradeQuotaBanner", () => {};mocks.gateState = false;- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.getByTestId("hosted-ai-allowance-banner")).toBeTruthy();expect(screen.getByText("Weekly AI limit reached")).toBeTruthy();@@ -207,14 +257,14 @@ describe("UpgradeQuotaBanner", () => {},};- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.getByText("Frontier model limit reached")).toBeTruthy();expect(screen.queryByText("Weekly AI limit reached")).toBeNull();expect(screen.getByText(/Switch to Auto or upgrade/i)).toBeTruthy();});- it("does not promise an upgrade when the server offers no next plan", () => {+ it("opens plan options without inventing a next-plan upgrade", async () => {mocks.usageState = {...mocks.usageState,tier: "business_ultra",@@ -238,11 +288,17 @@ describe("UpgradeQuotaBanner", () => {},};- render(<UpgradeQuotaBanner />);+ renderBanner();- expect(screen.getByText(/Switch to Auto\./i)).toBeTruthy();+ expect(screen.getByText(/Switch to Auto or view plans\./i)).toBeTruthy();expect(screen.queryByText(/Switch to Auto or upgrade/i)).toBeNull();expect(screen.queryByRole("button", { name: /upgrade/i })).toBeNull();+ fireEvent.click(screen.getByRole("button", { name: "View plans" }));+ await waitFor(() =>+ expect(mocks.openBusinessUpgradeSurface).toHaveBeenCalledWith(+ "cloudflare-ai-allowance-banner",+ ),+ );});it.each([@@ -310,7 +366,7 @@ describe("UpgradeQuotaBanner", () => {};mocks.gateState = false;- const polled = render(<UpgradeQuotaBanner />);+ const polled = renderBanner();expect(mocks.seenEligibility).toBe(true);expect(screen.getByTestId("hosted-ai-allowance-banner")).toBeTruthy();@@ -332,7 +388,7 @@ describe("UpgradeQuotaBanner", () => {resetsAt: null,};- render(<UpgradeQuotaBanner />);+ renderBanner();const immediateUpgrade = screen.getByRole("button", {name: `Upgrade to ${planLabel}`,});@@ -360,7 +416,7 @@ describe("UpgradeQuotaBanner", () => {resetsAt: "2026-08-02T00:00:00.000Z",};- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.getByTestId("cost-limit-upgrade-banner")).toBeTruthy();expect(screen.getByText(/AI usage limit reached/i)).toBeTruthy();expect(@@ -398,7 +454,7 @@ describe("UpgradeQuotaBanner", () => {},};- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.getByTestId("hosted-ai-cost-limit-banner")).toBeTruthy();// The blocking dialog is gone — the banner carries the recovery action.@@ -420,7 +476,7 @@ describe("UpgradeQuotaBanner", () => {resetsAt: null,};- render(<UpgradeQuotaBanner />);+ renderBanner();fireEvent.click(screen.getByRole("button", { name: "Upgrade to Basic" }));await waitFor(() =>@@ -450,7 +506,7 @@ describe("UpgradeQuotaBanner", () => {resetsAt: null,};- render(<UpgradeQuotaBanner />);+ renderBanner();fireEvent.click(screen.getByRole("button", { name: `Upgrade to ${planLabel}` }),);@@ -471,7 +527,7 @@ describe("UpgradeQuotaBanner", () => {resetsAt: null,};- render(<UpgradeQuotaBanner />);+ renderBanner();expect(screen.queryByText(/business_titan/i)).toBeNull();expect(screen.getByText(/upgrade to a higher plan/i)).toBeInTheDocument();@@ -490,7 +546,7 @@ describe("UpgradeQuotaBanner", () => {upgradeUrl: "https://screenpi.pe/account/billing",resetsAt: null,};- render(<UpgradeQuotaBanner />);+ renderBanner();fireEvent.click(screen.getByRole("button", { name: "dismiss AI usage notice" }),diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.tsxindex d23d95606..8dd22278c 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/upgrade-quota-banner.tsx@@ -11,14 +11,15 @@ import {formatAllowanceReset,formatResetTime,formatUsagePercent,- useUsageStatus,+ useUsageStatusQuery,} from "@/lib/hooks/use-usage-status";import { useModelUpsellGating } from "@/lib/hooks/use-model-upsell-gating";import { clearQuotaUpgrade, useQuotaUpgrade } from "@/lib/chat/quota-upgrade";+import { presetUsesHostedAllowance } from "@/lib/chat/model-allowance-cost";import { openExternalUrl } from "@/lib/open-external-url";import { openBusinessUpgradeSurface } from "@/lib/upgrade-flow";import { quotaPlanLabel } from "@/lib/chat/quota-errors";-+import type { AIPreset } from "@/lib/utils/tauri";/*** At-the-cap upgrade prompt (the "intensity" lever). Appears in the composer@@ -33,8 +34,13 @@ import { quotaPlanLabel } from "@/lib/chat/quota-errors";* To reproduce the exhausted state on demand without burning real quota, see* the dev force-flag in use-usage-status.tsx.*/-export function UpgradeQuotaBanner() {- const usage = useUsageStatus();+export function UpgradeQuotaBanner({+ activePreset,+}: {+ activePreset: AIPreset | null | undefined;+}) {+ const usesHostedAllowance = presetUsesHostedAllowance(activePreset);+ const usage = useUsageStatusQuery(usesHostedAllowance).usage;const upsellEnabled = useModelUpsellGating(usage?.upgrade_eligible);const blockedUpgrade = useQuotaUpgrade();const [dismissed, setDismissed] = useState(false);@@ -56,6 +62,10 @@ export function UpgradeQuotaBanner() {: null;const serverBlocked = cloudflareBlocked || legacyCostBlocked;+ // Account allowance state is irrelevant when the current preset bypasses+ // Screenpipe Cloud. That includes Cursor and other own-account ACP routes.+ if (!usesHostedAllowance) return null;+if (!blockedUpgrade) {if (dismissed) return null;// A live provider-cost allowance notice is product status, not an upsell.@@ -95,8 +105,6 @@ export function UpgradeQuotaBanner() {? "hosted-ai-cost-limit-banner": "ai-quota-banner";const activeUpgrade = blockedUpgrade ?? polledUpgrade;- const showUpgradeAction =- activeUpgrade !== null || (!blockedUpgrade && !serverBlocked);const onUpgrade = async () => {if (busy) return;@@ -163,7 +171,9 @@ export function UpgradeQuotaBanner() {{formatUsagePercent(cloudflareAllowance.used_percent)} used{weeklyAllowance ? " this week." : "."}{resets ? ` Resets ${resets}.` : " Usage falls as the window moves."}{" "}- {activeUpgrade ? "Switch to Auto or upgrade." : "Switch to Auto."}+ {activeUpgrade+ ? "Switch to Auto or upgrade."+ : "Switch to Auto or view plans."}</>) : legacyCostBlocked ? (activeUpgrade ? (@@ -186,25 +196,25 @@ export function UpgradeQuotaBanner() {</div></div><span className="flex shrink-0 items-center gap-1.5">- {showUpgradeAction && (- <Button- type="button"- size="sm"- variant="default"- className="h-7 border-foreground bg-foreground text-[12px] text-background hover:bg-background hover:text-foreground"- onClick={onUpgrade}- disabled={busy}- >- {/* Name where the click actually goes. With no server upgrade- this opens the Business offer, so it says so; only an- upgrade to a plan this build cannot name is generic. */}- {requiredPlanLabel- ? `Upgrade to ${requiredPlanLabel}`- : activeUpgrade- ? "See plans"+ <Button+ type="button"+ size="sm"+ variant="default"+ className="h-7 border-foreground bg-foreground text-[12px] text-background hover:bg-background hover:text-foreground"+ onClick={onUpgrade}+ disabled={busy}+ >+ {/* Name where the click actually goes. A server-provided target+ stays exact; a terminal or older response opens Account+ without inventing a higher plan. */}+ {requiredPlanLabel+ ? `Upgrade to ${requiredPlanLabel}`+ : activeUpgrade+ ? "See plans"+ : serverBlocked+ ? "View plans": "View Business"}- </Button>- )}+ </Button><buttontype="button"onClick={() => {diff --git a/docs/pr-assets/ai-limit-preset-scope/hosted-vs-cursor.png b/docs/pr-assets/ai-limit-preset-scope/hosted-vs-cursor.pngnew file mode 100644index 000000000..795002f65Binary files /dev/null and b/docs/pr-assets/ai-limit-preset-scope/hosted-vs-cursor.png differ