YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(onboarding): dedupe login completion analytics (#5664)
Ezra Ellette6b8f11c0c1ed
diff --git a/apps/screenpipe-app-tauri/app/onboarding/page.test.tsx b/apps/screenpipe-app-tauri/app/onboarding/page.test.tsxindex d112d0c90..bc3f18530 100644--- a/apps/screenpipe-app-tauri/app/onboarding/page.test.tsx+++ b/apps/screenpipe-app-tauri/app/onboarding/page.test.tsx@@ -58,7 +58,12 @@ vi.mock("@/lib/hooks/use-settings", () => ({}),}));vi.mock("@/components/onboarding/login-gate", () => ({- default: () => <div>regular sign in</div>,+ default: ({ handleNextSlide }: { handleNextSlide: () => void }) => (+ <div>+ regular sign in+ <button onClick={handleNextSlide}>complete regular sign in</button>+ </div>+ ),}));vi.mock("@/components/enterprise-license-prompt", () => ({EnterpriseLicensePrompt: ({ onSignIn }: { onSignIn?: () => void }) => (@@ -161,6 +166,29 @@ describe("enterprise onboarding authentication", () => {});});+ it("leaves login completion analytics to the login gate", async () => {+ mocks.enterprisePolicy.isManagedDeployment = false;+ render(<OnboardingPage />);++ fireEvent.click(+ screen.getByRole("button", { name: /complete regular sign in/i }),+ );++ await waitFor(() =>+ expect(mocks.setOnboardingStep).toHaveBeenCalledWith("permissions"),+ );+ expect(+ mocks.capture.mock.calls.filter(+ ([event]) => event === "onboarding_login_completed",+ ),+ ).toHaveLength(0);+ expect(+ mocks.capture.mock.calls.filter(+ ([event]) => event === "onboarding_step_reached",+ ),+ ).toHaveLength(1);+ });+it("does not start the standard funnel for managed onboarding", () => {render(<OnboardingPage />);expect(diff --git a/apps/screenpipe-app-tauri/app/onboarding/page.tsx b/apps/screenpipe-app-tauri/app/onboarding/page.tsxindex 75f68615d..d7ea9da4b 100644--- a/apps/screenpipe-app-tauri/app/onboarding/page.tsx+++ b/apps/screenpipe-app-tauri/app/onboarding/page.tsx@@ -275,7 +275,12 @@ export default function OnboardingPage() {transitioningRef.current = true;setIsTransitioning(true);- posthog.capture(`onboarding_${currentSlide}_completed`);+ // The login gate owns this event because only it can distinguish a fresh+ // logged-out -> logged-in transition from resuming a persisted session.+ // Capturing it here as well duplicates every fresh-login completion.+ if (currentSlide !== "login") {+ posthog.capture(`onboarding_${currentSlide}_completed`);+ }const currentIdx = SLIDE_ORDER.indexOf(currentSlide);posthog.capture("onboarding_step_reached", {step_name: `${currentSlide}_completed`,