YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(app): route activity notifications to activities (#6496)
Ezra Ellette6d00066684f9
diff --git a/apps/screenpipe-app-tauri/src-tauri/src/commands/native_actions.rs b/apps/screenpipe-app-tauri/src-tauri/src/commands/native_actions.rsindex 4e050e0b2..f9a4e13b6 100644--- a/apps/screenpipe-app-tauri/src-tauri/src/commands/native_actions.rs+++ b/apps/screenpipe-app-tauri/src-tauri/src/commands/native_actions.rs@@ -579,13 +579,7 @@ pub(crate) fn dispatch_notification_action(json: String) {let app_clone = app.clone();std::thread::spawn(move || {if is_in_app {- let target = if is_meeting_deeplink(&url) {- ShowRewindWindow::Home {- page: Some(meeting_page_with_id(&url)),- }- } else {- ShowRewindWindow::Main- };+ let target = notification_deeplink_target(&url);let app_for_show = app_clone.clone();let _ = app_clone.run_on_main_thread(move || {if let Err(e) = target.show(&app_for_show) {@@ -697,15 +691,9 @@ pub(crate) fn dispatch_notification_action(json: String) {let app_clone = app.clone();std::thread::spawn(move || {if is_in_app {- let target = if is_meeting_deeplink(&url) {- ShowRewindWindow::Home {- page: Some(meeting_page_with_id(&url)),- }- } else {- ShowRewindWindow::Main- };- // Show the target surface first. Meeting links should not flash- // Main/timeline before routing into Home -> Meeting notes.+ let target = notification_deeplink_target(&url);+ // Show the target surface first. Meeting and Activity links+ // must not flash or leave the user on Main/timeline.let app_for_show = app_clone.clone();let _ = app_clone.run_on_main_thread(move || {if let Err(e) = target.show(&app_for_show) {@@ -821,6 +809,24 @@ fn is_meeting_deeplink(url: &str) -> bool {url.starts_with("screenpipe://meeting/") || url.starts_with("screenpipe://meeting?")}+fn is_activity_deeplink(url: &str) -> bool {+ url == "screenpipe://activity" || url.starts_with("screenpipe://activity?")+}++fn notification_deeplink_target(url: &str) -> ShowRewindWindow {+ if is_meeting_deeplink(url) {+ ShowRewindWindow::Home {+ page: Some(meeting_page_with_id(url)),+ }+ } else if is_activity_deeplink(url) {+ ShowRewindWindow::Home {+ page: Some("activity".to_string()),+ }+ } else {+ ShowRewindWindow::Main+ }+}+fn native_overlay_meeting_note_id(action: &str) -> Option<u64> {action.strip_prefix("open_meeting_note:")?.parse().ok()}@@ -1154,8 +1160,8 @@ fn native_shortcut_action_callback_inner(action_ptr: *const std::os::raw::c_charmod tests {use super::{native_overlay_meeting_note_id, notification_copy_value, notification_source_url,- parse_meeting_deeplink, parse_overlay_anchor, resolve_timeline_event_target,- SHORTCUT_OVERLAY_ANCHORS,+ notification_deeplink_target, parse_meeting_deeplink, parse_overlay_anchor,+ resolve_timeline_event_target, SHORTCUT_OVERLAY_ANCHORS,};use serde_json::json;@@ -1245,6 +1251,20 @@ mod tests {assert_eq!(parse_meeting_deeplink("screenpipe://settings"), None);}+ #[test]+ fn activity_notification_deeplink_only_targets_activity_home() {+ assert!(matches!(+ notification_deeplink_target("screenpipe://activity"),+ crate::window::ShowRewindWindow::Home { page: Some(page) }+ if page == "activity"+ ));+ assert!(matches!(+ notification_deeplink_target("screenpipe://activity?range=today"),+ crate::window::ShowRewindWindow::Home { page: Some(page) }+ if page == "activity"+ ));+ }+#[test]fn notification_copy_action_uses_value_field() {let action = json!({