YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(e2e): stop the onboarding poll from racing its own success condition (#6071)
Louis Beaumont79e91eecca54
diff --git a/apps/screenpipe-app-tauri/e2e/specs/onboarding-background-ai-tools.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/onboarding-background-ai-tools.spec.tsindex c422d38e9..5664ab9e7 100644--- a/apps/screenpipe-app-tauri/e2e/specs/onboarding-background-ai-tools.spec.ts+++ b/apps/screenpipe-app-tauri/e2e/specs/onboarding-background-ai-tools.spec.ts@@ -268,26 +268,48 @@ async function callActivitySummaryThroughMcp(// removed slide — it resumes at the engine and finishes. Sample the body// while the window is alive so we can prove the removed slides never// rendered, and stop as soon as the store says setup completed.+ //+ // Which window each half runs in is load-bearing. `invoke` executes in+ // whichever window is currently switched to, and the engine slide closes+ // Onboarding the moment it finishes setup. Polling the store from the+ // onboarding handle therefore races its own success condition: completion+ // destroys the context the completion check runs in, and the driver fails+ // the whole `waitUntil` with "No window could be found" instead of+ // reporting `isCompleted: true`. So the store is read from Home, which is+ // opened above and outlives Onboarding, and only the body sample runs+ // against Onboarding while that handle still exists.const seen: string[] = [];await browser.waitUntil(async () => {+ // Driver-level, so it stays valid even with no live current window.+ const handles = await browser.getWindowHandles();+ if (!handles.includes("home")) {+ throw new Error(+ "home window disappeared; it is the surviving context this poll reads the onboarding store from",+ );+ }++ if (handles.includes("onboarding")) {+ try {+ await browser.switchToWindow("onboarding");+ seen.push(+ (+ (await browser.execute(+ () => document.body?.innerText || "",+ )) as string+ ).toLowerCase(),+ );+ } catch {+ // Window closed underneath the sample. Expected once setup+ // completes; the status check below settles it.+ }+ }++ await browser.switchToWindow("home");const status = await invokeOrThrow<{ isCompleted: boolean }>("get_onboarding_status",);- if (status.isCompleted) return true;- try {- seen.push(- (- (await browser.execute(- () => document.body?.innerText || "",- )) as string- ).toLowerCase(),- );- } catch {- // window closed underneath the sample; the status check above is- // authoritative and will settle this on the next pass- }- return false;+ return status.isCompleted;},{timeout: t(30_000),