YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
test: wait for owned browser listener
Louis Beaumont7a33cc4a3f8d
diff --git a/apps/screenpipe-app-tauri/components/browser-sidebar.tsx b/apps/screenpipe-app-tauri/components/browser-sidebar.tsxindex fce49d007..69fb3b35b 100644--- a/apps/screenpipe-app-tauri/components/browser-sidebar.tsx+++ b/apps/screenpipe-app-tauri/components/browser-sidebar.tsx@@ -393,7 +393,24 @@ export function BrowserSidebar({}},);+ unlistenPromise.then(() => {+ if (typeof window !== "undefined") {+ (window as any).__e2eOwnedBrowserNavigateReady = {+ conversationId,+ agentSessionId,+ };+ }+ }).catch(() => {});return () => {+ if (typeof window !== "undefined") {+ const ready = (window as any).__e2eOwnedBrowserNavigateReady;+ if (+ ready?.conversationId === conversationId &&+ ready?.agentSessionId === agentSessionId+ ) {+ (window as any).__e2eOwnedBrowserNavigateReady = null;+ }+ }unlistenPromise.then((fn) => fn()).catch(() => {});};}, [persistState, conversationId, agentSessionId]);diff --git a/apps/screenpipe-app-tauri/e2e/specs/zz-owned-browser-background-nav.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/zz-owned-browser-background-nav.spec.tsindex 0eed6e0ad..f8d940ad3 100644--- a/apps/screenpipe-app-tauri/e2e/specs/zz-owned-browser-background-nav.spec.ts+++ b/apps/screenpipe-app-tauri/e2e/specs/zz-owned-browser-background-nav.spec.ts@@ -259,17 +259,18 @@ async function waitForActiveConversation(id: string): Promise<void> {);}-async function waitForForegroundReady(id: string): Promise<void> {+async function waitForOwnedBrowserNavigateReady(id: string): Promise<void> {await browser.waitUntil(async () =>(await browser.execute(- (cid: string) => (window as any).__e2eForegroundReady === cid,+ (cid: string) =>+ (window as any).__e2eOwnedBrowserNavigateReady?.conversationId === cid,id,)) as boolean,{timeout: t(15_000),interval: 150,- timeoutMsg: `home foreground bus never registered conversation ${id}`,+ timeoutMsg: `home browser sidebar never registered conversation ${id}`,},);}@@ -351,7 +352,7 @@ describe("Owned browser — per-chat navigation ownership", function () {writeSeedChatFile(OWN_CHAT, "(e2e) owned-browser ownership probe");await loadChatIntoHome(OWN_CHAT);await waitForActiveConversation(OWN_CHAT);- await waitForForegroundReady(OWN_CHAT);+ await waitForOwnedBrowserNavigateReady(OWN_CHAT);// 2. Drive owned-browser commands from a SECOND window: a regression// attaches the native child to `home`, destroying home's WebDriver@@ -411,7 +412,7 @@ describe("Owned browser — per-chat navigation ownership", function () {writeSeedChatFile(OWN_CHAT, "(e2e) owned-browser reveal probe");await loadChatIntoHome(OWN_CHAT);await waitForActiveConversation(OWN_CHAT);- await waitForForegroundReady(OWN_CHAT);+ await waitForOwnedBrowserNavigateReady(OWN_CHAT);await showWindow({ Search: { query: null } });await waitForWindowHandle("search", t(10_000));@@ -496,7 +497,7 @@ describe("Owned browser — fast chat switching keeps pipe state out of other chawait loadChatIntoHome(BROWSER_CHAT_A);await waitForActiveConversation(BROWSER_CHAT_A);- await waitForForegroundReady(BROWSER_CHAT_A);+ await waitForOwnedBrowserNavigateReady(BROWSER_CHAT_A);await browser.pause(t(800));await invokeOrThrow("owned_browser_hide");expect(await invokeOrThrow<boolean>("e2e_owned_browser_visible")).toBe(@@ -507,7 +508,7 @@ describe("Owned browser — fast chat switching keeps pipe state out of other chawait loadChatIntoHome(PLAIN_CHAT);await waitForActiveConversation(PLAIN_CHAT);- await waitForForegroundReady(PLAIN_CHAT);+ await waitForOwnedBrowserNavigateReady(PLAIN_CHAT);const navigateStatus = await postNavigateAs(port,key,@@ -522,10 +523,10 @@ describe("Owned browser — fast chat switching keeps pipe state out of other chawait loadChatIntoHome(BROWSER_CHAT_B);await waitForActiveConversation(BROWSER_CHAT_B);- await waitForForegroundReady(BROWSER_CHAT_B);+ await waitForOwnedBrowserNavigateReady(BROWSER_CHAT_B);await loadChatIntoHome(PLAIN_CHAT);await waitForActiveConversation(PLAIN_CHAT);- await waitForForegroundReady(PLAIN_CHAT);+ await waitForOwnedBrowserNavigateReady(PLAIN_CHAT);await postEvalWithUrlAs(port, key, FOREIGN_URL, FOREIGN_OWNER);await browser.pause(t(1_200));expect(await invokeOrThrow<boolean>("e2e_owned_browser_visible")).toBe(@@ -533,10 +534,10 @@ describe("Owned browser — fast chat switching keeps pipe state out of other ch);await loadChatIntoHome(BROWSER_CHAT_A);await waitForActiveConversation(BROWSER_CHAT_A);- await waitForForegroundReady(BROWSER_CHAT_A);+ await waitForOwnedBrowserNavigateReady(BROWSER_CHAT_A);await loadChatIntoHome(BROWSER_CHAT_B);await waitForActiveConversation(BROWSER_CHAT_B);- await waitForForegroundReady(BROWSER_CHAT_B);+ await waitForOwnedBrowserNavigateReady(BROWSER_CHAT_B);await browser.pause(t(1_000));const chatA = loadChatFile(BROWSER_CHAT_A);diff --git a/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx b/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsxindex 15b33d523..5b0a4a153 100644--- a/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx+++ b/apps/screenpipe-app-tauri/lib/hooks/use-settings.tsx@@ -1351,6 +1351,7 @@ export const SettingsProvider: React.FC<{ children: React.ReactNode }> = ({ chil// signs out while this fetch is in flight, the generation changes and we// abort the write below instead of resurrecting the cleared session.const generation = authGenerationRef.current;+ const startingToken = settingsRef.current.user?.token ?? null;try {const response = await fetch(screenpipeWebUrl("/api/user", "https://screenpi.pe"), {method: "POST",@@ -1374,7 +1375,10 @@ export const SettingsProvider: React.FC<{ children: React.ReactNode }> = ({ chil// The user signed out while this request was in flight — writing// userData now would resurrect the cleared session (the "logout needs// two clicks" bug). Abort silently; the sign-out already won.- if (authGenerationRef.current !== generation) {+ if (+ authGenerationRef.current !== generation ||+ (startingToken !== null && settingsRef.current.user?.token !== token)+ ) {console.log("loadUser: sign-out during fetch — not restoring session");return;}