YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
remove redundant Live View confirmation
Louis Beaumont869014f9236f
diff --git a/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx b/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsxindex 2c1e63790..89c4f691b 100644--- a/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx+++ b/apps/screenpipe-app-tauri/components/settings/__tests__/brain-overview.test.tsx@@ -1441,8 +1441,16 @@ describe("BrainOverview", () => {const agentPrompt = mocks.showChatWithPrefill.mock.calls[0][0].prompt;expect(agentPrompt).toContain("screenpipe-cli skill");expect(agentPrompt).toContain("screenpipe_live_view tool");- expect(agentPrompt).toContain("Ask for explicit confirmation");- expect(agentPrompt).toContain("Use ask_user when it is available");+ expect(agentPrompt).toContain(+ "Do not ask the user to approve those requested actions again",+ );+ expect(agentPrompt).toContain(+ "do not replace the whole dashboard, show a preview, or ask whether to replace it",+ );+ expect(agentPrompt).toContain(+ "Ask one short question only when essential ambiguity remains",+ );+ expect(agentPrompt).not.toContain("replacing Live View Blocks");expect(mocks.generateLiveViewWithPi).not.toHaveBeenCalled();expect(mocks.capture).toHaveBeenCalledWith("live_view_pipe_agent_handoff",diff --git a/apps/screenpipe-app-tauri/components/settings/brain-overview.tsx b/apps/screenpipe-app-tauri/components/settings/brain-overview.tsxindex 02b0e317a..d96da6e07 100644--- a/apps/screenpipe-app-tauri/components/settings/brain-overview.tsx+++ b/apps/screenpipe-app-tauri/components/settings/brain-overview.tsx@@ -1405,11 +1405,12 @@ ${prompt}Use the screenpipe-cli skill for Pipe creation or editing and the screenpipe_live_view tool for Live View work.- Read the screenpipe-cli skill before changing a Pipe.- Load the current Live View lazily by id. Do not ask the app to inject its contents into chat context.+- Treat this submitted request as explicit authorization to make the requested Pipe and Live View changes. Do not ask the user to approve those requested actions again.- It is okay to create a new disabled/manual Pipe draft and run it once for testing.-- Ask for explicit confirmation before overwriting or deleting an existing Pipe, enabling or scheduling automatic runs, installing anything, or replacing Live View Blocks.-- Use ask_user when it is available; otherwise ask one short question in chat and wait.- Test a changed Pipe with pipe run before binding it to the Live View.-- Preserve unchanged Live View Blocks and bind only the relevant Blocks after the Pipe works.+- After the Pipe works, save the smallest relevant Live View Block additions or edits directly. Preserve every unrelated Block; do not replace the whole dashboard, show a preview, or ask whether to replace it.+- Ask one short question only when essential ambiguity remains or an action goes beyond the request: deleting a Pipe, overwriting a name collision when the user asked for a new Pipe, installing external code or a connection, or enabling a schedule the user did not request.+- Use ask_user for that exceptional question when it is available; otherwise ask in chat and wait.- Do not publish anything to the Pipe Store.`;try {diff --git a/apps/screenpipe-app-tauri/src-tauri/assets/extensions/__tests__/live-views.test.ts b/apps/screenpipe-app-tauri/src-tauri/assets/extensions/__tests__/live-views.test.tsindex b85df4ffd..e7df64f3e 100644--- a/apps/screenpipe-app-tauri/src-tauri/assets/extensions/__tests__/live-views.test.ts+++ b/apps/screenpipe-app-tauri/src-tauri/assets/extensions/__tests__/live-views.test.ts@@ -7,6 +7,7 @@ import registerLiveViews from "../live-views";type ToolDef = {name: string;+ promptGuidelines?: string[];execute: (toolCallId: string,params: Record<string, unknown>,@@ -43,6 +44,13 @@ afterEach(() => {});describe("screenpipe_live_view", () => {+ it("does not reconfirm targeted edits the user already requested", () => {+ const guidance = getTool().promptGuidelines?.join(" ") ?? "";++ expect(guidance).toContain("without a second confirmation");+ expect(guidance).toContain("unrequested broad removals");+ });+it("lists compact summaries without leaking hydrated Block values", async () => {globalThis.fetch = vi.fn(async () =>response([diff --git a/apps/screenpipe-app-tauri/src-tauri/assets/extensions/live-views.ts b/apps/screenpipe-app-tauri/src-tauri/assets/extensions/live-views.tsindex d2d86a618..db418c2b9 100644--- a/apps/screenpipe-app-tauri/src-tauri/assets/extensions/live-views.ts+++ b/apps/screenpipe-app-tauri/src-tauri/assets/extensions/live-views.ts@@ -113,7 +113,7 @@ export default function (pi: ExtensionAPI) {"Use action=list when the user did not identify a Live View, then action=get for the selected id.","Before action=save, get the latest definition and preserve every Block the user did not ask to change.","Pass the full edited object from get back to save; its revision prevents overwriting a newer edit.",- "Only save when the user explicitly asked to create or change a Live View. Ask before broad removals or replacement.",+ "Only save when the user explicitly asked to create or change a Live View. Apply requested targeted additions or edits without a second confirmation; ask only before unrequested broad removals or whole-dashboard replacement.",],executionMode: "sequential",parameters,