YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(meetings): open summary after stopping (#6694)
Louis Beaumont8700e03008a9
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsxindex 8def61ddf..01efe96b3 100644--- a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx+++ b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx@@ -13,6 +13,7 @@ import {MeetingSummarySurface,MeetingWorkspaceTabs,preferredMeetingWorkspaceTab,+ stopMeetingAndOpenSummary,} from "./meeting-workspace";describe("preferred meeting workspace tab", () => {@@ -31,6 +32,33 @@ describe("preferred meeting workspace tab", () => {});});+describe("meeting stop destination", () => {+ it("opens summary only after the meeting stops successfully", async () => {+ const onStop = vi.fn(async () => undefined);+ const onValueChange = vi.fn();++ await stopMeetingAndOpenSummary(onStop, onValueChange);++ expect(onStop).toHaveBeenCalledOnce();+ expect(onValueChange).toHaveBeenCalledWith("summary");+ expect(onStop.mock.invocationCallOrder[0]).toBeLessThan(+ onValueChange.mock.invocationCallOrder[0],+ );+ });++ it("keeps the current tab when stopping fails", async () => {+ const onStop = vi.fn(async () => {+ throw new Error("stop failed");+ });+ const onValueChange = vi.fn();++ await expect(+ stopMeetingAndOpenSummary(onStop, onValueChange),+ ).rejects.toThrow("stop failed");+ expect(onValueChange).not.toHaveBeenCalled();+ });+});+describe("meeting shell width contract", () => {// The header (title, chips, tabs) used to sit in max-w-5xl while the note// text sat in max-w-3xl > max-w-[68ch], so the title floated ~190px left ofdiff --git a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsxindex faddf7aea..f1f6bcd6d 100644--- a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx+++ b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx@@ -174,6 +174,14 @@ export function preferredMeetingWorkspaceTab(return extractMeetingSummary(note ?? "") ? "summary" : "notes";}+export async function stopMeetingAndOpenSummary(+ onStop: () => void | Promise<void>,+ onValueChange: (value: MeetingWorkspaceTab) => void,+): Promise<void> {+ await onStop();+ onValueChange("summary");+}+export interface MeetingSummaryRecovery {title: string;detail: string;diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsxindex a59bf3fee..850291172 100644--- a/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx+++ b/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx@@ -180,6 +180,7 @@ import {MEETING_SHELL_CLASS,MeetingSummarySurface,MeetingWorkspaceTabs,+ stopMeetingAndOpenSummary,type MeetingWorkspaceTab,} from "./meeting-workspace";import { meetingRetranscribeSuccessCopy } from "./transcript-recovery-copy";@@ -1270,7 +1271,7 @@ export function NoteView({});}}- await onStop();+ await stopMeetingAndOpenSummary(onStop, setActiveTab);} catch (err) {console.error("failed to stop meeting", err);toast({diff --git a/apps/screenpipe-app-tauri/e2e/COVERAGE.md b/apps/screenpipe-app-tauri/e2e/COVERAGE.mdindex 565410480..1abb9ba46 100644--- a/apps/screenpipe-app-tauri/e2e/COVERAGE.md+++ b/apps/screenpipe-app-tauri/e2e/COVERAGE.md@@ -180,7 +180,7 @@ pass/fail/skip counts.| meeting-replay-player.spec.ts | windows, macos, linux | real-ui-e2e, local-api | meeting-notes, meeting-replay | high | strong | real-user-flow | 1 | Seeds four stored frames, wraps their exact timestamps in an ended meeting, reopens it from the previous-meetings list, and verifies deduped silent playback, pause stability, and a review screenshot. || meeting-restart-live-transcription.spec.ts | windows, macos, linux | real-ui-e2e, local-api | meeting-notes | high | strong | command | 1 | Opens an auto-detected meeting, runs the full stop_screenpipe/spawn_screenpipe restart the health overlay's RESTART button uses, and asserts the meeting is still open afterwards so live transcription has something to reattach to. || meeting-summary-recovery.spec.ts | windows, macos, linux | real-ui-e2e, local-api | meeting-notes, meeting-summary-recovery | high | strong | real-user-flow | 1 | Runs an ended meeting through real Stop -> Resume -> Stop transitions in the isolated desktop, holds both mutations to prove their pending receipts, reconciles a delayed stale started event, and captures saved-finalizing, transcript, resumed-live, the anchored Notes receipt, the Summary draft surface, ready, and failed states without launching hosted AI. |-| meeting-workspace-tabs.spec.ts | windows, macos, linux | real-ui-e2e, local-api | meeting-notes | high | strong | real-user-flow | 1 | Seeds a completed meeting with notes and summary, proves it reopens on the saved summary rather than the raw transcript, switches persistent tabs, resizes to 640x560, checks footer separation and horizontal overflow, then captures a review screenshot. |+| meeting-workspace-tabs.spec.ts | windows, macos, linux | real-ui-e2e, local-api | meeting-notes | high | strong | real-user-flow | 1 | Seeds a live meeting with notes and summary, proves the saved summary is the preferred outcome view, switches persistent tabs, resizes to 640x560, checks footer separation and horizontal overflow, captures a review screenshot, then stops from the transcript and verifies the Summary tab opens. || meetings-only-audio-lifecycle.spec.ts | windows, macos | audio-device, local-api, real-ui-e2e | meetings-only-audio-lifecycle, audio-device-health | high | conditional | real-user-flow | 1 | Opt-in real-audio lifecycle lane: configured devices stay closed outside meetings and open only across a manual meeting edge. || notification-viewer-link.spec.ts | windows, macos, linux | notifications, local-api, window-lifecycle | notifications, viewer-deeplink | high | partial | mixed | 3 | Notification local file links rewrite into in-app viewer links. || onboarding-background-ai-tools.spec.ts | windows, macos, linux | onboarding, real-ui-e2e, storage-privacy | onboarding, settings-ai | high | strong | real-user-flow | 2 | Isolated agent-home CI lane verifies private native config writes, the resolved local API credential, a real authenticated MCP tool call, skills setup, and removal of the connection slide. |diff --git a/apps/screenpipe-app-tauri/e2e/coverage-map.json b/apps/screenpipe-app-tauri/e2e/coverage-map.jsonindex 6cd900a6d..0fc606ccd 100644--- a/apps/screenpipe-app-tauri/e2e/coverage-map.json+++ b/apps/screenpipe-app-tauri/e2e/coverage-map.json@@ -1914,7 +1914,7 @@"criticality": "high","confidence": "strong","ux": "real-user-flow",- "notes": "Seeds a completed meeting with notes and summary, proves it reopens on the saved summary rather than the raw transcript, switches persistent tabs, resizes to 640x560, checks footer separation and horizontal overflow, then captures a review screenshot."+ "notes": "Seeds a live meeting with notes and summary, proves the saved summary is the preferred outcome view, switches persistent tabs, resizes to 640x560, checks footer separation and horizontal overflow, captures a review screenshot, then stops from the transcript and verifies the Summary tab opens."},{"spec": "meeting-chat-panel.spec.ts",diff --git a/apps/screenpipe-app-tauri/e2e/specs/meeting-workspace-tabs.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/meeting-workspace-tabs.spec.tsindex 257b92d99..faa6e6f28 100644--- a/apps/screenpipe-app-tauri/e2e/specs/meeting-workspace-tabs.spec.ts+++ b/apps/screenpipe-app-tauri/e2e/specs/meeting-workspace-tabs.spec.ts@@ -7,6 +7,7 @@** - notes, transcript, and summary are persistent keyboard-accessible tabs* - changing tabs does not unmount the note editor+ * - stopping a live meeting moves the reader to its summary* - every tab has one bounded scroll surface above the fixed control dock* - the workspace does not overflow when the window becomes narrow/short*@@ -611,5 +612,19 @@ describe("meeting workspace tabs and responsive layout", function () {timeout: t(5_000),timeoutMsg: "follow-live control did not dismiss after resuming",});++ const stopButton = await $(+ '[aria-label="stop meeting"], [aria-label="stop and summarize"]',+ );+ await stopButton.waitForClickable({ timeout: t(5_000) });+ await stopButton.click();+ await browser.waitUntil(+ async () => (await summaryTab.getAttribute("aria-selected")) === "true",+ {+ timeout: t(15_000),+ timeoutMsg: "Summary tab did not open after the meeting stopped",+ },+ );+ expect(await transcriptTab.getAttribute("aria-selected")).toBe("false");});});