YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(ai-presets): send stream:false on the connection test probe (#6218)
Louis Beaumont9a4950abb4bb
diff --git a/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.test.ts b/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.test.tsindex 400c0c2d5..60d4f3a22 100644--- a/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.test.ts+++ b/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.test.ts@@ -38,6 +38,82 @@ describe("testAiPresetConnection", () => {});});+ // Regression for #6196: omniroute and similar OpenAI-compatible gateways+ // answer with SSE unless the request opts out explicitly, and the SSE body+ // then fails response.json() with a bogus "connection failed".+ it("gets JSON from a gateway that streams unless stream:false is sent", async () => {+ const gateway = vi.fn(async (_input: string, init?: RequestInit) => {+ const body = JSON.parse(init!.body as string);+ if (body.stream !== false) {+ return new Response(+ 'data: {"choices":[{"delta":{"content":"hi"}}]}\n\ndata: [DONE]\n\n',+ { status: 200, headers: { "Content-Type": "text/event-stream" } },+ );+ }+ return new Response(+ JSON.stringify({ choices: [{ message: { content: "hi" } }] }),+ { status: 200, headers: { "Content-Type": "application/json" } },+ );+ });++ await expect(+ testAiPresetConnection(+ {+ provider: "custom",+ url: "http://127.0.0.1:20128/v1",+ model: "gpt-4o-mini",+ },+ { fetch: gateway },+ ),+ ).resolves.toMatchObject({ reply: "hi" });++ expect(JSON.parse(gateway.mock.calls[0][1]!.body as string).stream).toBe(false);+ });++ it("keeps stream:false on the max_completion_tokens retry", async () => {+ const request = vi+ .fn()+ .mockResolvedValueOnce(+ new Response(+ JSON.stringify({+ error: { message: "Unsupported parameter: use max_completion_tokens" },+ }),+ { status: 400 },+ ),+ )+ .mockResolvedValueOnce(+ new Response(+ JSON.stringify({ choices: [{ message: { content: "hi" } }] }),+ { status: 200 },+ ),+ );++ await expect(+ testAiPresetConnection(+ { provider: "custom", url: "https://gw.example.com/v1", model: "gpt-5" },+ { fetch: request },+ ),+ ).resolves.toMatchObject({ reply: "hi" });++ for (const call of request.mock.calls) {+ expect(JSON.parse(call[1]!.body as string).stream).toBe(false);+ }+ });++ it("asks Anthropic for a non-streaming reply too", async () => {+ const request = vi.fn(async () =>+ new Response(JSON.stringify({ content: [{ text: "hi" }] }), { status: 200 }));++ await expect(+ testAiPresetConnection(+ { provider: "anthropic", model: "claude-sonnet-5", apiKey: "k" },+ { fetch: request },+ ),+ ).resolves.toMatchObject({ reply: "hi" });++ expect(JSON.parse(request.mock.calls[0][1]!.body as string).stream).toBe(false);+ });+it("surfaces Google's array-shaped error message", async () => {const request = vi.fn(async () =>new Response(diff --git a/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.ts b/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.tsindex 7417a9c90..4dbc97bea 100644--- a/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.ts+++ b/apps/screenpipe-app-tauri/lib/utils/ai-preset-connection.ts@@ -76,11 +76,15 @@ export async function testAiPresetConnection(const isAnthropic = preset.provider === "anthropic";const startedAt = performance.now();+ // `stream: false` is explicit on both shapes: the reply is read with+ // response.json(), and some compatible gateways stream by default when the+ // field is omitted.let body = isAnthropic? {model: preset.model || "",messages: [{ role: "user", content: "say hi" }],max_tokens: 50,+ stream: false,}: buildChatTestBody(preset.model || "", "say hi", 50, "max_tokens");diff --git a/apps/screenpipe-app-tauri/lib/utils/chat-test-body.test.ts b/apps/screenpipe-app-tauri/lib/utils/chat-test-body.test.tsindex 97e9f161a..d242e6ef4 100644--- a/apps/screenpipe-app-tauri/lib/utils/chat-test-body.test.ts+++ b/apps/screenpipe-app-tauri/lib/utils/chat-test-body.test.ts@@ -15,6 +15,7 @@ describe("buildChatTestBody", () => {expect(body).toEqual({model: "gpt-4",messages: [{ role: "user", content: "say hi" }],+ stream: false,max_tokens: 50,});expect(body.max_completion_tokens).toBeUndefined();@@ -25,6 +26,7 @@ describe("buildChatTestBody", () => {expect(body).toEqual({model: "gpt-5",messages: [{ role: "user", content: "say hi" }],+ stream: false,max_completion_tokens: 50,});expect(body.max_tokens).toBeUndefined();@@ -36,6 +38,21 @@ describe("buildChatTestBody", () => {expect(a.max_tokens !== undefined && a.max_completion_tokens !== undefined).toBe(false);expect(b.max_tokens !== undefined && b.max_completion_tokens !== undefined).toBe(false);});++ // Gateways such as omniroute stream by default when `stream` is absent,+ // which breaks the response.json() the connection test performs.+ it("always requests a non-streaming reply", () => {+ for (const field of ["max_tokens", "max_completion_tokens"] as const) {+ const body = buildChatTestBody("m", "hi", 10, field);+ expect(body.stream).toBe(false);+ expect(JSON.parse(JSON.stringify(body)).stream).toBe(false);+ }+ });++ it("serializes stream:false rather than dropping it", () => {+ const wire = JSON.stringify(buildChatTestBody("m", "hi", 10));+ expect(wire).toContain('"stream":false');+ });});describe("shouldRetryWithMaxCompletionTokens", () => {diff --git a/apps/screenpipe-app-tauri/lib/utils/chat-test-body.ts b/apps/screenpipe-app-tauri/lib/utils/chat-test-body.tsindex 2520193c5..70104dfb1 100644--- a/apps/screenpipe-app-tauri/lib/utils/chat-test-body.ts+++ b/apps/screenpipe-app-tauri/lib/utils/chat-test-body.ts@@ -14,6 +14,11 @@* - We can't detect the endpoint capability statically, so we try* `max_tokens` first (broadest compatibility), and fall back to* `max_completion_tokens` if the endpoint rejects it.+ * - `stream` is always sent explicitly as `false`. The OpenAI spec says an+ * absent `stream` means non-streaming, but several compatible gateways+ * (omniroute and friends) default to SSE instead. The caller reads the+ * reply with `response.json()`, so an SSE body fails to parse and the+ * connection test reports a bogus failure.*/export type ChatTokensField = "max_tokens" | "max_completion_tokens";@@ -21,6 +26,7 @@ export type ChatTokensField = "max_tokens" | "max_completion_tokens";export interface ChatTestBody {model: string;messages: Array<{ role: string; content: string }>;+ stream: false;max_tokens?: number;max_completion_tokens?: number;}@@ -37,6 +43,7 @@ export function buildChatTestBody(const body: ChatTestBody = {model,messages: [{ role: "user", content: prompt }],+ stream: false,};if (tokensField === "max_tokens") {body.max_tokens = maxTokens;