Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix: avoid permission settings launcher panics (#5327)

Louis Beaumont9ab1b002d9a0
diff --git a/apps/screenpipe-app-tauri/src-tauri/src/permissions.rs b/apps/screenpipe-app-tauri/src-tauri/src/permissions.rs
index dd0e42bee..819062a26 100644
--- a/apps/screenpipe-app-tauri/src-tauri/src/permissions.rs
+++ b/apps/screenpipe-app-tauri/src-tauri/src/permissions.rs
@@ -20,6 +20,33 @@ pub enum OSPermission {
Calendar,
}
+#[cfg(target_os = "macos")]
+const MACOS_OPEN_COMMAND: &str = "/usr/bin/open";
+
+#[cfg(target_os = "macos")]
+fn permission_settings_url(permission: &OSPermission) -> &'static str {
+ match permission {
+ OSPermission::ScreenRecording => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_ScreenCapture"
+ }
+ OSPermission::Microphone => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_Microphone"
+ }
+ OSPermission::Accessibility => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_Accessibility"
+ }
+ OSPermission::Automation => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_Automation"
+ }
+ OSPermission::InputMonitoring => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_ListenEvent"
+ }
+ OSPermission::Calendar => {
+ "x-apple.systempreferences:com.apple.preference.security?Privacy_Calendars"
+ }
+ }
+}
+
#[tauri::command(async)]
#[specta::specta]
#[allow(unused_variables)] // permission used on macOS
@@ -28,36 +55,12 @@ pub fn open_permission_settings(permission: OSPermission) {
{
use std::process::Command;
- match permission {
- OSPermission::ScreenRecording => Command::new("open")
- .arg(
- "x-apple.systempreferences:com.apple.preference.security?Privacy_ScreenCapture",
- )
- .spawn()
- .expect("Failed to open Screen Recording settings"),
- OSPermission::Microphone => Command::new("open")
- .arg("x-apple.systempreferences:com.apple.preference.security?Privacy_Microphone")
- .spawn()
- .expect("Failed to open Microphone settings"),
- OSPermission::Accessibility => Command::new("open")
- .arg(
- "x-apple.systempreferences:com.apple.preference.security?Privacy_Accessibility",
- )
- .spawn()
- .expect("Failed to open Accessibility settings"),
- OSPermission::Automation => Command::new("open")
- .arg("x-apple.systempreferences:com.apple.preference.security?Privacy_Automation")
- .spawn()
- .expect("Failed to open Automation settings"),
- OSPermission::InputMonitoring => Command::new("open")
- .arg("x-apple.systempreferences:com.apple.preference.security?Privacy_ListenEvent")
- .spawn()
- .expect("Failed to open Input Monitoring settings"),
- OSPermission::Calendar => Command::new("open")
- .arg("x-apple.systempreferences:com.apple.preference.security?Privacy_Calendars")
- .spawn()
- .expect("Failed to open Calendar settings"),
- };
+ let settings_url = permission_settings_url(&permission);
+ if let Err(error) = Command::new(MACOS_OPEN_COMMAND).arg(settings_url).spawn() {
+ // Opening a settings pane is a recovery affordance. A missing or
+ // unavailable launcher must not crash onboarding or the app.
+ error!("failed to open macOS permission settings ({settings_url}): {error}");
+ }
}
}
@@ -1285,6 +1288,34 @@ mod screen_recording_preflight_tests {
}
}
+#[cfg(all(test, target_os = "macos"))]
+mod permission_settings_tests {
+ use super::*;
+
+ #[test]
+ fn uses_the_absolute_macos_launcher_path() {
+ assert_eq!(MACOS_OPEN_COMMAND, "/usr/bin/open");
+ }
+
+ #[test]
+ fn maps_each_permission_to_its_system_settings_pane() {
+ let cases = [
+ (OSPermission::ScreenRecording, "Privacy_ScreenCapture"),
+ (OSPermission::Microphone, "Privacy_Microphone"),
+ (OSPermission::Accessibility, "Privacy_Accessibility"),
+ (OSPermission::Automation, "Privacy_Automation"),
+ (OSPermission::InputMonitoring, "Privacy_ListenEvent"),
+ (OSPermission::Calendar, "Privacy_Calendars"),
+ ];
+
+ for (permission, expected_pane) in cases {
+ let url = permission_settings_url(&permission);
+ assert!(url.starts_with("x-apple.systempreferences:"));
+ assert!(url.ends_with(expected_pane));
+ }
+ }
+}
+
#[cfg(all(test, target_os = "macos"))]
mod mic_grant_restart_tests {
use super::*;