YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix: render images in imported Codex chats (#7545)
Louis Beaumonta8ef9734ad2e
diff --git a/apps/screenpipe-app-tauri/components/chat/standalone/message-content.image-preview.test.tsx b/apps/screenpipe-app-tauri/components/chat/standalone/message-content.image-preview.test.tsxindex 54c36ecb6..0a7924e56 100644--- a/apps/screenpipe-app-tauri/components/chat/standalone/message-content.image-preview.test.tsx+++ b/apps/screenpipe-app-tauri/components/chat/standalone/message-content.image-preview.test.tsx@@ -6,8 +6,26 @@ import { fireEvent, render, screen } from "@testing-library/react";import { describe, expect, it, vi } from "vitest";import type { Message } from "@/lib/chat/types";import { MessageContent } from "./message-content";+import { parseCodexTranscript } from "@/lib/chat/external-chat-parser";describe("MessageContent — attached image preview", () => {+ it("renders an imported Codex attachment and opens it without exposing transport markup", () => {+ const image = "data:image/png;base64,c2NyZWVucGlwZQ==";+ const conversation = parseCodexTranscript(JSON.stringify({ type: "response_item", payload: {+ type: "message", role: "user", content: [+ { type: "input_text", text: 'Explain this\n<image name=[Image #1] path="/tmp/example.png">' },+ { type: "input_image", image_url: image },+ ],+ } }), { sourceId: "preview", fallbackTimestamp: 1 })!;+ const onImageClick = vi.fn();+ const { container } = render(<MessageContent message={conversation.messages[0] as Message} onImageClick={onImageClick} />);+ expect(screen.getByRole("img", { name: "Attached 1" })).toHaveAttribute("src", image);+ expect(container.textContent).toContain("Explain this");+ expect(container.textContent).not.toContain("<image");+ fireEvent.click(screen.getByRole("button", { name: "Attached 1" }));+ expect(onImageClick).toHaveBeenCalledWith([image], 0);+ });+it("opens the image viewer without bubbling pointer events to message editing", () => {const onMessageMouseDown = vi.fn();const onMessageMouseUp = vi.fn();diff --git a/apps/screenpipe-app-tauri/lib/chat/__tests__/codex-image-import.test.ts b/apps/screenpipe-app-tauri/lib/chat/__tests__/codex-image-import.test.tsnew file mode 100644index 000000000..bd4e2f06f--- /dev/null+++ b/apps/screenpipe-app-tauri/lib/chat/__tests__/codex-image-import.test.ts@@ -0,0 +1,61 @@+// screenpipe — AI that knows everything you've seen, said, or heard+// https://screenpipe.com++import { describe, expect, it } from "vitest";+import { normalizeImportedCodexConversation, parseCodexTranscript } from "../external-chat-parser";++const image = "data:image/png;base64,aGVsbG8=";+const tag = '<image name=[Image #1] path="/tmp/My screenshot.png">';+function parse(text: string, parts: unknown[] = []) {+ return parseCodexTranscript(JSON.stringify({ type: "response_item", payload: {+ type: "message", role: "user", content: [{ type: "input_text", text }, ...parts],+ } }), { sourceId: "images", fallbackTimestamp: 1 });+}++describe("Codex imported image attachments", () => {+ it("preserves embedded images and removes their transport tags", () => {+ const conversation = parse(`Explain this\n\n${tag}\n</image>`, [+ { type: "input_image", image_url: image },+ ]);+ expect(conversation?.messages[0]).toMatchObject({ content: "Explain this", images: [image] });+ expect(conversation?.title).toBe("Explain this");+ });++ it("retains image-only messages", () => {+ const conversation = parse("", [{ type: "input_image", image_url: image }]);+ expect(conversation?.messages).toHaveLength(1);+ expect(conversation?.messages[0].images).toEqual([image]);+ });++ it("renders path-only attachments through the existing local Markdown image loader", () => {+ const conversation = parse(`Explain this\n\n${tag}`);+ expect(conversation?.messages[0].content).toBe("Explain this\n\n");+ expect(conversation?.title).toBe("Explain this");+ });++ it("preserves quoted image markup and rejects remote image sources", () => {+ const text = `Explain this syntax:\n\n\`\`\`xml\n${tag}\n\`\`\``;+ expect(parse(text)?.messages[0].content).toBe(text);+ const remoteTag = '<image name=[Image #1] path="https://example.com/tracker.png">';+ expect(parse(remoteTag, [{ type: "input_image", image_url: "https://example.com/tracker.png" }])?.messages[0].content).toBe(remoteTag);+ expect(parse("hello", [{ type: "input_image", image_url: "data:text/html;base64,aGVsbG8=" }])?.messages[0].images).toBeUndefined();+ });++ it("keeps unmatched local references when some attachments have no embedded data", () => {+ const secondTag = '<image name=[Image #2] path="C:\\Screenshots\\two.png">';+ const conversation = parse(`Compare these\n${tag}\n${secondTag}`, [{ type: "input_image", image_url: image }]);+ expect(conversation?.messages[0].images).toEqual([image]);+ expect(conversation?.messages[0].content).toContain("");+ expect(conversation?.messages[0].content).not.toContain("<image");+ });++ it("repairs cached imports on load without changing locally continued messages", () => {+ const conversation = parse("Explain this")!;+ conversation.messages[0].content = `Explain this\n\n${tag}`;+ conversation.messages.push({ ...conversation.messages[0], id: "local-turn", importedFrom: undefined });+ const repaired = normalizeImportedCodexConversation(conversation);+ expect(repaired.messages[0].content).toContain("");+ expect(repaired.messages[1].content).toContain(tag);+ expect(normalizeImportedCodexConversation(repaired)).toBe(repaired);+ });+});diff --git a/apps/screenpipe-app-tauri/lib/chat/__tests__/external-chat-parser.test.ts b/apps/screenpipe-app-tauri/lib/chat/__tests__/external-chat-parser.test.tsindex 28773169e..402dc0ac7 100644--- a/apps/screenpipe-app-tauri/lib/chat/__tests__/external-chat-parser.test.ts+++ b/apps/screenpipe-app-tauri/lib/chat/__tests__/external-chat-parser.test.ts@@ -425,7 +425,7 @@ describe("external agent chat parsers", () => {expect(conversation?.title).toBe("fix this sidebar");expect(conversation?.messages[0].content).toBe(- "fix this sidebar\n<image name=[Image #1] path=\"/tmp/screenshot.png\">",+ "fix this sidebar\n\n",);});diff --git a/apps/screenpipe-app-tauri/lib/chat/external-chat-import.test.ts b/apps/screenpipe-app-tauri/lib/chat/external-chat-import.test.tsindex 72a03dac9..58a0ad696 100644--- a/apps/screenpipe-app-tauri/lib/chat/external-chat-import.test.ts+++ b/apps/screenpipe-app-tauri/lib/chat/external-chat-import.test.ts@@ -212,6 +212,30 @@ describe("scanExternalChatHistory", () => {expect(mocks.saveConversationFile).not.toHaveBeenCalled();});+ it("repairs missing images during sync even when text and timestamps are unchanged", async () => {+ const { parseCodexTranscript } = await import("./external-chat-parser");+ const image = "data:image/png;base64,aGVsbG8=";+ const jsonl = JSON.stringify({ type: "response_item", payload: {+ type: "message", id: "u1", role: "user", content: [+ { type: "input_text", text: "Review this" },+ { type: "input_image", image_url: image },+ ],+ } });+ const existing = parseCodexTranscript(jsonl, { sourceId: "images", fallbackTimestamp: 1 })!;+ delete existing.messages[0].images;+ existing.lastViewedAt = 1;+ mocks.stat.mockResolvedValue({ size: 1024 });+ mocks.readTextFile.mockResolvedValue(jsonl);+ mocks.loadConversationFile.mockResolvedValue(existing);+ const candidate = { source: "codex" as const, path: "/fixture/images.jsonl", sourceId: "images", modifiedAt: 1, size: 1024 };++ expect(await importExternalChatHistory([candidate], { skipUnchanged: true })).toMatchObject({ updated: 1, skipped: 0 });+ const saved = mocks.saveConversationFile.mock.calls[0][0];+ expect(saved.messages[0].images).toEqual([image]);+ mocks.loadConversationFile.mockResolvedValue(saved);+ expect(await importExternalChatHistory([candidate], { skipUnchanged: true })).toMatchObject({ updated: 0, skipped: 1 });+ });+it("broadcasts active and completed Codex turn state even when disk content is unchanged", async () => {const userAt = Date.parse("2026-08-27T15:00:02Z");const toolAt = Date.parse("2026-08-27T15:00:03Z");diff --git a/apps/screenpipe-app-tauri/lib/chat/external-chat-import.ts b/apps/screenpipe-app-tauri/lib/chat/external-chat-import.tsindex c140104e2..64e6c8050 100644--- a/apps/screenpipe-app-tauri/lib/chat/external-chat-import.ts+++ b/apps/screenpipe-app-tauri/lib/chat/external-chat-import.ts@@ -175,6 +175,7 @@ function importedConversationIsUnchanged(&& message.id === candidate.id&& message.role === candidate.role&& message.content === candidate.content+ && JSON.stringify(message.images ?? []) === JSON.stringify(candidate.images ?? [])&& JSON.stringify(message.contentBlocks ?? [])=== JSON.stringify(candidate.contentBlocks ?? []);});diff --git a/apps/screenpipe-app-tauri/lib/chat/external-chat-parser.ts b/apps/screenpipe-app-tauri/lib/chat/external-chat-parser.tsindex 22a3d8704..28a6e1c98 100644--- a/apps/screenpipe-app-tauri/lib/chat/external-chat-parser.ts+++ b/apps/screenpipe-app-tauri/lib/chat/external-chat-parser.ts@@ -95,6 +95,7 @@ function titleFromText(text: string): string {"",);const compact = withoutAttachmentMarkup+ .replace(/(?:^|\n)\s*!\[Image #\d+\]\(<[^>]+>\)\s*/g, "\n").replace(/(?: | | )/gi, " ").replace(/\s+/g, " ").trim();@@ -128,7 +129,8 @@ function finishConversation({config?: ImportedAgentConfig;}): ChatConversation | null {const visibleMessages = messages.filter(- (message) => message.content.trim() || (message.contentBlocks?.length ?? 0) > 0,+ (message) => message.content.trim() || (message.images?.length ?? 0) > 0+ || (message.contentBlocks?.length ?? 0) > 0,);if (visibleMessages.length === 0 || !visibleMessages.some((message) => message.role === "user")) {return null;@@ -505,6 +507,37 @@ function cleanCodexUserText(text: string): string {.trim();}+/** Convert only the trailing attachment envelope, leaving quoted/code examples intact. */+function codexImageText(text: string, images: readonly (string | undefined)[]): string {+ const suffix = /(?:(?:^|\n)[ \t]*<image\s+name=\[Image #\d+\]\s+path="[^"\r\n]+">(?:\s*<\/image>)?\s*)+$/i.exec(text);+ if (!suffix) return text;+ const attachments = suffix[0].replace(+ /<image\s+name=\[Image #(\d+)\]\s+path="([^"\r\n]+)">(?:\s*<\/image>)?/gi,+ (tag, number: string, path: string) => {+ if (images[Number(number) - 1]) return "";+ // Use the existing local media reader; imported transcripts must never+ // cause automatic requests to remote image/tracking URLs.+ const local = /^\/(?!\/)/.test(path) || /^[a-z]:[\\/]/i.test(path);+ if (!local || !/\.(?:png|jpe?g|gif|webp|avif|bmp)$/i.test(path)) return tag;+ const normalized = /^[a-z]:[\\/]/i.test(path) ? path.replace(/\\/g, "/") : path;+ const url = encodeURI(normalized).replace(/[?#<>]/g, encodeURIComponent);+ return ``;+ },+ ).trim();+ return [text.slice(0, suffix.index).trimEnd(), attachments].filter(Boolean).join("\n\n");+}++function codexImages(content: unknown): (string | undefined)[] {+ return asArray(content)+ .map(asRecord)+ .filter((part) => part?.type === "input_image")+ .map((part) => {+ const url = asString(part?.image_url);+ return url && /^data:image\/(?:png|jpeg|jpg|gif|webp|avif|bmp);base64,[a-z0-9+/]+={0,2}$/i.test(url)+ ? url : undefined;+ });+}+/** Clean saved imports without rediscovering old provider transcripts. */export function normalizeImportedCodexConversation(conversation: ChatConversation,@@ -522,11 +555,12 @@ export function normalizeImportedCodexConversation(}const text = message.content.trim();const withoutSetup = stripCodexSetupBlocks(text);- if (withoutSetup === text) return [message];+ const cleaned = withoutSetup === text ? text : cleanCodexUserText(withoutSetup);+ const content = codexImageText(cleaned, message.images ?? []);+ if (content === message.content) return [message];changed = true;- const content = cleanCodexUserText(withoutSetup);- return content ? [{ ...message, content }] : [];+ return content || message.images?.length ? [{ ...message, content }] : [];});if (!changed) return conversation;@@ -626,12 +660,15 @@ function parseCodexTranscriptSnapshot(const text = textBlocks(payload.content, allowed).join("\n\n").trim();if (role === "user") {flushPendingAssistant();- const userText = cleanCodexUserText(text);- if (!userText) continue;+ const imageParts = codexImages(payload.content);+ const images = imageParts.filter((image): image is string => image != null);+ const userText = codexImageText(cleanCodexUserText(text), imageParts);+ if (!userText && images.length === 0) continue;messages.push({id: messageId("codex", sessionId, asString(payload.id), index),role: "user",content: userText,+ ...(images.length > 0 ? { images } : {}),timestamp,provider: "codex",importedFrom: "codex",diff --git a/docs/pr-assets/codex-imported-images/after.jpg b/docs/pr-assets/codex-imported-images/after.jpgnew file mode 100644index 000000000..5edd7276eBinary files /dev/null and b/docs/pr-assets/codex-imported-images/after.jpg differdiff --git a/docs/pr-assets/codex-imported-images/before.jpg b/docs/pr-assets/codex-imported-images/before.jpgnew file mode 100644index 000000000..37b552649Binary files /dev/null and b/docs/pr-assets/codex-imported-images/before.jpg differ