Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(onboarding): stop asking new users to sign in to an account they do not have (#5938)

Louis Beaumonta9ddc64913d5
diff --git a/apps/screenpipe-app-tauri/components/onboarding/login-gate.test.tsx b/apps/screenpipe-app-tauri/components/onboarding/login-gate.test.tsx
index 2f3569b01..fc40e60c5 100644
--- a/apps/screenpipe-app-tauri/components/onboarding/login-gate.test.tsx
+++ b/apps/screenpipe-app-tauri/components/onboarding/login-gate.test.tsx
@@ -200,11 +200,42 @@ describe("onboarding login gate", () => {
vi.useRealTimers();
});
- it("shows the sign-in button when not signed in", () => {
+ it("shows the sign-in action when not signed in", () => {
mocks.settings = { user: null };
mocks.hasAppEntitlement.mockReturnValue(false);
render(<OnboardingLogin handleNextSlide={vi.fn()} />);
+ expect(screen.getByText(/^get started$/i)).toBeInTheDocument();
+ });
+
+ // Everyone reaching this slide on a consumer build is a fresh install with
+ // no account. Labelling the only affordance "sign in" tells them the app is
+ // for people who already have one, and nothing on the slide offered to
+ // create an account: "sign up" appeared exactly once in the whole app UI,
+ // inside unrelated referral copy.
+ it("does not ask a brand-new user to sign in to an account they do not have", () => {
+ mocks.settings = { user: null };
+ mocks.hasAppEntitlement.mockReturnValue(false);
+
+ render(<OnboardingLogin handleNextSlide={vi.fn()} />);
+
+ expect(screen.getByText(/^get started$/i)).toBeInTheDocument();
+ expect(screen.queryByText(/^sign in$/i)).toBeNull();
+ // Creating an account must be named, and it must stay free.
+ expect(
+ screen.getByText(/sign in or create a free account/i),
+ ).toBeInTheDocument();
+ });
+
+ it("still sends enterprise users to sign in, because their account already exists", () => {
+ mocks.settings = { user: null };
+ mocks.hasAppEntitlement.mockReturnValue(false);
+
+ render(<OnboardingLogin handleNextSlide={vi.fn()} suppressAutoAdvance />);
+
+ // An admin provisioned this account, so "create one" would be wrong.
expect(screen.getByText(/^sign in$/i)).toBeInTheDocument();
+ expect(screen.queryByText(/^get started$/i)).toBeNull();
+ expect(screen.queryByText(/create a free account/i)).toBeNull();
});
it("labels sign-in as the enterprise-account option during enterprise onboarding", () => {
diff --git a/apps/screenpipe-app-tauri/components/onboarding/login-gate.tsx b/apps/screenpipe-app-tauri/components/onboarding/login-gate.tsx
index 6e9ecdef8..b2e2d4625 100644
--- a/apps/screenpipe-app-tauri/components/onboarding/login-gate.tsx
+++ b/apps/screenpipe-app-tauri/components/onboarding/login-gate.tsx
@@ -462,7 +462,12 @@ const OnboardingLogin: React.FC<OnboardingLoginProps> = ({
{/* Text */}
<span className="relative z-10 font-mono text-sm tracking-[0.25em] uppercase font-medium text-foreground group-hover:text-background transition-colors duration-150">
- sign in
+ {/* Enterprise users are handed an existing account by their
+ admin, so "sign in" is literally correct there. Everyone
+ else on this slide is a fresh install with no account yet,
+ and "sign in" reads as an instruction for people who
+ already have one. */}
+ {suppressAutoAdvance ? "sign in" : "get started"}
</span>
{/* Corner marks */}
@@ -481,7 +486,7 @@ const OnboardingLogin: React.FC<OnboardingLoginProps> = ({
>
{suppressAutoAdvance
? "sign in with your enterprise account"
- : "sign in to start free"}
+ : "sign in or create a free account"}
</motion.p>
</>
)}