YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(activity): keep artifact icons stable on settings refresh (#6663)
Ezra Elletteb29647ddf801
diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsxindex e03e3ad47..8d284bc4c 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx@@ -1370,6 +1370,43 @@ describe("activity history helpers", () => {});describe("ActivityLedger", () => {+ it("keeps artifact icons mounted across unrelated settings refreshes", async () => {+ const originalUser = mocks.settings.user;+ const { rerender } = render(<ActivityLedger />);+ await generateActivities();++ const appArtifact = await screen.findByRole("link", {+ name: /Open Arc at .* in Timeline/,+ });+ await waitFor(() =>+ expect(appArtifact.querySelector("img")).toHaveAttribute(+ "src",+ "http://localhost:11535/app-icon?name=Arc",+ ),+ );+ const appIcon = appArtifact.querySelector("img");+ const artifactRequestCount = mocks.localFetch.mock.calls.filter(([path]) =>+ String(path).startsWith("/activity-ledger?"),+ ).length;++ try {+ mocks.settings.user = {+ ...originalUser,+ entitlement: { ...originalUser.entitlement },+ };+ rerender(<ActivityLedger />);++ expect(appArtifact.querySelector("img")).toBe(appIcon);+ expect(+ mocks.localFetch.mock.calls.filter(([path]) =>+ String(path).startsWith("/activity-ledger?"),+ ),+ ).toHaveLength(artifactRequestCount);+ } finally {+ mocks.settings.user = originalUser;+ }+ });+it("shows a completed backend run without refreshing the page", async () => {render(<ActivityLedger />);diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.tsxindex 5fc842735..41c190104 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.tsx@@ -306,11 +306,19 @@ export function effectiveActivityRange(now: Date,isEnterpriseBuild = false,): TimeRange | null {- if (- !range ||- isEnterpriseBuild ||- !isFreeOrUnattributedUser(user)- ) {+ return effectiveActivityRangeForAccess(+ range,+ !isEnterpriseBuild && isFreeOrUnattributedUser(user),+ now,+ );+}++function effectiveActivityRangeForAccess(+ range: TimeRange | null,+ historyAccessRestricted: boolean,+ now: Date,+): TimeRange | null {+ if (!range || !historyAccessRestricted) {return range;}const start = new Date(@@ -1444,20 +1452,12 @@ export function ActivityLedger({const range = useMemo(() =>- effectiveActivityRange(+ effectiveActivityRangeForAccess(rangeForPreset(preset, anchor, customStart, customEnd),- settings.user as AppUser | null | undefined,+ activityHistoryRestricted,anchor,- enterpriseBuild.isEnterprise,),- [- anchor,- customEnd,- customStart,- enterpriseBuild.isEnterprise,- preset,- settings.user,- ],+ [activityHistoryRestricted, anchor, customEnd, customStart, preset],);const invalidRange = !range || range.start >= range.end;const reviewPresets = useMemo(