Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

feat(sidebar): show Meetings as a sidebar row by default

Louis Beaumontb44fb56e2aac
diff --git a/apps/screenpipe-app-tauri/components/settings/__tests__/display-section.sidebar-layout.test.tsx b/apps/screenpipe-app-tauri/components/settings/__tests__/display-section.sidebar-layout.test.tsx
index 2e2319695..c62706a1c 100644
--- a/apps/screenpipe-app-tauri/components/settings/__tests__/display-section.sidebar-layout.test.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/__tests__/display-section.sidebar-layout.test.tsx
@@ -41,36 +41,36 @@ describe("DisplaySection sidebar layout", () => {
afterEach(() => cleanup());
- it("shows meetings out of the sidebar by default", () => {
+ it("shows meetings in the sidebar by default", () => {
render(<DisplaySection />);
expect(screen.getByTestId("meetings-in-sidebar")).toHaveAttribute(
"data-state",
- "unchecked",
+ "checked",
);
- expect(screen.getByText("Compact icon next to search")).toBeInTheDocument();
+ expect(screen.getByText("Labelled row in the sidebar")).toBeInTheDocument();
});
- it("moves meetings into the sidebar", () => {
+ it("moves meetings out to the chrome strip", () => {
render(<DisplaySection />);
fireEvent.click(screen.getByTestId("meetings-in-sidebar"));
const patch = mocks.updateSettings.mock.calls[0][0];
- expect(patch.sidebarNavLayout.hidden).not.toContain("meetings");
+ expect(patch.sidebarNavLayout.hidden).toContain("meetings");
});
- it("moves meetings back out to the chrome strip", () => {
+ it("moves meetings back into the sidebar", () => {
mocks.settings = {
...mocks.settings,
- sidebarNavLayout: { ...DEFAULT_SIDEBAR_NAV_LAYOUT, hidden: [] },
+ sidebarNavLayout: { ...DEFAULT_SIDEBAR_NAV_LAYOUT, hidden: ["meetings"] },
};
render(<DisplaySection />);
expect(screen.getByTestId("meetings-in-sidebar")).toHaveAttribute(
"data-state",
- "checked",
+ "unchecked",
);
fireEvent.click(screen.getByTestId("meetings-in-sidebar"));
expect(
mocks.updateSettings.mock.calls[0][0].sidebarNavLayout.hidden,
- ).toContain("meetings");
+ ).not.toContain("meetings");
});
// The reset escape hatch only appears once the layout actually drifted, so a
@@ -82,7 +82,7 @@ describe("DisplaySection sidebar layout", () => {
mocks.settings = {
...mocks.settings,
- sidebarNavLayout: { ...DEFAULT_SIDEBAR_NAV_LAYOUT, hidden: [] },
+ sidebarNavLayout: { ...DEFAULT_SIDEBAR_NAV_LAYOUT, hidden: ["meetings"] },
};
render(<DisplaySection />);
fireEvent.click(screen.getByTestId("reset-sidebar-layout"));
diff --git a/apps/screenpipe-app-tauri/components/settings/display-section.tsx b/apps/screenpipe-app-tauri/components/settings/display-section.tsx
index a2910b311..a1ee7f94e 100644
--- a/apps/screenpipe-app-tauri/components/settings/display-section.tsx
+++ b/apps/screenpipe-app-tauri/components/settings/display-section.tsx
@@ -370,10 +370,10 @@ export function DisplaySection() {
</div>
</CardContent>
</Card>
- {/* Home sidebar layout. Meetings ships hidden from the sidebar, which
- is what puts its compact icon in the top-left chrome strip — so
- this switch and the right-click menu drive the same layout state
- rather than two competing preferences. */}
+ {/* Home sidebar layout. Meetings ships as a sidebar row; hiding it is
+ what puts its compact icon in the top-left chrome strip — so this
+ switch and the right-click menu drive the same layout state rather
+ than two competing preferences. */}
<Card className="border-border bg-card">
<CardContent className="px-3 py-2.5">
<div className="space-y-2.5">
diff --git a/apps/screenpipe-app-tauri/components/sidebar-nav-list.tsx b/apps/screenpipe-app-tauri/components/sidebar-nav-list.tsx
index 1eccb0e68..e40e3ac0b 100644
--- a/apps/screenpipe-app-tauri/components/sidebar-nav-list.tsx
+++ b/apps/screenpipe-app-tauri/components/sidebar-nav-list.tsx
@@ -221,6 +221,7 @@ function SortableRow({
data-testid={`nav-${item.id}`}
data-announcement-anchor={`sidebar-${item.id}`}
onClick={() => onSelect(item.id)}
+ aria-current={isActive ? "page" : undefined}
className={cn(
rowClassName(isActive, isTranslucent),
isDragging ? "cursor-grabbing" : "cursor-pointer",
@@ -368,6 +369,7 @@ export function SidebarNavList({
data-testid={`nav-${item.id}`}
data-announcement-anchor={`sidebar-${item.id}`}
onClick={() => onSelect(item.id)}
+ aria-current={activeId === item.id ? "page" : undefined}
className={rowClassName(activeId === item.id, isTranslucent)}
>
<div
diff --git a/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
index ddbf65d37..957960fb9 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/windows-user-journey.spec.ts
@@ -501,21 +501,24 @@ describe("Windows user journey", function () {
expect(existsSync(audioScreenshot)).toBe(true);
});
- it("starts and stops a manual meeting note from the Meetings toolbar button", async function () {
+ it("starts and stops a manual meeting note from the Meetings nav entry", async function () {
if (!isWindows) this.skip();
await openHomeWindow();
const meetingsNav = await $('[data-testid="nav-meetings"]');
await meetingsNav.waitForDisplayed({ timeout: t(15_000) });
- expect(await meetingsNav.getAttribute("aria-label")).toContain("meetings");
+ // Meetings ships as a sidebar row (visible text), but a customized layout
+ // renders the compact toolbar icon (aria-label) instead — accept either.
+ const navName = `${(await meetingsNav.getAttribute("aria-label")) ?? ""} ${await meetingsNav.getText()}`;
+ expect(navName.toLowerCase()).toContain("meetings");
await meetingsNav.click();
await browser.waitUntil(
async () => (await meetingsNav.getAttribute("aria-current")) === "page",
{
timeout: t(10_000),
interval: 250,
- timeoutMsg: "Meetings toolbar button did not become the current page",
+ timeoutMsg: "Meetings nav entry did not become the current page",
},
);
diff --git a/apps/screenpipe-app-tauri/lib/utils/__tests__/sidebar-nav-layout.test.ts b/apps/screenpipe-app-tauri/lib/utils/__tests__/sidebar-nav-layout.test.ts
index 817fba681..e7986e259 100644
--- a/apps/screenpipe-app-tauri/lib/utils/__tests__/sidebar-nav-layout.test.ts
+++ b/apps/screenpipe-app-tauri/lib/utils/__tests__/sidebar-nav-layout.test.ts
@@ -22,7 +22,7 @@ describe("normalizeSidebarNavLayout", () => {
for (const junk of [undefined, null, 42, "layout", [], { order: 3 }]) {
const layout = normalizeSidebarNavLayout(junk);
expect(layout.order).toEqual(ALL);
- expect(layout.hidden).toEqual(["meetings"]);
+ expect(layout.hidden).toEqual([]);
}
});
@@ -62,9 +62,9 @@ describe("normalizeSidebarNavLayout", () => {
});
describe("resolveVisibleSidebarNavIds", () => {
- it("hides meetings by default so the toolbar icon owns it", () => {
+ it("shows every row by default, meetings included", () => {
const visible = resolveVisibleSidebarNavIds(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL);
- expect(visible).toEqual(["home", "brain", "pipes", "timeline", "connections"]);
+ expect(visible).toEqual(ALL);
});
it("lets enterprise policy win over the user layout", () => {
@@ -80,12 +80,15 @@ describe("resolveVisibleSidebarNavIds", () => {
});
it("reports the hidden-but-restorable ids", () => {
- expect(resolveHiddenSidebarNavIds(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL)).toEqual([
- "meetings",
- ]);
+ expect(resolveHiddenSidebarNavIds(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL)).toEqual([]);
+ const meetingsHidden = normalizeSidebarNavLayout({
+ order: ALL,
+ hidden: ["meetings"],
+ });
+ expect(resolveHiddenSidebarNavIds(meetingsHidden, ALL)).toEqual(["meetings"]);
// Policy-hidden ids are not offered as "show" targets.
expect(
- resolveHiddenSidebarNavIds(DEFAULT_SIDEBAR_NAV_LAYOUT, ["home", "brain"]),
+ resolveHiddenSidebarNavIds(meetingsHidden, ["home", "brain"]),
).toEqual([]);
});
});
@@ -94,12 +97,16 @@ describe("reordering", () => {
it("moves an item to an index among the visible rows", () => {
const next = moveSidebarNavItem(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "connections", 0);
expect(resolveVisibleSidebarNavIds(next, ALL)).toEqual([
- "connections", "home", "brain", "pipes", "timeline",
+ "connections", "home", "brain", "meetings", "pipes", "timeline",
]);
});
it("keeps hidden ids parked instead of dragging them along", () => {
- const next = moveSidebarNavItem(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "connections", 0);
+ const meetingsHidden = normalizeSidebarNavLayout({
+ order: ALL,
+ hidden: ["meetings"],
+ });
+ const next = moveSidebarNavItem(meetingsHidden, ALL, "connections", 0);
// meetings stays hidden and still sits between brain and pipes slots.
expect(next.hidden).toEqual(["meetings"]);
expect(next.order).toContain("meetings");
@@ -121,15 +128,23 @@ describe("reordering", () => {
});
it("ignores a move for an id that is not visible", () => {
- expect(moveSidebarNavItem(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", 0)).toBe(
- DEFAULT_SIDEBAR_NAV_LAYOUT,
+ const meetingsHidden = normalizeSidebarNavLayout({
+ order: ALL,
+ hidden: ["meetings"],
+ });
+ expect(moveSidebarNavItem(meetingsHidden, ALL, "meetings", 0)).toBe(
+ meetingsHidden,
);
});
});
describe("hide and show", () => {
- it("shows meetings in the sidebar", () => {
- const next = setSidebarNavItemHidden(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", false);
+ it("shows meetings in the sidebar again after hiding it", () => {
+ const meetingsHidden = normalizeSidebarNavLayout({
+ order: ALL,
+ hidden: ["meetings"],
+ });
+ const next = setSidebarNavItemHidden(meetingsHidden, ALL, "meetings", false);
expect(resolveVisibleSidebarNavIds(next, ALL)).toContain("meetings");
// and it lands in its canonical neighbourhood, right after brain.
expect(resolveVisibleSidebarNavIds(next, ALL).indexOf("meetings")).toBe(2);
@@ -150,7 +165,7 @@ describe("hide and show", () => {
});
it("is idempotent", () => {
- const once = setSidebarNavItemHidden(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", true);
+ const once = setSidebarNavItemHidden(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", false);
expect(once).toBe(DEFAULT_SIDEBAR_NAV_LAYOUT);
});
});
@@ -160,7 +175,7 @@ describe("isSidebarNavLayoutDefault", () => {
expect(isSidebarNavLayoutDefault(DEFAULT_SIDEBAR_NAV_LAYOUT)).toBe(true);
expect(
isSidebarNavLayoutDefault(
- setSidebarNavItemHidden(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", false),
+ setSidebarNavItemHidden(DEFAULT_SIDEBAR_NAV_LAYOUT, ALL, "meetings", true),
),
).toBe(false);
expect(
diff --git a/apps/screenpipe-app-tauri/lib/utils/sidebar-nav-layout.ts b/apps/screenpipe-app-tauri/lib/utils/sidebar-nav-layout.ts
index 70474d57b..ef17277d1 100644
--- a/apps/screenpipe-app-tauri/lib/utils/sidebar-nav-layout.ts
+++ b/apps/screenpipe-app-tauri/lib/utils/sidebar-nav-layout.ts
@@ -10,10 +10,10 @@
* ids are real, what order they fall back to, and what may be hidden lives in
* one testable place.
*
- * Meetings is part of the orderable set but ships hidden: hidden means "not a
- * sidebar row", and the Home chrome strip renders its compact icon instead. So
- * "move meetings to the sidebar" and "hide meetings from the sidebar" are the
- * same operation on this layout, not a second parallel preference.
+ * Meetings ships as a visible sidebar row. Hiding it means "not a sidebar
+ * row", and the Home chrome strip renders its compact icon instead. So "move
+ * meetings to the sidebar" and "hide meetings from the sidebar" are the same
+ * operation on this layout, not a second parallel preference.
*/
/** Canonical order — also the fallback for ids a stored layout never mentioned. */
@@ -31,13 +31,13 @@ export type SidebarNavId = (typeof SIDEBAR_NAV_ORDER)[number];
export type SidebarNavLayout = {
/** Ids in render order. May omit ids (they fall back to canonical position). */
order: SidebarNavId[];
- /** Ids kept out of the sidebar. Meetings is hidden by default. */
+ /** Ids kept out of the sidebar. Nothing is hidden by default. */
hidden: SidebarNavId[];
};
export const DEFAULT_SIDEBAR_NAV_LAYOUT: SidebarNavLayout = {
order: [...SIDEBAR_NAV_ORDER],
- hidden: ["meetings"],
+ hidden: [],
};
/** At least one row must stay in the sidebar — an empty nav is a dead end. */