Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

test(e2e): stop settings specs from assuming Settings opens on General

Louis Beaumontb4b22f011c6f
diff --git a/apps/screenpipe-app-tauri/e2e/specs/chat-settings-background-stream.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/chat-settings-background-stream.spec.ts
index d88abfd3b..e343a0d9e 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/chat-settings-background-stream.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/chat-settings-background-stream.spec.ts
@@ -200,7 +200,10 @@ describe("Chat keeps streaming when opening Settings", function () {
await navSettings.waitForExist({ timeout: t(10_000) });
await navSettings.click();
// Settings page mounted ⇒ the home page (and chat panel) unmounted.
- await waitForTestId("section-settings-general", 15_000);
+ // Assert on a section-independent marker: nav-settings opens whichever
+ // section was last visited (readLastSettingsSection), so waiting on the
+ // General panel specifically makes this depend on spec ordering.
+ await waitForTestId("settings-back-to-app", 15_000);
// Sit in Settings briefly so the response keeps streaming in the background.
await browser.pause(t(2_000));
diff --git a/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth-enforcement.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth-enforcement.spec.ts
index 0fae5e952..772c30fdb 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth-enforcement.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth-enforcement.spec.ts
@@ -41,8 +41,11 @@ async function openPrivacySettings(): Promise<void> {
await navSettings.waitForExist({ timeout: t(12_000) });
await navSettings.click();
- const generalSection = await $('[data-testid="section-settings-general"]');
- await generalSection.waitForExist({ timeout: t(20_000) });
+ // nav-settings reopens the last-visited section (readLastSettingsSection), so
+ // assert Settings mounted via a section-independent marker rather than the
+ // General panel, then navigate to Privacy explicitly below.
+ const settingsRoot = await $('[data-testid="settings-back-to-app"]');
+ await settingsRoot.waitForExist({ timeout: t(20_000) });
const navPrivacy = await $('[data-testid="settings-nav-privacy"]');
await navPrivacy.waitForExist({ timeout: t(20_000) });
diff --git a/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth.spec.ts
index 67277d4b9..940cfefc1 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/privacy-api-auth.spec.ts
@@ -13,8 +13,11 @@ async function openPrivacySettings(): Promise<void> {
await navSettings.waitForExist({ timeout: t(12_000) });
await navSettings.click();
- const generalSection = await $('[data-testid="section-settings-general"]');
- await generalSection.waitForExist({ timeout: t(20_000) });
+ // nav-settings reopens the last-visited section (readLastSettingsSection), so
+ // assert Settings mounted via a section-independent marker rather than the
+ // General panel, then navigate to Privacy explicitly below.
+ const settingsRoot = await $('[data-testid="settings-back-to-app"]');
+ await settingsRoot.waitForExist({ timeout: t(20_000) });
const navPrivacy = await $('[data-testid="settings-nav-privacy"]');
await navPrivacy.waitForExist({ timeout: t(20_000) });
diff --git a/apps/screenpipe-app-tauri/e2e/specs/privacy-installed-apps.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/privacy-installed-apps.spec.ts
index 1791ade7d..4518c7761 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/privacy-installed-apps.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/privacy-installed-apps.spec.ts
@@ -31,6 +31,13 @@ async function openSettings(): Promise<void> {
const navSettings = await $('[data-testid="nav-settings"]');
await navSettings.waitForExist({ timeout: t(10_000) });
await navSettings.click();
+ // nav-settings reopens the last-visited section (readLastSettingsSection),
+ // which may already be Privacy — and the installed-apps shim below must be
+ // installed while NOT on Privacy so the next mount refetches under it.
+ // Select General explicitly instead of assuming it is where we landed.
+ const navGeneral = await $('[data-testid="settings-nav-general"]');
+ await navGeneral.waitForExist({ timeout: t(10_000) });
+ await navGeneral.click();
const general = await $('[data-testid="section-settings-general"]');
await general.waitForExist({ timeout: t(8_000) });
}
diff --git a/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
index 3d91907b1..48d3be95c 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/settings-sections.spec.ts
@@ -57,6 +57,15 @@ async function openSettings(): Promise<void> {
const navSettings = await $('[data-testid="nav-settings"]');
await navSettings.waitForExist({ timeout: t(15_000) });
await navSettings.click();
+ // The sidebar button calls openSettings() with no argument, which resolves to
+ // readLastSettingsSection() — the *persisted* section, not General. These tests
+ // walk every section, so the first run leaves a non-General section behind and
+ // every retry (specFileRetries) would then hang here waiting for a General
+ // panel the app never opened. Select General explicitly so the hook is
+ // idempotent no matter which section the previous attempt ended on.
+ const navGeneral = await $('[data-testid="settings-nav-general"]');
+ await navGeneral.waitForExist({ timeout: t(30_000) });
+ await navGeneral.click();
const generalSection = await $('[data-testid="section-settings-general"]');
await generalSection.waitForExist({ timeout: t(30_000) });
}
diff --git a/apps/screenpipe-app-tauri/e2e/specs/updater-banner.spec.ts b/apps/screenpipe-app-tauri/e2e/specs/updater-banner.spec.ts
index c3bb58581..9c5bf4834 100644
--- a/apps/screenpipe-app-tauri/e2e/specs/updater-banner.spec.ts
+++ b/apps/screenpipe-app-tauri/e2e/specs/updater-banner.spec.ts
@@ -129,6 +129,10 @@ describe("Update banner surfacing", function () {
const navSettings = await $('[data-testid="nav-settings"]');
await navSettings.waitForDisplayed({ timeout: t(15_000) });
await navSettings.click();
+ // nav-settings reopens the last-visited section (readLastSettingsSection),
+ // so select General explicitly — the auto-update toggle only exists there.
+ const navGeneral = await waitForTestId("settings-nav-general", 15_000);
+ await navGeneral.click();
await waitForTestId("section-settings-general", 15_000);
const toggle = await $("#auto-update-toggle");