Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(workflows): restore chat mode before showing its launcher

louisbee4d7d31819
diff --git a/apps/screenpipe-app-tauri/components/workflows/workflow-chat-launcher.test.tsx b/apps/screenpipe-app-tauri/components/workflows/workflow-chat-launcher.test.tsx
new file mode 100644
index 000000000..9385481b7
--- /dev/null
+++ b/apps/screenpipe-app-tauri/components/workflows/workflow-chat-launcher.test.tsx
@@ -0,0 +1,58 @@
+// screenpipe — AI that knows everything you've seen, said, or heard
+// https://screenpipe.com
+import React, { useState } from "react";
+import { act, fireEvent, render, screen, waitFor } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+import { WorkflowAssistant, emptyAssistantState, type WorkflowsAssistantPlatform, type AssistantState } from "@screenpipe/workflows-ui";
+
+function Shell({ platform }: { platform: WorkflowsAssistantPlatform }) {
+ const [mode, setMode] = useState<AssistantState["mode"] | null>(null);
+ const [docked, setDocked] = useState(false);
+ return <>
+ {mode === "sidebar" && !docked && <button aria-label="Open right sidebar" onClick={() => window.dispatchEvent(new Event("workflows:toggle-assistant"))} />}
+ <WorkflowAssistant platform={platform} context={{ key: "catalog", title: "Workflows" }} headerToggle onModeChange={setMode} onDockChange={setDocked} />
+ </>;
+}
+function platform(load: WorkflowsAssistantPlatform["load"]): WorkflowsAssistantPlatform {
+ return { load, save: vi.fn().mockResolvedValue(undefined), ask: vi.fn().mockResolvedValue("Answer") };
+}
+
+describe("chat launchers follow the saved display mode", () => {
+ it.each(["floating", "sidebar"] as const)("restores %s before showing its launcher, without opening chat", async mode => {
+ let finish!: (state: AssistantState) => void;
+ const load = vi.fn(() => new Promise<AssistantState>(resolve => { finish = resolve; }));
+ render(<Shell platform={platform(load)} />);
+ expect(load).toHaveBeenCalledTimes(1);
+ expect(screen.queryByRole("button", { name: "Open chat" })).not.toBeInTheDocument();
+ expect(screen.queryByRole("button", { name: "Open right sidebar" })).not.toBeInTheDocument();
+ const saved = emptyAssistantState(); saved.mode = mode;
+ saved.conversations[0].draft = "Keep my draft";
+ await act(async () => finish(saved));
+ const launcher = mode === "floating" ? "Open chat" : "Open right sidebar";
+ expect(screen.queryByRole("region", { name: "Screenpipe assistant" })).not.toBeInTheDocument();
+ fireEvent.click(await screen.findByRole("button", { name: launcher }));
+ expect(screen.getByRole("region", { name: "Screenpipe assistant" })).toHaveAttribute("data-mode", mode);
+ expect(screen.getByRole("textbox", { name: "Ask Screenpipe" })).toHaveValue("Keep my draft");
+ expect(load).toHaveBeenCalledTimes(1);
+ });
+
+ it("defaults to the bubble and swaps launchers only when the user changes display mode", async () => {
+ const api = platform(vi.fn().mockResolvedValue(null));
+ render(<Shell platform={api} />);
+ fireEvent.click(await screen.findByRole("button", { name: "Open chat" }));
+ expect(screen.queryByRole("button", { name: "Open right sidebar" })).not.toBeInTheDocument();
+ fireEvent.change(screen.getByRole("textbox"), { target: { value: "Unsent question" } });
+ fireEvent.click(screen.getByRole("button", { name: "Chat display" }));
+ fireEvent.click(screen.getByRole("menuitemradio", { name: "Sidebar" }));
+ fireEvent.click(screen.getByRole("button", { name: "Collapse right sidebar" }));
+ expect(screen.queryByRole("button", { name: "Open chat" })).not.toBeInTheDocument();
+ fireEvent.click(screen.getByRole("button", { name: "Open right sidebar" }));
+ fireEvent.click(screen.getByRole("button", { name: "Chat display" }));
+ fireEvent.click(screen.getByRole("menuitemradio", { name: "Floating" }));
+ fireEvent.click(screen.getByRole("button", { name: "Minimize chat" }));
+ expect(screen.queryByRole("button", { name: "Open right sidebar" })).not.toBeInTheDocument();
+ fireEvent.click(screen.getByRole("button", { name: "Open chat" }));
+ expect(screen.getByRole("textbox")).toHaveValue("Unsent question");
+ await waitFor(() => expect(api.save).toHaveBeenLastCalledWith(expect.objectContaining({ mode: "floating" })));
+ });
+});
diff --git a/packages/workflows-ui/src/workflow-assistant.tsx b/packages/workflows-ui/src/workflow-assistant.tsx
index 48f16980a..2cd3a03a1 100644
--- a/packages/workflows-ui/src/workflow-assistant.tsx
+++ b/packages/workflows-ui/src/workflow-assistant.tsx
@@ -25,7 +25,7 @@ export function WorkflowAssistant({ platform, context, onDockChange, onWidthChan
}) {
const shortcuts = useSidebarShortcuts();
const [open, setOpen] = useState(false);
- const [state, setState] = useState<AssistantState>(() => ({ ...emptyAssistantState(), mode: headerToggle ? "sidebar" : "floating" }));
+ const [state, setState] = useState<AssistantState>(emptyAssistantState);
const useHeaderToggle = headerToggle && state.mode === "sidebar";
const launcherLabel = headerToggle ? "Open chat" : "Ask Screenpipe";
const stateRef = useRef(state);
@@ -95,7 +95,7 @@ export function WorkflowAssistant({ platform, context, onDockChange, onWidthChan
finally { loadInFlight.current = false; }
}, [platform]);
- useEffect(() => { if (open && !loadedRef.current && !loadError) void restore(); }, [open, restore, loadError]);
+ useEffect(() => { if (active && !loadedRef.current && !loadError) void restore(); }, [active, restore, loadError]);
useEffect(() => {
if (context.purpose !== "sop") { selectedSop.current = null; return; }
if (!loaded || busy || selectedSop.current === context.key) return;
@@ -110,7 +110,7 @@ export function WorkflowAssistant({ platform, context, onDockChange, onWidthChan
useEffect(() => { onDockChange(open && state.mode === "sidebar"); }, [open, state.mode, onDockChange]);
useEffect(() => { onWidthChange?.(width); }, [width, onWidthChange]);
useEffect(() => { onOpenChange?.(open); }, [open, onOpenChange]);
- useEffect(() => { onModeChange?.(state.mode); }, [state.mode, onModeChange]);
+ useEffect(() => { if (loaded || loadError) onModeChange?.(state.mode); }, [state.mode, loaded, loadError, onModeChange]);
useEffect(() => { if (open && loaded) (historyOpen ? historyInput.current : input.current)?.focus(); }, [open, loaded, historyOpen]);
useEffect(() => {
if (displayOpen) displayMenu.current?.querySelector<HTMLButtonElement>('[aria-checked="true"]')?.focus();
@@ -295,7 +295,7 @@ export function WorkflowAssistant({ platform, context, onDockChange, onWidthChan
}
return <>
- {!open && !useHeaderToggle && <button ref={launcher} className={styles.launcher} onClick={() => setOpen(true)} title={`${launcherLabel} (${shortcuts.right.keys.join(" ")})`} aria-keyshortcuts={shortcuts.right.aria} aria-label={launcherLabel} aria-expanded={false}>
+ {!open && (loaded || loadError) && !useHeaderToggle && <button ref={launcher} className={styles.launcher} onClick={() => setOpen(true)} title={`${launcherLabel} (${shortcuts.right.keys.join(" ")})`} aria-keyshortcuts={shortcuts.right.aria} aria-label={launcherLabel} aria-expanded={false}>
<MessageCircle size={20} strokeWidth={1.65} /><span>{launcherLabel}<kbd>{shortcuts.right.keys.join(" ")}</kbd></span>{busy && <i aria-label="Answer in progress" />}
</button>}
<aside id="workflows-assistant" ref={panel} hidden={!open} className={[styles.panel, state.mode === "sidebar" ? styles.docked : styles.floating].join(" ")}
diff --git a/packages/workflows-ui/src/workflows-app.tsx b/packages/workflows-ui/src/workflows-app.tsx
index 57c3a2764..1fc75d76b 100644
--- a/packages/workflows-ui/src/workflows-app.tsx
+++ b/packages/workflows-ui/src/workflows-app.tsx
@@ -409,7 +409,7 @@ function AppShell({
}), [assistant?.platform, pageAssistant]);
const [assistantDocked, setAssistantDocked] = useState(false);
const [assistantOpen, setAssistantOpen] = useState(false);
- const [assistantMode, setAssistantMode] = useState<AssistantState["mode"]>("sidebar");
+ const [assistantMode, setAssistantMode] = useState<AssistantState["mode"] | null>(null);
const assistantToggleLabel = assistantOpen ? "Collapse right sidebar" : "Open right sidebar";
const [navigationCollapsed, setNavigationCollapsed] = useState(false);
const shortcuts = useSidebarShortcuts();
@@ -514,7 +514,7 @@ function AppShell({
</nav>}
<main className={styles.main}>{children}</main>
</section>
- {assistant && <WorkflowAssistant composerAccessory={composerAccessory} active={active} platform={assistantPlatform!} context={pageAssistant?.context ?? assistant.context} onDockChange={setAssistantDocked} onWidthChange={setAssistantWidth} onOpenChange={setAssistantOpen} onModeChange={setAssistantMode} headerToggle={!pageAssistant} />}
+ {assistant && <WorkflowAssistant composerAccessory={composerAccessory} active={active} platform={assistantPlatform!} context={pageAssistant?.context ?? assistant.context} onDockChange={setAssistantDocked} onWidthChange={setAssistantWidth} onOpenChange={setAssistantOpen} onModeChange={setAssistantMode} headerToggle />}
</div></PageAssistantContext.Provider>
);
}