Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(meeting-notes): stop gating speaker rename on file path (#4989)

Ezra Ellettec856cf4dd567
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/replay-strip.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/replay-strip.tsx
index d66a94151..01c04acbf 100644
--- a/apps/screenpipe-app-tauri/components/meeting-notes/replay-strip.tsx
+++ b/apps/screenpipe-app-tauri/components/meeting-notes/replay-strip.tsx
@@ -296,7 +296,13 @@ export function ReplayStrip({ meetingId, segments, timeRange }: ReplayStripProps
if (sampleSorted.length === 0) return null;
const speakerLabel = activeChunk?.speakerName || (activeChunk?.isInput ? "me" : "speaker");
- const showSpeakerPopover = !!activeChunk?.audioChunkId && !!activeChunk?.audioFilePath;
+ // Only a real (positive) audio_chunk_id can be reassigned via
+ // /speakers/reassign — audioFilePath is merely for the optional playback
+ // preview inside the popover and can legitimately be empty (e.g. a
+ // background chunk with a corrupted file_path) without blocking renaming.
+ // Live-only rows get a synthetic negative audioChunkId (see
+ // fetchRoutedMeetingTranscript) and must stay excluded.
+ const showSpeakerPopover = (activeChunk?.audioChunkId ?? 0) > 0;
return (
<section className="border-t border-border pt-5">
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/transcript-panel.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/transcript-panel.tsx
index d1dc3f561..d788033a3 100644
--- a/apps/screenpipe-app-tauri/components/meeting-notes/transcript-panel.tsx
+++ b/apps/screenpipe-app-tauri/components/meeting-notes/transcript-panel.tsx
@@ -998,7 +998,11 @@ function SpeakerParagraph({
style={{ contain: "layout paint" }}
>
<div className="flex items-baseline gap-2 mb-1">
- {block.firstAudioFilePath ? (
+ {/* Gate on chunk id, not file path: reassignment only needs a real
+ audio_chunk_id. firstAudioFilePath can legitimately be empty
+ (e.g. a background chunk with a corrupted file_path) without
+ that blocking renaming — it's only used for playback preview. */}
+ {block.firstAudioChunkId > 0 ? (
<SpeakerAssignPopover
audioChunkId={block.firstAudioChunkId}
speakerId={block.speakerId ?? undefined}
diff --git a/apps/screenpipe-app-tauri/components/speaker-assign-popover.tsx b/apps/screenpipe-app-tauri/components/speaker-assign-popover.tsx
index 679cdeb94..cf8015db5 100644
--- a/apps/screenpipe-app-tauri/components/speaker-assign-popover.tsx
+++ b/apps/screenpipe-app-tauri/components/speaker-assign-popover.tsx
@@ -315,24 +315,28 @@ export function SpeakerAssignPopover({
</div>
)}
- {/* Audio preview toggle */}
- <div className="pt-2 border-t">
- <Button
- variant="ghost"
- size="sm"
- className="w-full justify-start text-xs"
- onClick={() => setShowAudioPreview(!showAudioPreview)}
- >
- <Volume2 className="h-3 w-3 mr-2" />
- {showAudioPreview ? "Hide audio preview" : "Play audio to confirm"}
- </Button>
-
- {showAudioPreview && (
- <div className="mt-2">
- <MediaComponent filePath={audioFilePath} />
- </div>
- )}
- </div>
+ {/* Audio preview toggle — only offered when we actually have a file
+ to play; audioFilePath can be empty (e.g. a corrupted
+ file_path) even though the chunk itself is still assignable. */}
+ {audioFilePath && (
+ <div className="pt-2 border-t">
+ <Button
+ variant="ghost"
+ size="sm"
+ className="w-full justify-start text-xs"
+ onClick={() => setShowAudioPreview(!showAudioPreview)}
+ >
+ <Volume2 className="h-3 w-3 mr-2" />
+ {showAudioPreview ? "Hide audio preview" : "Play audio to confirm"}
+ </Button>
+
+ {showAudioPreview && (
+ <div className="mt-2">
+ <MediaComponent filePath={audioFilePath} />
+ </div>
+ )}
+ </div>
+ )}
{/* Mark as noise button */}
{speakerId && (