Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(meeting-notes): align header with the note column

Louis Beaumontd1e596207c59
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx
index 6b006f60e..804794513 100644
--- a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx
+++ b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.test.tsx
@@ -7,10 +7,30 @@ import { fireEvent, render, screen } from "@testing-library/react";
import { describe, expect, it, vi } from "vitest";
import {
extractMeetingSummary,
+ MEETING_READING_COLUMN_CLASS,
+ MEETING_SHELL_CLASS,
MeetingSummarySurface,
MeetingWorkspaceTabs,
} from "./meeting-workspace";
+describe("meeting shell width contract", () => {
+ // The header (title, chips, tabs) used to sit in max-w-5xl while the note
+ // text sat in max-w-3xl > max-w-[68ch], so the title floated ~190px left of
+ // the text under it. Every meeting surface must resolve to one centered
+ // container, and the reading column must not reintroduce a second cap.
+ it("keeps one centered container width for every meeting surface", () => {
+ expect(MEETING_SHELL_CLASS).toContain("mx-auto");
+ expect(MEETING_SHELL_CLASS).toContain("max-w-3xl");
+ expect(MEETING_SHELL_CLASS).toMatch(/\bpx-5\b/);
+ expect(MEETING_SHELL_CLASS).toMatch(/\bsm:px-8\b/);
+ });
+
+ it("does not let the reading column set a competing width", () => {
+ expect(MEETING_READING_COLUMN_CLASS).not.toMatch(/max-w-/);
+ expect(MEETING_READING_COLUMN_CLASS).not.toMatch(/mx-auto/);
+ });
+});
+
describe("meeting workspace tabs", () => {
it("supports arrow-key navigation with one selected tab", () => {
const onValueChange = vi.fn();
@@ -69,9 +89,16 @@ describe("meeting summary surface", () => {
"select-none",
);
expect(screen.getByTestId("meeting-summary-reading-column")).toHaveClass(
- "max-w-[68ch]",
"select-text",
);
+ // The shell, not the reading column, bounds the selectable width now.
+ // Selection must still have a width-limited container to paint inside so
+ // it never renders as a full-window horizontal band.
+ expect(
+ screen
+ .getByTestId("meeting-summary-reading-column")
+ .closest(".max-w-3xl"),
+ ).not.toBeNull();
expect(screen.queryByText(/private draft/)).not.toBeInTheDocument();
fireEvent.click(screen.getByRole("button", { name: "summarize again" }));
expect(onGenerate).toHaveBeenCalledOnce();
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx
index e87e00d00..5b2a5e0a6 100644
--- a/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx
+++ b/apps/screenpipe-app-tauri/components/meeting-notes/meeting-workspace.tsx
@@ -9,7 +9,16 @@ import { cn } from "@/lib/utils";
export type MeetingWorkspaceTab = "notes" | "transcript" | "summary";
-export const MEETING_READING_COLUMN_CLASS = "mx-auto w-full max-w-[68ch]";
+// One shell owns the horizontal rhythm of the whole meeting view: the header
+// (title, chips, tabs), every tab panel, and the footer. Keeping them on a
+// single centered container is what makes the title line up with the note
+// text beneath it instead of floating on its own wider edge.
+export const MEETING_SHELL_CLASS = "mx-auto w-full max-w-3xl px-5 sm:px-8";
+
+// The shell already bounds the selectable width, so the reading column no
+// longer needs its own cap. It stays a distinct class because selection
+// highlighting must have a width-limited container to paint inside.
+export const MEETING_READING_COLUMN_CLASS = "w-full";
const MEETING_TABS: ReadonlyArray<{
value: MeetingWorkspaceTab;
@@ -138,7 +147,7 @@ export function MeetingSummarySurface({
data-testid="meeting-summary-surface"
className="h-full select-none overflow-y-auto [scrollbar-gutter:stable]"
>
- <div className="mx-auto w-full max-w-3xl px-5 py-8 sm:px-8 sm:py-10">
+ <div className={cn(MEETING_SHELL_CLASS, "py-8 sm:py-10")}>
<div className="mb-8 flex items-start justify-between gap-5 border-b border-border pb-5">
<div className="min-w-0">
<p className="font-mono text-[10px] uppercase tracking-[0.14em] text-muted-foreground">
diff --git a/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx b/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx
index e985e8994..7e182dee9 100644
--- a/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx
+++ b/apps/screenpipe-app-tauri/components/meeting-notes/note-view.tsx
@@ -135,6 +135,7 @@ import {
} from "./meeting-summary-stream";
import {
MEETING_READING_COLUMN_CLASS,
+ MEETING_SHELL_CLASS,
MeetingSummarySurface,
MeetingWorkspaceTabs,
type MeetingWorkspaceTab,
@@ -1441,7 +1442,7 @@ export function NoteView({
</div>
)}
<header className="z-20 shrink-0 border-b border-border bg-background">
- <div className="mx-auto w-full max-w-5xl px-4 pt-3 sm:px-8">
+ <div className={cn(MEETING_SHELL_CLASS, "pt-3")}>
<div className="flex min-w-0 items-center gap-3">
<Button
variant="ghost"
@@ -1557,7 +1558,7 @@ export function NoteView({
activeTab !== "notes" && "hidden",
)}
>
- <div className="mx-auto w-full max-w-3xl px-5 pb-16 pt-8 sm:px-8 sm:pt-10">
+ <div className={cn(MEETING_SHELL_CLASS, "pb-16 pt-8 sm:pt-10")}>
<NoteEditor
ref={noteEditorRef}
key={meeting.id}
@@ -1629,7 +1630,7 @@ export function NoteView({
</main>
<footer className="z-30 min-w-0 shrink-0 border-t border-border bg-background">
- <div className="mx-auto w-full max-w-5xl px-4 py-3 sm:px-8">
+ <div className={cn(MEETING_SHELL_CLASS, "py-3")}>
{!isLive && inactivityPrompt && (
<InactivityResumeBanner
resuming={resuming}