Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(cli): replace saved opposite window filters and release v0.4.57 (#7867)

Ezra Elletted5d1d4e806bb
diff --git a/Cargo.lock b/Cargo.lock
index 8ecc04978..536e18967 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -8677,7 +8677,7 @@ dependencies = [
[[package]]
name = "screenpipe-audio"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"audiopipe",
@@ -8747,7 +8747,7 @@ dependencies = [
[[package]]
name = "screenpipe-audio-eval"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"audiopipe",
@@ -8787,7 +8787,7 @@ dependencies = [
[[package]]
name = "screenpipe-config"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"dirs 6.0.0",
"screenpipe-cpu-features",
@@ -8801,7 +8801,7 @@ dependencies = [
[[package]]
name = "screenpipe-connect"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"async-imap",
@@ -8851,7 +8851,7 @@ dependencies = [
[[package]]
name = "screenpipe-core"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility",
"accessibility-sys",
@@ -8908,11 +8908,11 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.56"
+version = "0.4.57"
[[package]]
name = "screenpipe-db"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -8952,7 +8952,7 @@ dependencies = [
[[package]]
name = "screenpipe-engine"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"arc-swap",
@@ -9041,7 +9041,7 @@ dependencies = [
[[package]]
name = "screenpipe-events"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -9059,7 +9059,7 @@ dependencies = [
[[package]]
name = "screenpipe-fs"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"libc",
"tempfile",
@@ -9067,7 +9067,7 @@ dependencies = [
[[package]]
name = "screenpipe-gateway"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"async-trait",
"axum",
@@ -9098,7 +9098,7 @@ dependencies = [
[[package]]
name = "screenpipe-meeting-eval"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"clap",
@@ -9110,7 +9110,7 @@ dependencies = [
[[package]]
name = "screenpipe-overlay-win"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"serde_json",
@@ -9121,7 +9121,7 @@ dependencies = [
[[package]]
name = "screenpipe-redact"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"aho-corasick",
"anyhow",
@@ -9163,7 +9163,7 @@ dependencies = [
[[package]]
name = "screenpipe-resource"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"sysinfo",
@@ -9183,7 +9183,7 @@ dependencies = [
[[package]]
name = "screenpipe-screen"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility-sys",
"anyhow",
@@ -9266,7 +9266,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-coordinator"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"fs2",
"libsqlite3-sys",
@@ -9282,7 +9282,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-recovery"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"cc",
"libsqlite3-sys",
@@ -9292,7 +9292,7 @@ dependencies = [
[[package]]
name = "screenpipe-sync"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"async-trait",
"base64 0.22.1",
@@ -9314,7 +9314,7 @@ dependencies = [
[[package]]
name = "screenpipe-team-memory"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"serde_yaml",
@@ -9323,7 +9323,7 @@ dependencies = [
[[package]]
name = "screenpipe-telemetry-wire"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"serde_json",
@@ -9334,7 +9334,7 @@ dependencies = [
[[package]]
name = "screenpipe-vault"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"argon2 0.5.3",
"chacha20poly1305",
diff --git a/Cargo.toml b/Cargo.toml
index 511c9c216..e24ed0242 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -15,7 +15,7 @@ exclude = [
resolver = "2"
[workspace.package]
-version = "0.4.56"
+version = "0.4.57"
authors = ["louis030195 <[email protected]>"]
description = ""
repository = "https://github.com/screenpipe/screenpipe"
diff --git a/apps/screenpipe-app-tauri/src-tauri/Cargo.lock b/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
index d616f955f..cc0c2c9d3 100644
--- a/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
+++ b/apps/screenpipe-app-tauri/src-tauri/Cargo.lock
@@ -11399,7 +11399,7 @@ dependencies = [
[[package]]
name = "screenpipe-audio"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"audiopipe",
@@ -11481,7 +11481,7 @@ dependencies = [
[[package]]
name = "screenpipe-config"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"dirs 6.0.0",
"screenpipe-cpu-features",
@@ -11494,7 +11494,7 @@ dependencies = [
[[package]]
name = "screenpipe-connect"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"async-imap",
@@ -11542,7 +11542,7 @@ dependencies = [
[[package]]
name = "screenpipe-core"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility",
"accessibility-sys",
@@ -11598,11 +11598,11 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.56"
+version = "0.4.57"
[[package]]
name = "screenpipe-db"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -11641,7 +11641,7 @@ dependencies = [
[[package]]
name = "screenpipe-engine"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"arc-swap",
@@ -11718,7 +11718,7 @@ dependencies = [
[[package]]
name = "screenpipe-events"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -11734,14 +11734,14 @@ dependencies = [
[[package]]
name = "screenpipe-fs"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"libc",
]
[[package]]
name = "screenpipe-overlay-win"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"serde_json",
@@ -11766,7 +11766,7 @@ dependencies = [
[[package]]
name = "screenpipe-redact"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"aho-corasick",
"anyhow",
@@ -11805,7 +11805,7 @@ dependencies = [
[[package]]
name = "screenpipe-resource"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"sysinfo",
@@ -11825,7 +11825,7 @@ dependencies = [
[[package]]
name = "screenpipe-screen"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility-sys",
"anyhow",
@@ -11894,7 +11894,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-coordinator"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"fs2",
"libsqlite3-sys",
@@ -11909,7 +11909,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-recovery"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"cc",
"libsqlite3-sys",
@@ -11917,7 +11917,7 @@ dependencies = [
[[package]]
name = "screenpipe-sync"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"async-trait",
"base64 0.22.1",
@@ -11937,7 +11937,7 @@ dependencies = [
[[package]]
name = "screenpipe-telemetry-wire"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"serde_json",
@@ -11948,7 +11948,7 @@ dependencies = [
[[package]]
name = "screenpipe-vault"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"argon2 0.5.3",
"chacha20poly1305",
diff --git a/crates/screenpipe-engine/src/cli/mod.rs b/crates/screenpipe-engine/src/cli/mod.rs
index 9b797b008..846e2a6b7 100644
--- a/crates/screenpipe-engine/src/cli/mod.rs
+++ b/crates/screenpipe-engine/src/cli/mod.rs
@@ -658,6 +658,7 @@ pub struct RecordArgs {
/// scope to one window of one app (e.g. `Slack::#hr`). `::title` matches
/// any app whose focused window title contains `title`. `App::` blocks
/// the entire app (equivalent to bare `App`).
+ /// Removes the same patterns from saved includes unless --included-windows is also supplied.
#[arg(long)]
pub ignored_windows: Vec<String>,
@@ -665,6 +666,7 @@ pub struct RecordArgs {
/// (`App::Title`) create a per-app whitelist; other apps remain
/// unaffected. Unscoped entries keep the legacy "must match app or
/// title" global-include semantics.
+ /// Removes the same patterns from saved ignores unless --ignored-windows is also supplied.
#[arg(long)]
pub included_windows: Vec<String>,
@@ -1602,9 +1604,21 @@ impl RecordArgs {
}
if sources.ignored_windows {
settings.ignored_windows = self.ignored_windows.clone();
+ if !sources.included_windows {
+ remove_explicit_window_patterns(
+ &mut settings.included_windows,
+ &self.ignored_windows,
+ );
+ }
}
if sources.included_windows {
settings.included_windows = self.included_windows.clone();
+ if !sources.ignored_windows {
+ remove_explicit_window_patterns(
+ &mut settings.ignored_windows,
+ &self.included_windows,
+ );
+ }
}
if sources.ignored_urls || sources.url_block {
settings.ignored_urls = self.combined_ignored_urls();
@@ -1682,6 +1696,18 @@ impl RecordArgs {
}
}
+/// An explicit CLI choice supersedes an equivalent saved opposite choice.
+/// Compare parsed patterns, not matching windows: broader privacy exclusions stay intact.
+fn remove_explicit_window_patterns(saved: &mut Vec<String>, explicit: &[String]) {
+ use screenpipe_core::window_pattern::WindowPattern;
+
+ let explicit = WindowPattern::parse_list(explicit);
+ saved.retain(|raw| match WindowPattern::parse(raw) {
+ Some(pattern) => !explicit.contains(&pattern),
+ None => true,
+ });
+}
+
fn load_recording_settings_from_store(
data_dir: &Path,
) -> anyhow::Result<Option<screenpipe_config::RecordingSettings>> {
@@ -2644,6 +2670,141 @@ mod tests {
RecordArgSources::from_cli_matches(&matches)
}
+ #[tokio::test]
+ async fn explicit_window_filter_replaces_saved_opposite_and_survives_restart() {
+ use screenpipe_screen::capture_screenshot_by_window::WindowFilters;
+
+ for (flag, include) in [("--included-windows", true), ("--ignored-windows", false)] {
+ let root = tempfile::tempdir().unwrap();
+ let saved = screenpipe_config::RecordingSettings {
+ user_id: "window-filter-test".into(),
+ device_tier: Some("mid".into()),
+ ignored_windows: vec!["Cursor".into(), "Private".into()],
+ included_windows: vec!["Cursor".into(), "Editor".into()],
+ ..Default::default()
+ };
+ persist_recording_settings_to_store(root.path(), &saved, false).unwrap();
+ let argv = ["screenpipe", "record", "--api-auth=false", flag, "cursor"];
+ let config = record_args(argv)
+ .into_recording_config(root.path().into(), &record_sources(argv))
+ .await
+ .unwrap();
+ let (ignored, included) = if include {
+ (vec!["Private".to_string()], vec!["cursor".to_string()])
+ } else {
+ (vec!["cursor".to_string()], vec!["Editor".to_string()])
+ };
+ assert_eq!(config.ignored_windows, ignored);
+ assert_eq!(config.included_windows, included);
+ let filters =
+ WindowFilters::new(&config.ignored_windows, &config.included_windows, &[]);
+ assert_eq!(filters.is_valid("Cursor", "Project"), include);
+ assert!(!filters.is_valid("Private", "Secrets"));
+
+ let reloaded = load_recording_settings_from_store(root.path())
+ .unwrap()
+ .unwrap();
+ assert_eq!(reloaded.ignored_windows, ignored);
+ assert_eq!(reloaded.included_windows, included);
+ let argv = ["screenpipe", "record", "--api-auth=false"];
+ let restarted = record_args(argv)
+ .into_recording_config(root.path().into(), &record_sources(argv))
+ .await
+ .unwrap();
+ assert_eq!(restarted.ignored_windows, ignored);
+ assert_eq!(restarted.included_windows, included);
+ }
+ }
+
+ #[test]
+ fn explicit_window_filter_only_removes_equivalent_saved_patterns() {
+ let argv = [
+ "screenpipe",
+ "record",
+ "--included-windows",
+ " CURSOR :: Project ",
+ "--included-windows",
+ " ÉDITEUR ",
+ ];
+ let mut settings = screenpipe_config::RecordingSettings {
+ ignored_windows: vec![
+ "cursor::project".into(),
+ "Éditeur".into(),
+ "Cursor::Private".into(),
+ "Cursor".into(),
+ "Cur".into(),
+ "::Project".into(),
+ "Private".into(),
+ ],
+ ..Default::default()
+ };
+ record_args(argv).apply_explicit_overrides(&mut settings, &record_sources(argv));
+ assert_eq!(
+ settings.ignored_windows,
+ vec!["Cursor::Private", "Cursor", "Cur", "::Project", "Private",]
+ );
+ }
+
+ #[test]
+ fn explicit_window_filter_preserves_both_lists_when_both_are_supplied() {
+ use screenpipe_screen::capture_screenshot_by_window::WindowFilters;
+
+ for argv in [
+ [
+ "screenpipe",
+ "record",
+ "--included-windows",
+ "Cursor",
+ "--ignored-windows",
+ "Cursor",
+ ],
+ [
+ "screenpipe",
+ "record",
+ "--ignored-windows",
+ "Cursor",
+ "--included-windows",
+ "Cursor",
+ ],
+ ] {
+ let args = record_args(argv);
+ let mut settings = screenpipe_config::RecordingSettings::default();
+ args.apply_explicit_overrides(&mut settings, &record_sources(argv));
+ assert_eq!(settings.ignored_windows, vec!["Cursor"]);
+ assert_eq!(settings.included_windows, vec!["Cursor"]);
+ let filters =
+ WindowFilters::new(&settings.ignored_windows, &settings.included_windows, &[]);
+ assert!(!filters.is_valid("Cursor", "Project"));
+ }
+ }
+
+ #[test]
+ fn absent_window_filter_flags_and_desktop_conversion_preserve_saved_policy() {
+ use screenpipe_screen::capture_screenshot_by_window::WindowFilters;
+
+ let mut settings = screenpipe_config::RecordingSettings {
+ ignored_windows: vec!["Cursor".into(), "Private".into()],
+ included_windows: vec!["Cursor".into()],
+ ..Default::default()
+ };
+ let saved = serde_json::to_value(&settings).unwrap();
+ let argv = ["screenpipe", "record"];
+ record_args(argv).apply_explicit_overrides(&mut settings, &record_sources(argv));
+ assert_eq!(serde_json::to_value(&settings).unwrap(), saved);
+ let config = crate::recording_config::RecordingConfig::from_settings(
+ &settings,
+ PathBuf::from("/tmp/window-filter-desktop-test"),
+ None,
+ );
+ assert_eq!(config.ignored_windows, settings.ignored_windows);
+ assert_eq!(config.included_windows, settings.included_windows);
+ let ui = config.to_ui_recorder_config();
+ assert_eq!(ui.excluded_windows, settings.ignored_windows);
+ assert_eq!(ui.included_windows, settings.included_windows);
+ let filters = WindowFilters::new(&config.ignored_windows, &config.included_windows, &[]);
+ assert!(!filters.is_valid("Cursor", "Project"));
+ }
+
#[test]
fn test_incognito_flags_default_to_basic_filtering() {
let cli = Cli::try_parse_from(["screenpipe", "record"]).unwrap();
diff --git a/packages/sdk/Cargo.lock b/packages/sdk/Cargo.lock
index 82da826c6..088d11807 100644
--- a/packages/sdk/Cargo.lock
+++ b/packages/sdk/Cargo.lock
@@ -6888,7 +6888,7 @@ dependencies = [
[[package]]
name = "screenpipe-config"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"dirs 6.0.0",
"screenpipe-cpu-features",
@@ -6900,7 +6900,7 @@ dependencies = [
[[package]]
name = "screenpipe-connect"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"async-imap",
@@ -6947,7 +6947,7 @@ dependencies = [
[[package]]
name = "screenpipe-core"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility",
"accessibility-sys",
@@ -6992,11 +6992,11 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.56"
+version = "0.4.57"
[[package]]
name = "screenpipe-db"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -7035,7 +7035,7 @@ dependencies = [
[[package]]
name = "screenpipe-events"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -7051,7 +7051,7 @@ dependencies = [
[[package]]
name = "screenpipe-fs"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"libc",
]
@@ -7080,7 +7080,7 @@ dependencies = [
[[package]]
name = "screenpipe-resource"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"sysinfo",
@@ -7089,7 +7089,7 @@ dependencies = [
[[package]]
name = "screenpipe-screen"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility-sys",
"anyhow",
@@ -7169,7 +7169,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-coordinator"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"fs2",
"libsqlite3-sys",
@@ -7200,7 +7200,7 @@ dependencies = [
[[package]]
name = "screenpipe-vault"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"argon2 0.5.3",
"chacha20poly1305",
diff --git a/packages/sdk/examples/tauri-app/src-tauri/Cargo.lock b/packages/sdk/examples/tauri-app/src-tauri/Cargo.lock
index 1a6c428a0..c757604b3 100644
--- a/packages/sdk/examples/tauri-app/src-tauri/Cargo.lock
+++ b/packages/sdk/examples/tauri-app/src-tauri/Cargo.lock
@@ -7014,7 +7014,7 @@ dependencies = [
[[package]]
name = "screenpipe-config"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"dirs 6.0.0",
"screenpipe-cpu-features",
@@ -7026,7 +7026,7 @@ dependencies = [
[[package]]
name = "screenpipe-connect"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"async-imap",
@@ -7073,7 +7073,7 @@ dependencies = [
[[package]]
name = "screenpipe-core"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility",
"accessibility-sys",
@@ -7118,11 +7118,11 @@ dependencies = [
[[package]]
name = "screenpipe-cpu-features"
-version = "0.4.56"
+version = "0.4.57"
[[package]]
name = "screenpipe-db"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -7161,7 +7161,7 @@ dependencies = [
[[package]]
name = "screenpipe-events"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"anyhow",
"chrono",
@@ -7177,7 +7177,7 @@ dependencies = [
[[package]]
name = "screenpipe-fs"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"libc",
]
@@ -7204,7 +7204,7 @@ dependencies = [
[[package]]
name = "screenpipe-resource"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"serde",
"sysinfo",
@@ -7213,7 +7213,7 @@ dependencies = [
[[package]]
name = "screenpipe-screen"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"accessibility-sys",
"anyhow",
@@ -7282,7 +7282,7 @@ dependencies = [
[[package]]
name = "screenpipe-sqlite-coordinator"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"fs2",
"libsqlite3-sys",
@@ -7321,7 +7321,7 @@ dependencies = [
[[package]]
name = "screenpipe-vault"
-version = "0.4.56"
+version = "0.4.57"
dependencies = [
"argon2 0.5.3",
"chacha20poly1305",