YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(pipes): keep connections optional (#6472)
Ezra Elletted6be0de37ae3
diff --git a/crates/screenpipe-core/src/pipes/mod.rs b/crates/screenpipe-core/src/pipes/mod.rsindex 1db407ebf..a21f254f0 100644--- a/crates/screenpipe-core/src/pipes/mod.rs+++ b/crates/screenpipe-core/src/pipes/mod.rs@@ -2305,19 +2305,6 @@ fn emit_pipe_start(callback(pipe_name, execution_id, continues_chat, &event);}-/// Async predicate: given a pipe's required connections, return the-/// subset that is NOT yet configured (`enabled && credentials present`).-/// Returning an empty vec means "all connections are ready, pipe may run".-///-/// Injected from the engine layer (which owns the SecretStore + screenpipe-/// dir) to keep the scheduler in `screenpipe-core` free of a-/// `screenpipe-connect` dep — that crate already depends on us.-pub type ConnectionCheck = Arc<- dyn Fn(Vec<String>) -> std::pin::Pin<Box<dyn std::future::Future<Output = Vec<String>> + Send>>- + Send- + Sync,->;-/// Default execution timeout: 10 minutes.pub(crate) const DEFAULT_TIMEOUT_SECS: u64 = 600;@@ -2450,10 +2437,6 @@ pub struct PipeManager {on_run_complete: Option<OnPipeRunComplete>,/// Optional callback fired for each stdout line from a running pipe.on_output_line: Option<OnPipeOutputLine>,- /// Optional async predicate that returns the missing connections for a- /// pipe. If set, the scheduler skips any enabled pipe whose required- /// connections aren't all configured ("setup mode").- connection_check: Option<ConnectionCheck>,/// Optional persistence store (None in CLI mode).store: Option<Arc<dyn PipeStore>>,/// API port for prompt rendering (default 3030).@@ -2509,7 +2492,6 @@ impl PipeManager {scheduler_generation: Arc::new(std::sync::atomic::AtomicU64::new(0)),on_run_complete: None,on_output_line: None,- connection_check: None,store,api_port,max_non_template_pipes: None,@@ -2623,14 +2605,6 @@ impl PipeManager {self.on_run_complete = Some(cb);}- /// Set the async predicate used to gate scheduled runs on connection- /// readiness. Without this, pipes "in setup mode" (enabled but missing- /// required integrations) would still tick on their cron / event- /// trigger and run with broken credentials.- pub fn set_connection_check(&mut self, cb: ConnectionCheck) {- self.connection_check = Some(cb);- }-/// Set a callback to be invoked for each stdout line from a running pipe./// Resolves a named AI preset (provider, model, base url, key) from the/// user's own store. Exposed so the local HTTP surface can serve plain chat@@ -5172,7 +5146,6 @@ impl PipeManager {let pipes_dir = self.pipes_dir.clone();let on_run_complete = self.on_run_complete.clone();let on_output_line = self.on_output_line.clone();- let connection_check = self.connection_check.clone();let store = self.store.clone();let api_port = self.api_port;let token_registry = self.token_registry.clone();@@ -5559,91 +5532,6 @@ impl PipeManager {}}- // Setup-mode gate: pipes whose declared `connections` aren't- // all configured (credentials or OAuth token present) must not- // run on schedule or event. Mirrors the manual-run gate in- // pipes_api::run_pipe_now. Placed after the schedule/queue- // checks so we only hit the SecretStore when the pipe would- // otherwise be about to start.- if !config.connections.is_empty() {- if let Some(check) = &connection_check {- let missing = check(config.connections.clone()).await;- if !missing.is_empty() {- let skipped_at = Utc::now();- let message = format!(- "pipe '{}' skipped: missing required connections: {}",- name,- missing.join(", ")- );- warn!(- "scheduler: pipe '{}' in setup mode (missing connections: {:?}), skipping",- name, missing- );- last_run.insert(name.clone(), skipped_at);- let mut execution_id = None;- if let Some(ref store) = store {- match store- .create_execution(- name,- trigger,- &config.model,- config.provider.as_deref(),- )- .await- {- Ok(id) => {- execution_id = Some(id);- let _ = store- .finish_execution(- id,- "failed",- "",- &message,- None,- Some("missing_connections"),- Some(&message),- None,- )- .await;- }- Err(e) => {- warn!("failed to create skipped execution row: {}", e);- }- }- let _ = store.upsert_scheduler_state(name, false).await;- }- {- let mut logs_guard = logs.lock().await;- let entry = logs_guard- .entry(name.clone())- .or_insert_with(VecDeque::new);- entry.push_front(PipeRunLog {- pipe_name: name.clone(),- started_at: skipped_at,- finished_at: skipped_at,- success: false,- stdout: String::new(),- stderr: message.clone(),- });- if entry.len() > PIPE_LOG_ACTIVE_KEEP_PER_PIPE {- entry.pop_back();- }- }- if let Some(ref cb) = on_run_complete {- cb(- name,- execution_id,- trigger,- false,- 0.0,- Some("missing_connections"),- );- }- continue;- }- }- }-// Defense-in-depth: check PID file (survives crashes)if let Some(existing_pid) = read_pid_file(&pipes_dir, name) {if is_process_alive(existing_pid) {diff --git a/crates/screenpipe-engine/src/bin/screenpipe-engine.rs b/crates/screenpipe-engine/src/bin/screenpipe-engine.rsindex 917483834..4aa8cbb72 100644--- a/crates/screenpipe-engine/src/bin/screenpipe-engine.rs+++ b/crates/screenpipe-engine/src/bin/screenpipe-engine.rs@@ -1486,20 +1486,6 @@ async fn main() -> anyhow::Result<()> {analytics::capture_event_nonblocking("pipe_scheduled_run", props);},));- // Gate scheduled pipe runs on connection readiness — same predicate the- // manual /pipes/:id/run endpoint uses (pipes_api.rs). Avoids running- // pipes that are still in "setup mode" (declared connections not paired).- {- let secret_store_for_check = server.secret_store.clone();- let screenpipe_dir_for_check = local_data_dir.clone();- pipe_manager.set_connection_check(std::sync::Arc::new(move |required| {- let ss = secret_store_for_check.clone();- let dir = screenpipe_dir_for_check.clone();- Box::pin(async move {- screenpipe_connect::missing_pipe_connections(ss.as_deref(), &dir, &required).await- })- }));- }// Give scheduled runs the same Live View target authority the foreground// refresh button sends, so a Pipe feeding several dashboards refreshes all// of them instead of leaving the ones it skipped stale until a manual click.diff --git a/crates/screenpipe-engine/src/pipes_api.rs b/crates/screenpipe-engine/src/pipes_api.rsindex 20f776691..73cfe58d8 100644--- a/crates/screenpipe-engine/src/pipes_api.rs+++ b/crates/screenpipe-engine/src/pipes_api.rs@@ -300,36 +300,6 @@ pub async fn run_pipe_now(.map(format_run_context)};- // Validate required connections are configured before running the pipe- let required_connections = mgr- .get_pipe(&id)- .await- .map(|pipe_status| pipe_status.config.connections)- .unwrap_or_default();- if !required_connections.is_empty() {- let screenpipe_dir = mgr- .pipes_dir()- .parent()- .unwrap_or(mgr.pipes_dir())- .to_path_buf();- let ss = secret_store.as_ref().map(|e| e.0.as_ref());- let missing = screenpipe_connect::missing_pipe_connections(- ss,- &screenpipe_dir,- &required_connections,- )- .await;- if !missing.is_empty() {- return Json(json!({- "error": format!(- "pipe '{}' requires unconfigured connections: {} — set them up from the Connections page in the desktop app",- id,- missing.join(", ")- )- }));- }- }-// Refresh connections context so the pipe system prompt includes currently// connected integrations (Google Calendar, Google Docs, MCP servers, etc.).let screenpipe_dir = mgr