Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(pipes): match owner tag format with frontend pipeSessionId() (#4137)

Harsh Kumard8017eef85ff
diff --git a/crates/screenpipe-core/src/agents/pi.rs b/crates/screenpipe-core/src/agents/pi.rs
index 32917f81e..e861c45f9 100644
--- a/crates/screenpipe-core/src/agents/pi.rs
+++ b/crates/screenpipe-core/src/agents/pi.rs
@@ -1352,7 +1352,8 @@ impl PiExecutor {
cmd.env("SCREENPIPE_SESSION_ID", owner);
// Expose the bare pipe name for extensions (e.g. register-artifact)
// that need it without the "pipe:" routing prefix.
- if let Some(name) = owner.strip_prefix("pipe:") {
+ if let Some(rest) = owner.strip_prefix("pipe:") {
+ let name = rest.rsplit_once(':').map_or(rest, |(n, _)| n);
cmd.env("SCREENPIPE_PIPE_NAME", name);
}
}
diff --git a/crates/screenpipe-core/src/pipes/mod.rs b/crates/screenpipe-core/src/pipes/mod.rs
index 2feab7930..f9d1fac87 100644
--- a/crates/screenpipe-core/src/pipes/mod.rs
+++ b/crates/screenpipe-core/src/pipes/mod.rs
@@ -2219,7 +2219,7 @@ impl PipeManager {
});
let mcp_server_allowlist = selected_mcp_server_ids(&config);
- let session_owner = format!("pipe:{pipe_name}");
+ let session_owner = format!("pipe:{pipe_name}:{}", exec_id.unwrap_or(0));
if let Some(ref registry) = mcp_session_access {
if mcp_server_allowlist.is_empty() {
registry.clear_session(&session_owner).await;
@@ -2243,10 +2243,10 @@ impl PipeManager {
history_enabled,
Some(&pipe_system_prompt),
mcp_allowlist_arg(&mcp_server_allowlist),
- // Owner tag: a pipe's owned-browser navigations are
- // `pipe:<name>`, which never matches an open chat's
- // conversationId, so they stay out of whatever chat is on
- // screen. See screenpipe-core::agents::bash_env.
+ // Owner tag: must match the frontend's pipeSessionId()
+ // format (`pipe:<name>:<execId>`) so the owned-browser
+ // sidebar shows navigations when the user is watching this
+ // pipe.
Some(session_owner.as_str()),
),
)
@@ -2727,7 +2727,7 @@ impl PipeManager {
});
let mcp_server_allowlist = selected_mcp_server_ids(&config);
- let session_owner = format!("pipe:{name}");
+ let session_owner = format!("pipe:{name}:{}", exec_id.unwrap_or(0));
if let Some(ref registry) = self.mcp_session_access {
if mcp_server_allowlist.is_empty() {
registry.clear_session(&session_owner).await;
@@ -2751,10 +2751,10 @@ impl PipeManager {
history_enabled,
Some(&pipe_system_prompt),
mcp_allowlist_arg(&mcp_server_allowlist),
- // Owner tag: a pipe's owned-browser navigations are
- // `pipe:<name>`, which never matches an open chat's
- // conversationId, so they stay out of whatever chat is on
- // screen. See screenpipe-core::agents::bash_env.
+ // Owner tag: must match the frontend's pipeSessionId()
+ // format (`pipe:<name>:<execId>`) so the owned-browser
+ // sidebar shows navigations when the user is watching this
+ // pipe.
Some(session_owner.as_str()),
),
)
@@ -3984,7 +3984,7 @@ impl PipeManager {
}
});
- let session_owner = format!("pipe:{pipe_name}");
+ let session_owner = format!("pipe:{pipe_name}:{}", exec_id.unwrap_or(0));
if let Some(ref registry) = mcp_session_access_ref {
if mcp_server_allowlist.is_empty() {
registry.clear_session(&session_owner).await;
@@ -4011,7 +4011,8 @@ impl PipeManager {
history_enabled,
Some(&pipe_system_prompt),
mcp_allowlist_arg(&mcp_server_allowlist),
- // Owner tag — see run_pipe_with_trigger.
+ // Owner tag — must match pipeSessionId() on the
+ // frontend. See run_pipe_with_trigger.
Some(session_owner.as_str()),
),
)