Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(cli): preserve MSVC native library layout with Ninja (#7400)

Louis Beaumontde0276667e27
diff --git a/.github/scripts/release-workflows.test.ts b/.github/scripts/release-workflows.test.ts
index efb3678df..f7cdaa931 100644
--- a/.github/scripts/release-workflows.test.ts
+++ b/.github/scripts/release-workflows.test.ts
@@ -118,6 +118,8 @@ test("Windows CLI compiles through the short target path without moving smoke pr
const job = readYaml(".github/workflows/release-cli.yml").jobs["build-windows"];
const build = job.steps.find((step: any) => step.name === "Build CLI");
expect(build.env.CARGO_TARGET_DIR).toBe("C:/t");
+ expect(build.env.CMAKE_GENERATOR).toBe("Ninja Multi-Config");
+ expect(build.env.CMAKE_CONFIGURATION_TYPES.split(";")).toEqual(["Debug", "Release", "RelWithDebInfo", "MinSizeRel"]);
const junction = job.steps.find((step: any) => step.name === "Shorten target dir to avoid MAX_PATH");
expect(junction.run).toContain('$shortDir = "C:\\t"');
expect(junction.run).toContain("mklink /J $targetDir $shortDir");
diff --git a/.github/workflows/release-cli.yml b/.github/workflows/release-cli.yml
index 6d584d16d..2a5dc5a5a 100644
--- a/.github/workflows/release-cli.yml
+++ b/.github/workflows/release-cli.yml
@@ -392,6 +392,10 @@ jobs:
# Cargo must pass the short path to CMake; the target junction alone
# leaves nested Vulkan compiler probes using the long checkout path.
CARGO_TARGET_DIR: "C:/t"
+ # libsamplerate-sys searches build/<profile> on MSVC. Multi-config
+ # Ninja preserves that layout; opt-level="s" requires MinSizeRel.
+ CMAKE_GENERATOR: "Ninja Multi-Config"
+ CMAKE_CONFIGURATION_TYPES: "Debug;Release;RelWithDebInfo;MinSizeRel"
CARGO_PROFILE_RELEASE_STRIP: "none"
CARGO_PROFILE_RELEASE_PANIC: "abort"
CARGO_PROFILE_RELEASE_INCREMENTAL: "false"