YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(activity): retry intermittent app icon loads (#6480)
Ezra Ellettee0f61dc7acce
diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsxindex 23e57464e..74299cc1f 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.test.tsx@@ -1493,6 +1493,55 @@ describe("ActivityLedger", () => {);});+ it("retries app icons with bounded exponential backoff", async () => {+ render(<ActivityLedger />);+ await generateActivities();+ await screen.findByText("Fixed a capture reliability regression");++ const appArtifact = screen.getByRole("link", {+ name: /Open Arc at .* in Timeline/,+ });+ await waitFor(() =>+ expect(appArtifact.querySelector("img")).not.toBeNull(),+ );++ fireEvent.error(appArtifact.querySelector("img")!);+ expect(appArtifact.querySelector("img")).toBeNull();++ await act(async () => vi.advanceTimersByTime(499));+ expect(appArtifact.querySelector("img")).toBeNull();+ await act(async () => vi.advanceTimersByTime(1));+ expect(appArtifact.querySelector("img")).toHaveAttribute(+ "src",+ "http://localhost:11535/app-icon?name=Arc&retry=1",+ );++ fireEvent.error(appArtifact.querySelector("img")!);+ await act(async () => vi.advanceTimersByTime(999));+ expect(appArtifact.querySelector("img")).toBeNull();+ await act(async () => vi.advanceTimersByTime(1));+ expect(appArtifact.querySelector("img")).toHaveAttribute(+ "src",+ "http://localhost:11535/app-icon?name=Arc&retry=2",+ );++ for (const [delay, attempt] of [+ [2_000, 3],+ [4_000, 4],+ ] as const) {+ fireEvent.error(appArtifact.querySelector("img")!);+ await act(async () => vi.advanceTimersByTime(delay));+ expect(appArtifact.querySelector("img")).toHaveAttribute(+ "src",+ `http://localhost:11535/app-icon?name=Arc&retry=${attempt}`,+ );+ }++ fireEvent.error(appArtifact.querySelector("img")!);+ await act(async () => vi.advanceTimersByTime(10_000));+ expect(appArtifact.querySelector("img")).toBeNull();+ });+it("opens meeting artifacts in the matching meeting's best view", async () => {mocks.localFetch.mockImplementation((path: string) =>Promise.resolve({diff --git a/apps/screenpipe-app-tauri/components/activity-ledger.tsx b/apps/screenpipe-app-tauri/components/activity-ledger.tsxindex 4abdb7b99..552c96e2f 100644--- a/apps/screenpipe-app-tauri/components/activity-ledger.tsx+++ b/apps/screenpipe-app-tauri/components/activity-ledger.tsx@@ -76,6 +76,8 @@ type MeetingResponse = {};type TimeRange = { start: Date; end: Date };+const APP_ICON_RETRY_DELAYS_MS = [500, 1_000, 2_000, 4_000] as const;+function historyDocumentFromNative(entries: unknown[],): ActivityHistoryDocument | null {@@ -563,8 +565,23 @@ function EvidenceArtifactIcon({ evidence }: { evidence: ActivityArtifact }) {stage: "exact" | "root" | "failed";}>({ domain: null, stage: "exact" });const [appServerBaseUrl, setAppServerBaseUrl] = useState<string | null>(null);+ const [appIconAttempt, setAppIconAttempt] = useState<{+ appName: string | null;+ attempt: number;+ waiting: boolean;+ failed: boolean;+ }>({ appName: null, attempt: 0, waiting: false, failed: false });const domain = siteDomain(evidence.browser_url);const iconStage = iconAttempt.domain === domain ? iconAttempt.stage : "exact";+ const currentAppIconAttempt =+ appIconAttempt.appName === evidence.app_name+ ? appIconAttempt+ : {+ appName: evidence.app_name,+ attempt: 0,+ waiting: false,+ failed: false,+ };const rootDomain = domain ? getRootDomain(domain) : null;const faviconDomain = iconStage === "root" ? rootDomain : domain;@@ -579,6 +596,25 @@ function EvidenceArtifactIcon({ evidence }: { evidence: ActivityArtifact }) {};}, [domain, evidence.app_name]);+ useEffect(() => {+ if (!currentAppIconAttempt.waiting) return;+ const retryDelay = APP_ICON_RETRY_DELAYS_MS[currentAppIconAttempt.attempt];+ if (retryDelay === undefined) return;+ const timeout = window.setTimeout(() => {+ setAppIconAttempt({+ appName: evidence.app_name,+ attempt: currentAppIconAttempt.attempt + 1,+ waiting: false,+ failed: false,+ });+ }, retryDelay);+ return () => window.clearTimeout(timeout);+ }, [+ currentAppIconAttempt.attempt,+ currentAppIconAttempt.waiting,+ evidence.app_name,+ ]);+if (evidence.kind === "meeting") {return <Users className="h-4 w-4" aria-hidden="true" />;}@@ -598,13 +634,41 @@ function EvidenceArtifactIcon({ evidence }: { evidence: ActivityArtifact }) {/>);}- if (evidence.app_name && appServerBaseUrl && iconStage !== "failed") {+ if (+ evidence.app_name &&+ appServerBaseUrl &&+ iconStage !== "failed" &&+ !currentAppIconAttempt.waiting &&+ !currentAppIconAttempt.failed+ ) {+ const retrySuffix =+ currentAppIconAttempt.attempt > 0+ ? `&retry=${currentAppIconAttempt.attempt}`+ : "";return (<img- src={`${appServerBaseUrl}/app-icon?name=${encodeURIComponent(evidence.app_name)}`}+ src={`${appServerBaseUrl}/app-icon?name=${encodeURIComponent(+ evidence.app_name,+ )}${retrySuffix}`}alt=""className="h-full w-full object-contain"- onError={() => setIconAttempt({ domain: null, stage: "failed" })}+ onError={() => {+ if (currentAppIconAttempt.attempt < APP_ICON_RETRY_DELAYS_MS.length) {+ setAppIconAttempt({+ appName: evidence.app_name,+ attempt: currentAppIconAttempt.attempt,+ waiting: true,+ failed: false,+ });+ return;+ }+ setAppIconAttempt({+ appName: evidence.app_name,+ attempt: currentAppIconAttempt.attempt,+ waiting: false,+ failed: true,+ });+ }}/>);}