Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

style: cargo fmt + cfg-gate PARAKEET_MIN_MACOS_MAJOR off-macOS

Ezra Ellettee6c1badfc802
diff --git a/crates/screenpipe-audio/src/core/engine.rs b/crates/screenpipe-audio/src/core/engine.rs
index ac24db579..290c7d616 100644
--- a/crates/screenpipe-audio/src/core/engine.rs
+++ b/crates/screenpipe-audio/src/core/engine.rs
@@ -33,7 +33,7 @@ impl AudioTranscriptionEngine {
Self::Qwen3Asr => true,
Self::Deepgram | Self::OpenAICompatible | Self::Disabled => false,
Self::Parakeet | Self::ParakeetMlx => false, // ONNX Runtime: runtime CPU dispatch
- _ => true, // all Whisper variants (ggml)
+ _ => true, // all Whisper variants (ggml)
}
}
}
diff --git a/crates/screenpipe-config/src/defaults.rs b/crates/screenpipe-config/src/defaults.rs
index b9c44f366..c9d42f1f8 100644
--- a/crates/screenpipe-config/src/defaults.rs
+++ b/crates/screenpipe-config/src/defaults.rs
@@ -10,6 +10,8 @@ use sysinfo::{System, SystemExt};
/// Minimum macOS major version required for parakeet-mlx (Metal GPU).
/// macOS 26 (Tahoe) is required for the MLX framework APIs used by parakeet.
/// On older macOS versions, the model loading segfaults during Metal buffer allocation.
+/// (cfg-gated: since the AVX2-aware refactor its only uses live in macOS-only blocks.)
+#[cfg(target_os = "macos")]
const PARAKEET_MIN_MACOS_MAJOR: u32 = 26;
/// Device performance tier, determined by hardware detection.
@@ -511,11 +513,23 @@ mod tests {
DeviceTier::High,
false
));
- assert!(is_engine_unsafe_for_cpu("qwen3-asr", DeviceTier::High, false));
+ assert!(is_engine_unsafe_for_cpu(
+ "qwen3-asr",
+ DeviceTier::High,
+ false
+ ));
// parakeet is ONNX (runtime-dispatched MS DLL) — safe without AVX2 off-macOS
- assert!(!is_engine_unsafe_for_cpu("parakeet", DeviceTier::High, false));
+ assert!(!is_engine_unsafe_for_cpu(
+ "parakeet",
+ DeviceTier::High,
+ false
+ ));
// with AVX2 everything keeps its existing verdicts
- assert!(!is_engine_unsafe_for_cpu("whisper-tiny", DeviceTier::High, true));
+ assert!(!is_engine_unsafe_for_cpu(
+ "whisper-tiny",
+ DeviceTier::High,
+ true
+ ));
}
#[cfg(all(target_arch = "x86_64", not(target_os = "macos")))]
diff --git a/crates/screenpipe-core/src/agents/pi.rs b/crates/screenpipe-core/src/agents/pi.rs
index bcb767958..ddc2e87f1 100644
--- a/crates/screenpipe-core/src/agents/pi.rs
+++ b/crates/screenpipe-core/src/agents/pi.rs
@@ -3165,9 +3165,7 @@ fn download_baseline_bun() -> std::result::Result<String, String> {
if !extracted_dir.join("bun.exe").exists() {
let _ = std::fs::remove_dir_all(&extract_temp);
let _ = std::fs::remove_file(&temp_file);
- return Err(
- "Extraction completed but bun.exe not found in expected location".to_string(),
- );
+ return Err("Extraction completed but bun.exe not found in expected location".to_string());
}
// Atomic rename: move extracted dir to final location