YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(audio): clippy cleanups — example doc dedent + drop stale dead_code allows
Ezra Ellettef46c5ada17dd
diff --git a/crates/screenpipe-audio/examples/meeting_input_probe.rs b/crates/screenpipe-audio/examples/meeting_input_probe.rsindex 79ea187f0..f84b5619b 100644--- a/crates/screenpipe-audio/examples/meeting_input_probe.rs+++ b/crates/screenpipe-audio/examples/meeting_input_probe.rs@@ -20,7 +20,7 @@//! 3. Talk — the `level [████…]` meter should move with YOUR voice.//! 4. While it runs, change the mic the app uses (system input device, or in//! Zoom/Teams audio settings). You should see:-//! "input device changed: [old] -> [new], switching"+//! "input device changed: [old] -> [new], switching"//! and a "now recording: <new device>" line, then the meter keeps moving.//! 5. Ctrl-C to stop.diff --git a/crates/screenpipe-audio/examples/meeting_tap_probe.rs b/crates/screenpipe-audio/examples/meeting_tap_probe.rsindex 6e1317147..82ecfa8e3 100644--- a/crates/screenpipe-audio/examples/meeting_tap_probe.rs+++ b/crates/screenpipe-audio/examples/meeting_tap_probe.rs@@ -21,7 +21,7 @@//! 3. Talk / have the other side talk — the meter should move with THEIR audio.//! 4. While it runs, switch your output device (Speakers <-> headset).//! macOS should keep moving and log:-//! "Per-process tap: app output changed (... -> ...), rebuilding"+//! "Per-process tap: app output changed (... -> ...), rebuilding"//! Windows build 20348+ should keep moving without an endpoint rebuild.//! 5. Ctrl-C to stop.diff --git a/crates/screenpipe-audio/src/core/process_tap/macos.rs b/crates/screenpipe-audio/src/core/process_tap/macos.rsindex 2b64a28cb..5154f4190 100644--- a/crates/screenpipe-audio/src/core/process_tap/macos.rs+++ b/crates/screenpipe-audio/src/core/process_tap/macos.rs@@ -612,7 +612,6 @@ impl Drop for ProcessTapCapture {/// Translate OS pids into CoreAudio process object AudioObjectIDs, dropping any/// that don't resolve (not running, or not a translatable process).-#[allow(dead_code)] // wired into the live pipeline in the reconcile follow-upfn resolve_pids_to_audio_object_ids(pids: &[i32]) -> Vec<u32> {let mut out = Vec::new();for &pid in pids {@@ -652,7 +651,6 @@ fn aggregate_output_activity(pids: &[i32]) -> Option<bool> {/// using ("copy whatever output the app is using"). Queries `PROCESS_DEVICES`/// in the OUTPUT scope and returns the first output device across the pids./// `None` when nothing resolves — the caller falls back to the default output.-#[allow(dead_code)] // wired into the live pipeline in the reconcile follow-upfn resolve_meeting_output_device(pids: &[i32]) -> Option<ca::Device> {for &pid in pids {let Ok(process) = ca::Process::with_pid(pid) else {@@ -679,7 +677,6 @@ fn resolve_meeting_output_device(pids: &[i32]) -> Option<ca::Device> {/// Reuses `build_capture_from_desc`, so the aggregate/IO-proc plumbing is/// identical to the stable global tap; only WHAT we tap and WHICH device we/// clock against differ.-#[allow(dead_code)] // wired into the live pipeline in the reconcile follow-upfn build_inclusion_capture(pids: &[i32],tx: broadcast::Sender<Vec<f32>>,@@ -1213,7 +1210,6 @@ pub fn spawn_process_tap_capture(////// `is_running` is accepted for signature parity with the cpal path and is not/// read (see the `TapCallbackCtx` comment).-#[allow(dead_code)] // wired into the live pipeline in the reconcile follow-uppub fn spawn_process_tap_capture_for_pids(pids: Vec<i32>,tx: broadcast::Sender<Vec<f32>>,