YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(meeting-notes): block Signal voice note phantom meetings via bundle gate
thisisharsh7fe5cbc2da9fb
diff --git a/crates/screenpipe-engine/src/meeting_watcher/audio_process/resolve.rs b/crates/screenpipe-engine/src/meeting_watcher/audio_process/resolve.rsindex 12c902792..3ae6c02c7 100644--- a/crates/screenpipe-engine/src/meeting_watcher/audio_process/resolve.rs+++ b/crates/screenpipe-engine/src/meeting_watcher/audio_process/resolve.rs@@ -247,6 +247,26 @@ pub(crate) fn resolve_process_candidate(}if let Some((platform, profile_index)) = resolve_native_platform(process, profiles) {+ // Signal voice note gate (#4776): Signal is an Electron app whose AX+ // tree is opaque, so we can't scan for call UI. Instead we use the+ // process bundle ID: voice notes use the `.helper` subprocess while+ // real calls use `.helper.Renderer`. If the bundle doesn't contain+ // "renderer", it's a voice note — block it.+ if platform == "Signal" {+ let bundle = process+ .bundle_id+ .as_deref()+ .or(process.owner_bundle_id.as_deref())+ .unwrap_or("");+ if !bundle.to_lowercase().contains("renderer") {+ debug!(+ "audio-process meeting detector: Signal blocked — voice note helper \+ (bundle={:?}, no .Renderer suffix)",+ bundle+ );+ return ResolvedMeetingCandidate::NonMeeting;+ }+ }let profile = profile_index.and_then(|idx| profiles.get(idx));if candidate_is_ignored(&platform, profile, process, ignored_terms, None, None, None) {return ResolvedMeetingCandidate::Ignored;@@ -391,9 +411,15 @@ pub(crate) fn known_native_bundle_platform(field_lower: &str) -> Option<&'staticif field_lower.contains("discord") {return Some("Discord");}- // Signal, WhatsApp, and Telegram are intentionally NOT matched here.- // They must fall through to the profile-matching loop below so they get- // a profile index, which is needed to check `requires_call_signal` (#4776).+ // Signal is kept here (not gated) because its Electron AX tree is opaque+ // — we can't distinguish calls from voice notes, so requires_call_signal+ // is false and it doesn't need a profile index for the gate (#4776).+ if field_lower.contains("signal") {+ return Some("Signal");+ }+ // WhatsApp and Telegram are intentionally NOT matched here. They must+ // fall through to the profile-matching loop below so they get a profile+ // index, which is needed to check `requires_call_signal` (#4776).if field_lower.contains("skype") {return Some("Skype");}diff --git a/crates/screenpipe-engine/src/meeting_watcher/audio_process/tests.rs b/crates/screenpipe-engine/src/meeting_watcher/audio_process/tests.rsindex 483c24fdf..875e13747 100644--- a/crates/screenpipe-engine/src/meeting_watcher/audio_process/tests.rs+++ b/crates/screenpipe-engine/src/meeting_watcher/audio_process/tests.rs@@ -1088,15 +1088,30 @@ fn whatsapp_process() -> AudioInputProcess {}}+/// Signal call: uses the .helper.Renderer subprocess (real WebRTC call).fn signal_process() -> AudioInputProcess {AudioInputProcess {- audio_session_id: Some("coreaudio-process:600:input:built-in-mic".to_string()),- audio_object_id: Some(600),- pid: Some(101),- bundle_id: Some("org.whispersystems.signal-desktop".to_string()),- process_name: Some("Signal".to_string()),- owner_app_name: Some("Signal".to_string()),- owner_bundle_id: Some("org.whispersystems.signal-desktop".to_string()),+ audio_session_id: Some("coreaudio-process:115:input:BuiltInMicrophoneDevice".to_string()),+ audio_object_id: Some(115),+ pid: Some(63225),+ bundle_id: Some("org.whispersystems.signal-desktop.helper.Renderer".to_string()),+ process_name: None,+ owner_app_name: None,+ owner_bundle_id: None,+ first_seen_at_ms: None,+ }+}++/// Signal voice note: uses the .helper subprocess (no .Renderer suffix).+fn signal_voice_note_process() -> AudioInputProcess {+ AudioInputProcess {+ audio_session_id: Some("coreaudio-process:116:input:BuiltInMicrophoneDevice".to_string()),+ audio_object_id: Some(116),+ pid: Some(63247),+ bundle_id: Some("org.whispersystems.signal-desktop.helper".to_string()),+ process_name: None,+ owner_app_name: None,+ owner_bundle_id: None,first_seen_at_ms: None,}}@@ -1152,23 +1167,65 @@ fn whatsapp_resolves_to_native_with_profile_index() {}#[test]-fn signal_resolves_to_native_with_profile_index() {+fn signal_resolves_to_native_without_gate() {let profiles = load_detection_profiles();let process = signal_process();let result = resolve_native_platform(&process, &profiles);assert!(result.is_some(), "Signal should resolve as native");let (platform, profile_index) = result.unwrap();assert_eq!(platform, "Signal");+ // Signal resolves via known_native_bundle_platform (no profile index)+ // because its Electron AX tree is opaque — requires_call_signal is+ // false and the gate is not needed.assert!(- profile_index.is_some(),- "Signal must have a profile index for call signal gating"+ profile_index.is_none(),+ "Signal should resolve via known_native_bundle_platform, not profile loop"+ );+}++#[test]+fn signal_voice_note_blocked_by_renderer_gate() {+ // Signal voice notes use the .helper subprocess (no .Renderer suffix).+ // The bundle-based gate should block them as NonMeeting.+ let profiles = load_detection_profiles();+ let process = signal_voice_note_process();+ let session_key = ProcessKey::from_process(&process).unwrap();+ let result = resolve_process_candidate(+ session_key,+ Instant::now(),+ &process,+ &profiles,+ &[],+ &[],+ &[],+ );+ assert!(+ matches!(result, ResolvedMeetingCandidate::NonMeeting),+ "Signal voice note (.helper) should be blocked: got {:?}",+ result+ );+}++#[test]+fn signal_call_passes_renderer_gate() {+ // Signal calls use the .helper.Renderer subprocess.+ // The bundle-based gate should allow them as Native.+ let profiles = load_detection_profiles();+ let process = signal_process();+ let session_key = ProcessKey::from_process(&process).unwrap();+ let result = resolve_process_candidate(+ session_key,+ Instant::now(),+ &process,+ &profiles,+ &[],+ &[],+ &[],);- // Signal's Electron AX tree is opaque (buttons show title="-"), so- // requires_call_signal is false until Signal exposes call UI.- let profile = &profiles[profile_index.unwrap()];assert!(- !profile.requires_call_signal,- "Signal profile must have requires_call_signal = false (opaque AX tree)"+ matches!(result, ResolvedMeetingCandidate::Native { ref platform, .. } if platform == "Signal"),+ "Signal call (.helper.Renderer) should resolve as Native Signal: got {:?}",+ result);}