Drop in a screenshot and convert it to clean code (HTML/Tailwind/React/Vue)
Python
Show total generation time for completed variants
Flightdeck Agent4f78a5acd46d
diff --git a/frontend/src/components/agent/AgentActivity.tsx b/frontend/src/components/agent/AgentActivity.tsxindex cfc63c9e..6232ef1f 100644--- a/frontend/src/components/agent/AgentActivity.tsx+++ b/frontend/src/components/agent/AgentActivity.tsx@@ -26,6 +26,10 @@ import html from "react-syntax-highlighter/dist/esm/languages/hljs/xml";import { vs2015 } from "react-syntax-highlighter/dist/esm/styles/hljs";import WorkingPulse from "../core/WorkingPulse";import { groupCompletedAgentEvents } from "./activity-order";+import {+ formatDurationBetween,+ isTerminalVariantStatus,+} from "./generation-time";SyntaxHighlighterBase.registerLanguage("html", html);const SyntaxHighlighter = SyntaxHighlighterBase as any;@@ -104,29 +108,12 @@ function CodePreviewBlock({ code, isGenerating }: { code: string; isGenerating:);}-function isFiniteNumber(value: unknown): value is number {- return typeof value === "number" && Number.isFinite(value);-}--function formatDurationMs(milliseconds: number): string {- const seconds = Math.max(1, Math.round(milliseconds / 1000));- if (seconds < 60) return `${seconds}s`;- const minutes = Math.floor(seconds / 60);- const remainingSeconds = seconds % 60;- if (minutes < 60) return `${minutes}m ${remainingSeconds}s`;- const hours = Math.floor(minutes / 60);- const remainingMinutes = minutes % 60;- return `${hours}h ${remainingMinutes}m`;-}-function formatDuration(startedAt?: number, endedAt?: number): string {- if (!isFiniteNumber(startedAt) || !isFiniteNumber(endedAt)) return "";- return formatDurationMs(endedAt - startedAt);+ return formatDurationBetween(startedAt, endedAt);}function formatElapsedSince(timestampMs: number | undefined, nowMs: number): string {- if (!isFiniteNumber(timestampMs)) return "";- return formatDurationMs(Math.max(0, nowMs - timestampMs));+ return formatDurationBetween(timestampMs, nowMs);}function getArrayField(value: unknown, field: string): unknown[] | null {@@ -965,15 +952,12 @@ function AgentActivity() {? new Date(currentCommit.dateCreated).getTime(): undefined);+ const isDone = isTerminalVariantStatus(selectedVariantStatus);const isLatestCommit = head === latestCommitHash;if (!isLatestCommit || events.length === 0) {return null;}- const isDone =- selectedVariantStatus === "complete" ||- selectedVariantStatus === "error" ||- selectedVariantStatus === "cancelled";const runningDuration = formatElapsedSince(requestStartMs, nowMs);const completedEventGroups = groupCompletedAgentEvents(events);diff --git a/frontend/src/components/agent/generation-time.test.ts b/frontend/src/components/agent/generation-time.test.tsnew file mode 100644index 00000000..79052c22--- /dev/null+++ b/frontend/src/components/agent/generation-time.test.ts@@ -0,0 +1,36 @@+import { VariantStatus } from "../commits/types";+import {+ formatCompletedGenerationDuration,+ formatDurationBetween,+ formatDurationMs,+} from "./generation-time";++describe("generation time formatting", () => {+ test("uses the concise formatting shared by live and completed timers", () => {+ expect(formatDurationMs(0)).toBe("1s");+ expect(formatDurationMs(8_000)).toBe("8s");+ expect(formatDurationMs(115_000)).toBe("1m 55s");+ expect(formatDurationMs(3_660_000)).toBe("1h 1m");+ });++ test("formats elapsed wall-clock time only when both timestamps exist", () => {+ expect(formatDurationBetween(1_000, 116_000)).toBe("1m 55s");+ expect(formatDurationBetween(undefined, 116_000)).toBe("");+ expect(formatDurationBetween(1_000, undefined)).toBe("");+ });++ test.each<VariantStatus>(["complete", "error", "cancelled"])(+ "shows a stable completed duration for %s variants",+ (status) => {+ expect(+ formatCompletedGenerationDuration(status, 1_000, 116_000)+ ).toBe("1m 55s");+ }+ );++ test("does not turn a live generation into a completed duration", () => {+ expect(+ formatCompletedGenerationDuration("generating", 1_000, 116_000)+ ).toBe("");+ });+});diff --git a/frontend/src/components/agent/generation-time.ts b/frontend/src/components/agent/generation-time.tsnew file mode 100644index 00000000..77b1c911--- /dev/null+++ b/frontend/src/components/agent/generation-time.ts@@ -0,0 +1,43 @@+import { VariantStatus } from "../commits/types";++function isFiniteNumber(value: unknown): value is number {+ return typeof value === "number" && Number.isFinite(value);+}++export function formatDurationMs(milliseconds: number): string {+ const seconds = Math.max(1, Math.round(milliseconds / 1000));+ if (seconds < 60) return `${seconds}s`;++ const minutes = Math.floor(seconds / 60);+ const remainingSeconds = seconds % 60;+ if (minutes < 60) return `${minutes}m ${remainingSeconds}s`;++ const hours = Math.floor(minutes / 60);+ const remainingMinutes = minutes % 60;+ return `${hours}h ${remainingMinutes}m`;+}++export function formatDurationBetween(+ startedAt: number | undefined,+ endedAt: number | undefined+): string {+ if (!isFiniteNumber(startedAt) || !isFiniteNumber(endedAt)) return "";+ return formatDurationMs(Math.max(0, endedAt - startedAt));+}++export function isTerminalVariantStatus(+ status: VariantStatus | undefined+): status is Exclude<VariantStatus, "generating"> {+ return (+ status === "complete" || status === "error" || status === "cancelled"+ );+}++export function formatCompletedGenerationDuration(+ status: VariantStatus | undefined,+ requestStartedAt: number | undefined,+ completedAt: number | undefined+): string {+ if (!isTerminalVariantStatus(status)) return "";+ return formatDurationBetween(requestStartedAt, completedAt);+}diff --git a/frontend/src/components/sidebar/Sidebar.tsx b/frontend/src/components/sidebar/Sidebar.tsxindex c62c9b2d..4e6392a1 100644--- a/frontend/src/components/sidebar/Sidebar.tsx+++ b/frontend/src/components/sidebar/Sidebar.tsx@@ -15,6 +15,7 @@ import { toast } from "react-hot-toast";import Variants from "../variants/Variants";import UpdateImageUpload, { UpdateImagePreview } from "../UpdateImageUpload";import AgentActivity from "../agent/AgentActivity";+import { formatCompletedGenerationDuration } from "../agent/generation-time";import WorkingPulse from "../core/WorkingPulse";import ImageLightbox from "../ImageLightbox";import { Commit } from "../commits/types";@@ -179,6 +180,11 @@ function Sidebar({const elapsedSeconds = requestStartMs? Math.max(1, Math.round((nowMs - requestStartMs) / 1000)): undefined;+ const totalGenerationTime = formatCompletedGenerationDuration(+ selectedVariant?.status,+ requestStartMs,+ selectedVariant?.completedAt+ );const canRegenerate =currentCommit?.type === "ai_create" || currentCommit?.type === "ai_edit";@@ -421,7 +427,15 @@ function Sidebar({(appState === AppState.CODE_READY ||(head === latestCommitHash &&(isSelectedVariantComplete || isSelectedVariantError))) && (- <div className="flex justify-end mb-3">+ <div className="mb-3 flex items-center justify-end gap-2">+ {totalGenerationTime && (+ <span+ className="text-[11px] font-medium tabular-nums text-gray-400 dark:text-gray-500"+ data-testid="total-generation-time"+ >+ Total time {totalGenerationTime}+ </span>+ )}<buttononClick={regenerate}className="regenerate-btn flex items-center gap-1.5 px-3 py-1.5 text-xs font-medium text-gray-600 dark:text-gray-300 border border-gray-300 dark:border-gray-600 rounded-lg hover:bg-gray-100 dark:hover:bg-zinc-800 transition-colors"diff --git a/frontend/src/store/project-store.test.ts b/frontend/src/store/project-store.test.tsnew file mode 100644index 00000000..4b78fb85--- /dev/null+++ b/frontend/src/store/project-store.test.ts@@ -0,0 +1,52 @@+import { Commit, VariantStatus } from "../components/commits/types";+import { useProjectStore } from "./project-store";++function createGeneratingCommit(): Commit {+ return {+ hash: "timed-commit",+ parentHash: null,+ dateCreated: new Date(1_000),+ isCommitted: false,+ variants: [{ code: "", history: [] }],+ selectedVariantIndex: 0,+ type: "ai_create",+ inputs: { text: "Create a page", images: [] },+ };+}++describe("variant completion timestamps", () => {+ beforeEach(() => {+ useProjectStore.setState({+ commits: {},+ head: null,+ latestCommitHash: null,+ });+ });++ afterEach(() => {+ jest.restoreAllMocks();+ });++ test.each<VariantStatus>(["complete", "error", "cancelled"])(+ "records one stable timestamp when a variant becomes %s",+ (status) => {+ const now = jest.spyOn(Date, "now").mockReturnValue(116_000);+ const store = useProjectStore.getState();+ store.addCommit(createGeneratingCommit());+ store.updateVariantStatus("timed-commit", 0, status);++ expect(+ useProjectStore.getState().commits["timed-commit"].variants[0]+ .completedAt+ ).toBe(116_000);++ now.mockReturnValue(999_000);+ store.updateVariantStatus("timed-commit", 0, status);++ expect(+ useProjectStore.getState().commits["timed-commit"].variants[0]+ .completedAt+ ).toBe(116_000);+ }+ );+});