Drop in a screenshot and convert it to clean code (HTML/Tailwind/React/Vue)
Python
improve tests and catch history tree generation errors better
Abi Raja68a8d2788d11
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsxindex f1301e04..95cd8d39 100644--- a/frontend/src/App.tsx+++ b/frontend/src/App.tsx@@ -211,10 +211,17 @@ function App() {return;}- const updatedHistory = [- ...extractHistoryTree(appHistory, currentVersion),- updateInstruction,- ];+ let historyTree;+ try {+ historyTree = extractHistoryTree(appHistory, currentVersion);+ } catch {+ toast.error(+ "Version history is invalid. This shouldn't happen. Please contact support or open a Github issue."+ );+ return;+ }++ const updatedHistory = [...historyTree, updateInstruction];if (shouldIncludeResultImage) {const resultImage = await takeScreenshot();diff --git a/frontend/src/components/history/utils.test.ts b/frontend/src/components/history/utils.test.tsindex 0dc26bd9..2abaf90e 100644--- a/frontend/src/components/history/utils.test.ts+++ b/frontend/src/components/history/utils.test.ts@@ -53,7 +53,26 @@ const longerBranchingHistory: History = [},];-test("should only include history from this point onward", () => {+const basicBadHistory: History = [+ {+ type: "ai_create",+ parentIndex: null,+ code: "<html>1. create</html>",+ inputs: {+ image_url: "",+ },+ },+ {+ type: "ai_edit",+ parentIndex: 2, // <- Bad parent index+ code: "<html>2. edit with better icons</html>",+ inputs: {+ prompt: "use better icons",+ },+ },+];++test("should correctly extract the history tree", () => {expect(extractHistoryTree(basicLinearHistory, 2)).toEqual(["<html>1. create</html>","use better icons",@@ -93,11 +112,12 @@ test("should only include history from this point onward", () => {"<html>3. edit with better icons and red text</html>",]);- // Errors - TODO: Handle these+ // Errors+// Bad index- // TODO: Throw an exception instead?- expect(extractHistoryTree(basicLinearHistory, 100)).toEqual([]);- expect(extractHistoryTree(basicLinearHistory, -2)).toEqual([]);+ expect(() => extractHistoryTree(basicLinearHistory, 100)).toThrow();+ expect(() => extractHistoryTree(basicLinearHistory, -2)).toThrow();// Bad tree+ expect(() => extractHistoryTree(basicBadHistory, 1)).toThrow();});diff --git a/frontend/src/components/history/utils.ts b/frontend/src/components/history/utils.tsindex cfdfbbce..ce7bf3c9 100644--- a/frontend/src/components/history/utils.ts+++ b/frontend/src/components/history/utils.ts@@ -22,9 +22,7 @@ export function extractHistoryTree(// Move to the parent of the current itemcurrentIndex = item.parentIndex;} else {- // TODO: Throw an exception here?- // Break the loop if the item is not found (should not happen in a well-formed history)- break;+ throw new Error("Malformed history: missing parent index");}}