Skip to content

Drop in a screenshot and convert it to clean code (HTML/Tailwind/React/Vue)

Python

refactor: simplify generateCode function parameters

Abi Raja812571796529
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx
index f27b789f..a1f14227 100644
--- a/frontend/src/App.tsx
+++ b/frontend/src/App.tsx
@@ -205,57 +205,30 @@ function App() {
addCommit(commit);
setHead(commit.hash);
- generateCode(
- wsRef,
- updatedParams,
- // On change
- (token, variantIndex) => {
+ generateCode(wsRef, updatedParams, {
+ onChange: (token, variantIndex) => {
appendCommitCode(commit.hash, variantIndex, token);
},
- // On set code
- (code, variantIndex) => {
- // When we receive the final code, also update status to complete
- // This ensures status is set even if variantComplete event is missed
+ onSetCode: (code, variantIndex) => {
setCommitCode(commit.hash, variantIndex, code);
- // TODO: Remove
- // updateVariantStatus(commit.hash, variantIndex, "complete");
},
- // On status update
- (line, variantIndex) => appendExecutionConsole(variantIndex, line),
- // On variant complete
- (variantIndex) => {
+ onStatusUpdate: (line, variantIndex) => appendExecutionConsole(variantIndex, line),
+ onVariantComplete: (variantIndex) => {
console.log(`Variant ${variantIndex} complete event received`);
-
- // Update variant status to variantComplete
updateVariantStatus(commit.hash, variantIndex, "complete");
-
- // TODO: Remove
- // // Force UI update by creating a small delay before state change
- // setTimeout(() => {
- // // If this is the selected variant, immediately set app state to ready
- // if (commits[commit.hash].selectedVariantIndex === variantIndex) {
- // console.log(
- // `Selected variant ${variantIndex} complete, setting app state to ready`
- // );
- // setAppState(AppState.CODE_READY);
- // }
- // }, 100);
},
- // On variant error
- (variantIndex, error) => {
+ onVariantError: (variantIndex, error) => {
console.error(`Error in variant ${variantIndex}:`, error);
updateVariantStatus(commit.hash, variantIndex, "cancelled");
toast.error(`Error in option ${variantIndex + 1}: ${error}`);
},
- // On cancel
- () => {
+ onCancel: () => {
cancelCodeGenerationAndReset(commit);
},
- // On complete
- () => {
+ onComplete: () => {
setAppState(AppState.CODE_READY);
- }
- );
+ },
+ });
}
// Initial version creation
diff --git a/frontend/src/generateCode.ts b/frontend/src/generateCode.ts
index e0a689ee..a3c7acb0 100644
--- a/frontend/src/generateCode.ts
+++ b/frontend/src/generateCode.ts
@@ -23,16 +23,20 @@ type WebSocketResponse = {
variantIndex: number;
};
+interface CodeGenerationCallbacks {
+ onChange: (chunk: string, variantIndex: number) => void;
+ onSetCode: (code: string, variantIndex: number) => void;
+ onStatusUpdate: (status: string, variantIndex: number) => void;
+ onVariantComplete: (variantIndex: number) => void;
+ onVariantError: (variantIndex: number, error: string) => void;
+ onCancel: () => void;
+ onComplete: () => void;
+}
+
export function generateCode(
wsRef: React.MutableRefObject<WebSocket | null>,
params: FullGenerationSettings,
- onChange: (chunk: string, variantIndex: number) => void,
- onSetCode: (code: string, variantIndex: number) => void,
- onStatusUpdate: (status: string, variantIndex: number) => void,
- onVariantComplete: (variantIndex: number) => void,
- onVariantError: (variantIndex: number, error: string) => void,
- onCancel: () => void,
- onComplete: () => void
+ callbacks: CodeGenerationCallbacks
) {
const wsUrl = `${WS_BACKEND_URL}/generate-code`;
console.log("Connecting to backend @ ", wsUrl);
@@ -47,15 +51,15 @@ export function generateCode(
ws.addEventListener("message", async (event: MessageEvent) => {
const response = JSON.parse(event.data) as WebSocketResponse;
if (response.type === "chunk") {
- onChange(response.value, response.variantIndex);
+ callbacks.onChange(response.value, response.variantIndex);
} else if (response.type === "status") {
- onStatusUpdate(response.value, response.variantIndex);
+ callbacks.onStatusUpdate(response.value, response.variantIndex);
} else if (response.type === "setCode") {
- onSetCode(response.value, response.variantIndex);
+ callbacks.onSetCode(response.value, response.variantIndex);
} else if (response.type === "variantComplete") {
- onVariantComplete(response.variantIndex);
+ callbacks.onVariantComplete(response.variantIndex);
} else if (response.type === "variantError") {
- onVariantError(response.variantIndex, response.value);
+ callbacks.onVariantError(response.variantIndex, response.value);
} else if (response.type === "error") {
console.error("Error generating code", response.value);
toast.error(response.value);
@@ -66,16 +70,16 @@ export function generateCode(
console.log("Connection closed", event.code, event.reason);
if (event.code === USER_CLOSE_WEB_SOCKET_CODE) {
toast.success(CANCEL_MESSAGE);
- onCancel();
+ callbacks.onCancel();
} else if (event.code === APP_ERROR_WEB_SOCKET_CODE) {
console.error("Known server error", event);
- onCancel();
+ callbacks.onCancel();
} else if (event.code !== 1000) {
console.error("Unknown server or connection error", event);
toast.error(ERROR_MESSAGE);
- onCancel();
+ callbacks.onCancel();
} else {
- onComplete();
+ callbacks.onComplete();
}
});