Skip to content

Drop in a screenshot and convert it to clean code (HTML/Tailwind/React/Vue)

Python

Simplify video variant handling

Abi Raja8ea797de8f12
diff --git a/backend/routes/generate_code.py b/backend/routes/generate_code.py
index f0575fbf..54c26a32 100644
--- a/backend/routes/generate_code.py
+++ b/backend/routes/generate_code.py
@@ -387,8 +387,8 @@ class ModelSelectionStage:
) -> List[Llm]:
"""Simple model cycling that scales with num_variants"""
- # Video create mode requires Gemini - 2 variants for comparison
- if input_mode == "video" and generation_type == "create":
+ # Video mode requires Gemini - 2 variants for comparison
+ if input_mode == "video":
if not gemini_api_key:
raise Exception(
"Video mode requires a Gemini API key. "
@@ -693,11 +693,8 @@ class StatusBroadcastMiddleware(Middleware):
) -> None:
# Determine variant count based on input mode
assert context.extracted_params is not None
- is_video_create = (
- context.extracted_params.input_mode == "video"
- and context.extracted_params.generation_type == "create"
- )
- num_variants = NUM_VARIANTS_VIDEO if is_video_create else NUM_VARIANTS
+ is_video_mode = context.extracted_params.input_mode == "video"
+ num_variants = NUM_VARIANTS_VIDEO if is_video_mode else NUM_VARIANTS
# Tell frontend how many variants we're using
await context.send_message("variantCount", str(num_variants), 0)
diff --git a/backend/tests/test_model_selection.py b/backend/tests/test_model_selection.py
index ef272773..7921e8fa 100644
--- a/backend/tests/test_model_selection.py
+++ b/backend/tests/test_model_selection.py
@@ -67,6 +67,23 @@ class TestModelSelectionAllKeys:
]
assert models == expected
+ @pytest.mark.asyncio
+ async def test_video_update_prefers_gemini_minimal_then_low(self):
+ """Video update always uses the same two Gemini variants as video create."""
+ models = await self.model_selector.select_models(
+ generation_type="update",
+ input_mode="video",
+ openai_api_key="key",
+ anthropic_api_key="key",
+ gemini_api_key="key",
+ )
+
+ expected = [
+ Llm.GEMINI_3_FLASH_PREVIEW_MINIMAL,
+ Llm.GEMINI_3_PRO_PREVIEW_LOW,
+ ]
+ assert models == expected
+
class TestModelSelectionOpenAIAnthropic:
"""Test model selection when only OpenAI and Anthropic keys are present."""
diff --git a/backend/tests/test_status_broadcast.py b/backend/tests/test_status_broadcast.py
new file mode 100644
index 00000000..1024e4af
--- /dev/null
+++ b/backend/tests/test_status_broadcast.py
@@ -0,0 +1,62 @@
+from types import SimpleNamespace
+from unittest.mock import AsyncMock, MagicMock
+from typing import Any, cast
+
+import pytest
+
+from routes.generate_code import (
+ ExtractedParams,
+ PipelineContext,
+ StatusBroadcastMiddleware,
+)
+
+
+async def test_video_update_broadcasts_two_variants() -> None:
+ sent_messages: list[tuple[str, str | None, int]] = []
+
+ async def send_message(
+ msg_type: str,
+ value: str | None,
+ variant_index: int,
+ data=None,
+ eventId=None,
+ ) -> None:
+ sent_messages.append((msg_type, value, variant_index))
+
+ context = PipelineContext(websocket=MagicMock())
+ context.ws_comm = cast(
+ Any,
+ SimpleNamespace(
+ send_message=send_message,
+ throw_error=AsyncMock(),
+ ),
+ )
+ context.extracted_params = ExtractedParams(
+ stack="html_tailwind",
+ input_mode="video",
+ should_generate_images=True,
+ openai_api_key=None,
+ anthropic_api_key=None,
+ openai_base_url=None,
+ generation_type="update",
+ prompt={"text": "Edit this video output", "images": [], "videos": []},
+ history=[],
+ file_state=None,
+ option_codes=[],
+ )
+
+ middleware = StatusBroadcastMiddleware()
+ next_called = False
+
+ async def next_func() -> None:
+ nonlocal next_called
+ next_called = True
+
+ await middleware.process(context, next_func)
+
+ assert sent_messages[0] == ("variantCount", "2", 0)
+ status_messages = [m for m in sent_messages if m[0] == "status"]
+ assert len(status_messages) == 2
+ assert [m[2] for m in status_messages] == [0, 1]
+ assert next_called is True
diff --git a/frontend/src/components/agent/AgentActivity.tsx b/frontend/src/components/agent/AgentActivity.tsx
index ec906cb7..6f7c5195 100644
--- a/frontend/src/components/agent/AgentActivity.tsx
+++ b/frontend/src/components/agent/AgentActivity.tsx
@@ -21,7 +21,7 @@ import ReactMarkdown from "react-markdown";
import { Light as SyntaxHighlighterBase } from "react-syntax-highlighter";
import html from "react-syntax-highlighter/dist/esm/languages/hljs/xml";
import { vs2015 } from "react-syntax-highlighter/dist/esm/styles/hljs";
-import Spinner from "../core/Spinner";
+import WorkingPulse from "../core/WorkingPulse";
SyntaxHighlighterBase.registerLanguage("html", html);
const SyntaxHighlighter = SyntaxHighlighterBase as any;
@@ -511,9 +511,7 @@ function AgentActivity() {
<>
<div className="flex items-center justify-between rounded-xl border border-gray-200 dark:border-gray-700 bg-white dark:bg-gray-900/60 px-3 py-2">
<div className="flex items-center gap-2 text-sm text-gray-600 dark:text-gray-300">
- <div className="scale-75">
- <Spinner />
- </div>
+ <WorkingPulse />
<span>Working...</span>
</div>
<div className="text-xs font-semibold text-gray-700 dark:text-gray-200">
diff --git a/frontend/src/components/core/WorkingPulse.tsx b/frontend/src/components/core/WorkingPulse.tsx
new file mode 100644
index 00000000..861cfdcf
--- /dev/null
+++ b/frontend/src/components/core/WorkingPulse.tsx
@@ -0,0 +1,11 @@
+function WorkingPulse() {
+ return (
+ <span className="inline-flex items-end gap-0.5" aria-hidden="true">
+ <span className="h-1.5 w-1.5 rounded-full bg-sky-500/90 dark:bg-sky-400/90 animate-bounce [animation-duration:900ms]" />
+ <span className="h-1.5 w-1.5 rounded-full bg-sky-500/80 dark:bg-sky-400/80 animate-bounce [animation-duration:900ms] [animation-delay:150ms]" />
+ <span className="h-1.5 w-1.5 rounded-full bg-sky-500/70 dark:bg-sky-400/70 animate-bounce [animation-duration:900ms] [animation-delay:300ms]" />
+ </span>
+ );
+}
+
+export default WorkingPulse;
diff --git a/frontend/src/components/sidebar/Sidebar.tsx b/frontend/src/components/sidebar/Sidebar.tsx
index 35e09a33..e5d80fdc 100644
--- a/frontend/src/components/sidebar/Sidebar.tsx
+++ b/frontend/src/components/sidebar/Sidebar.tsx
@@ -9,7 +9,7 @@ import { toast } from "react-hot-toast";
import Variants from "../variants/Variants";
import UpdateImageUpload, { UpdateImagePreview } from "../UpdateImageUpload";
import AgentActivity from "../agent/AgentActivity";
-import Spinner from "../core/Spinner";
+import WorkingPulse from "../core/WorkingPulse";
interface SidebarProps {
showSelectAndEditFeature: boolean;
@@ -182,9 +182,7 @@ function Sidebar({
<div className="mb-3 rounded-xl border border-gray-200 dark:border-gray-700 bg-white dark:bg-gray-900/60 px-3 py-2">
<div className="flex items-center justify-between">
<div className="flex items-center gap-2 text-sm text-gray-600 dark:text-gray-300">
- <div className="scale-75">
- <Spinner />
- </div>
+ <WorkingPulse />
<span>Working...</span>
</div>
<div className="text-xs font-semibold text-gray-700 dark:text-gray-200">
diff --git a/frontend/src/components/variants/Variants.tsx b/frontend/src/components/variants/Variants.tsx
index 95c122c4..957d333d 100644
--- a/frontend/src/components/variants/Variants.tsx
+++ b/frontend/src/components/variants/Variants.tsx
@@ -113,7 +113,7 @@ function Variants() {
return (
<div className="pt-2 pb-1">
- <div className="flex gap-1.5">
+ <div className="grid grid-cols-2 gap-2">
{variants.map((variant, index) => {
let statusColor = "bg-gray-300 dark:bg-gray-600";
if (variant.status === "complete") statusColor = "bg-green-500";
@@ -122,7 +122,7 @@ function Variants() {
return (
<div
key={index}
- className={`flex-1 min-w-0 rounded cursor-pointer overflow-hidden ${
+ className={`w-full rounded cursor-pointer overflow-hidden ${
index === selectedVariantIndex
? "ring-2 ring-blue-400 dark:ring-blue-500"
: "ring-1 ring-gray-200 dark:ring-gray-700 hover:ring-gray-300 dark:hover:ring-gray-600"
@@ -134,13 +134,13 @@ function Variants() {
code={variant.code}
isSelected={index === selectedVariantIndex}
/>
- <div className="flex items-center px-1.5 py-0.5 bg-white dark:bg-zinc-900">
- <span className="inline-flex min-w-0 items-center text-[10px] text-gray-500 dark:text-gray-400 whitespace-nowrap">
- <span className={`w-1.5 h-1.5 rounded-full mr-1 ${statusColor}`} />
+ <div className="flex items-center px-2 py-1 bg-white dark:bg-zinc-900">
+ <span className="inline-flex min-w-0 items-center text-xs text-gray-500 dark:text-gray-400 whitespace-nowrap">
+ <span className={`w-2 h-2 rounded-full mr-1.5 ${statusColor}`} />
Option {index + 1}
</span>
{variant.status === "generating" && (
- <div className="ml-auto shrink-0 scale-50">
+ <div className="ml-auto shrink-0 scale-75">
<Spinner />
</div>
)}