Skip to content

Drop in a screenshot and convert it to clean code (HTML/Tailwind/React/Vue)

Python

Revert "add temporary openai testing override"

Abi Rajae782188daba4
diff --git a/backend/config.py b/backend/config.py
index 8cb03f80..5ac65571 100644
--- a/backend/config.py
+++ b/backend/config.py
@@ -1,10 +1,5 @@
import os
-
-def _env_flag(name: str) -> bool:
- value = os.environ.get(name, "")
- return value.strip().lower() in {"1", "true", "yes", "on"}
-
NUM_VARIANTS = 4
NUM_VARIANTS_VIDEO = 2
@@ -21,9 +16,6 @@ REPLICATE_API_KEY = os.environ.get("REPLICATE_API_KEY", None)
IS_DEBUG_ENABLED = bool(os.environ.get("IS_DEBUG_ENABLED", False))
DEBUG_DIR = os.environ.get("DEBUG_DIR", "")
-# Temporary local-only override for OpenAI-focused model testing.
-TEST_OPENAI_LOW_VARIANT_OVERRIDE = _env_flag("TEST_OPENAI_LOW_VARIANT_OVERRIDE")
-
# Set to True when running in production (on the hosted version)
# Used as a feature flag to enable or disable certain features
IS_PROD = os.environ.get("IS_PROD", False)
diff --git a/backend/routes/generate_code.py b/backend/routes/generate_code.py
index 5425e4b5..60e00967 100644
--- a/backend/routes/generate_code.py
+++ b/backend/routes/generate_code.py
@@ -16,7 +16,6 @@ from config import (
OPENAI_API_KEY,
OPENAI_BASE_URL,
REPLICATE_API_KEY,
- TEST_OPENAI_LOW_VARIANT_OVERRIDE,
)
from custom_types import InputMode
from llm import (
@@ -74,38 +73,8 @@ from ws.constants import APP_ERROR_WEB_SOCKET_CODE # type: ignore
router = APIRouter()
-OPENAI_LOW_VARIANTS = [
- Llm.GPT_5_2_CODEX_LOW,
- Llm.GPT_5_3_CODEX_LOW,
-]
-
-
-def _get_openai_test_variant_override(
- input_mode: InputMode,
- openai_api_key: str | None,
-) -> List[Llm] | None:
- if not TEST_OPENAI_LOW_VARIANT_OVERRIDE:
- return None
- if input_mode == "video" or not openai_api_key:
- return None
- return list(OPENAI_LOW_VARIANTS)
-
-
-def _get_variant_count_for_request(extracted_params: "ExtractedParams") -> int:
- override_models = _get_openai_test_variant_override(
- extracted_params.input_mode,
- extracted_params.openai_api_key,
- )
- if override_models is not None:
- return len(override_models)
-
- is_video_mode = extracted_params.input_mode == "video"
- is_update = extracted_params.generation_type == "update"
- return (
- NUM_VARIANTS_VIDEO
- if is_video_mode
- else 2 if is_update else NUM_VARIANTS
- )
+# Temporary debug override to focus on OpenAI prompt caching behavior.
+FORCE_OPENAI_SINGLE_VARIANT = True
@dataclass
@@ -398,15 +367,12 @@ class ModelSelectionStage:
) -> List[Llm]:
"""Select appropriate models based on available API keys"""
try:
- override_models = _get_openai_test_variant_override(
- input_mode,
- openai_api_key,
- )
- if override_models is not None:
- variant_models = override_models
+ if FORCE_OPENAI_SINGLE_VARIANT and input_mode != "video":
+ if not openai_api_key:
+ raise Exception("OpenAI API key required for single-variant debug mode")
+ variant_models = [Llm.GPT_5_2_CODEX_HIGH]
print("Variant models:")
- for index, model in enumerate(variant_models):
- print(f"Variant {index + 1}: {model.value}")
+ print(f"Variant 1: {variant_models[0].value}")
return variant_models
num_variants = 2 if generation_type == "update" else NUM_VARIANTS
@@ -453,6 +419,14 @@ class ModelSelectionStage:
)
return list(VIDEO_VARIANT_MODELS)
+ # Edit/update mode prefers one Gemini + one OpenAI model for fast,
+ # complementary deltas.
+ if generation_type == "update" and gemini_api_key and openai_api_key:
+ return [
+ Llm.GEMINI_3_FLASH_PREVIEW_MINIMAL,
+ Llm.GPT_5_2_CODEX_LOW,
+ ]
+
# Define models based on available API keys
if gemini_api_key and anthropic_api_key and openai_api_key:
if input_mode == "text" and generation_type == "create":
@@ -718,8 +692,19 @@ class StatusBroadcastMiddleware(Middleware):
async def process(
self, context: PipelineContext, next_func: Callable[[], Awaitable[None]]
) -> None:
+ # Determine variant count based on input mode and generation type.
+ # Edit/update flows use two variants to keep latency and cost down.
assert context.extracted_params is not None
- num_variants = _get_variant_count_for_request(context.extracted_params)
+ is_video_mode = context.extracted_params.input_mode == "video"
+ is_update = context.extracted_params.generation_type == "update"
+ if FORCE_OPENAI_SINGLE_VARIANT and not is_video_mode:
+ num_variants = 1
+ else:
+ num_variants = (
+ NUM_VARIANTS_VIDEO
+ if is_video_mode
+ else 2 if is_update else NUM_VARIANTS
+ )
# Tell frontend how many variants we're using
await context.send_message("variantCount", str(num_variants), 0)
diff --git a/backend/tests/test_model_selection.py b/backend/tests/test_model_selection.py
index 66acd9b6..60b8fe6e 100644
--- a/backend/tests/test_model_selection.py
+++ b/backend/tests/test_model_selection.py
@@ -1,6 +1,6 @@
import pytest
from unittest.mock import AsyncMock
-import routes.generate_code as generate_code
+from routes.generate_code import ModelSelectionStage
from llm import Llm
@@ -10,7 +10,7 @@ class TestModelSelectionAllKeys:
def setup_method(self):
"""Set up test fixtures."""
mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
+ self.model_selector = ModelSelectionStage(mock_throw_error)
@pytest.mark.asyncio
async def test_gemini_anthropic_create(self):
@@ -106,7 +106,7 @@ class TestModelSelectionOpenAIAnthropic:
def setup_method(self):
"""Set up test fixtures."""
mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
+ self.model_selector = ModelSelectionStage(mock_throw_error)
@pytest.mark.asyncio
async def test_openai_anthropic(self):
@@ -134,7 +134,7 @@ class TestModelSelectionAnthropicOnly:
def setup_method(self):
"""Set up test fixtures."""
mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
+ self.model_selector = ModelSelectionStage(mock_throw_error)
@pytest.mark.asyncio
async def test_anthropic_only(self):
@@ -162,7 +162,7 @@ class TestModelSelectionOpenAIOnly:
def setup_method(self):
"""Set up test fixtures."""
mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
+ self.model_selector = ModelSelectionStage(mock_throw_error)
@pytest.mark.asyncio
async def test_openai_only(self):
@@ -190,7 +190,7 @@ class TestModelSelectionNoKeys:
def setup_method(self):
"""Set up test fixtures."""
mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
+ self.model_selector = ModelSelectionStage(mock_throw_error)
@pytest.mark.asyncio
async def test_no_keys_raises_error(self):
@@ -203,55 +203,3 @@ class TestModelSelectionNoKeys:
anthropic_api_key=None,
gemini_api_key=None,
)
-
-
-class TestModelSelectionOpenAITestOverride:
- def setup_method(self):
- mock_throw_error = AsyncMock()
- self.model_selector = generate_code.ModelSelectionStage(mock_throw_error)
-
- @pytest.mark.asyncio
- async def test_override_uses_openai_low_pair_for_create(
- self, monkeypatch: pytest.MonkeyPatch
- ) -> None:
- monkeypatch.setattr(
- generate_code,
- "TEST_OPENAI_LOW_VARIANT_OVERRIDE",
- True,
- )
-
- models = await self.model_selector.select_models(
- generation_type="create",
- input_mode="text",
- openai_api_key="key",
- anthropic_api_key="key",
- gemini_api_key="key",
- )
-
- assert models == [
- Llm.GPT_5_2_CODEX_LOW,
- Llm.GPT_5_3_CODEX_LOW,
- ]
-
- @pytest.mark.asyncio
- async def test_override_uses_openai_low_pair_for_update(
- self, monkeypatch: pytest.MonkeyPatch
- ) -> None:
- monkeypatch.setattr(
- generate_code,
- "TEST_OPENAI_LOW_VARIANT_OVERRIDE",
- True,
- )
-
- models = await self.model_selector.select_models(
- generation_type="update",
- input_mode="image",
- openai_api_key="key",
- anthropic_api_key="key",
- gemini_api_key="key",
- )
-
- assert models == [
- Llm.GPT_5_2_CODEX_LOW,
- Llm.GPT_5_3_CODEX_LOW,
- ]
diff --git a/backend/tests/test_status_broadcast.py b/backend/tests/test_status_broadcast.py
index 7368f6b6..b5093513 100644
--- a/backend/tests/test_status_broadcast.py
+++ b/backend/tests/test_status_broadcast.py
@@ -4,7 +4,6 @@ from typing import Any, cast
import pytest
-import routes.generate_code as generate_code
from routes.generate_code import (
ExtractedParams,
PipelineContext,
@@ -112,61 +111,3 @@ async def test_image_update_broadcasts_two_variants() -> None:
assert len(status_messages) == 2
assert [m[2] for m in status_messages] == [0, 1]
assert next_called is True
-
-
-async def test_image_create_with_openai_key_broadcasts_two_variants(
- monkeypatch: pytest.MonkeyPatch,
-) -> None:
- monkeypatch.setattr(
- generate_code,
- "TEST_OPENAI_LOW_VARIANT_OVERRIDE",
- True,
- )
- sent_messages: list[tuple[str, str | None, int]] = []
-
- async def send_message(
- msg_type: str,
- value: str | None,
- variant_index: int,
- data=None,
- eventId=None,
- ) -> None:
- sent_messages.append((msg_type, value, variant_index))
-
- context = PipelineContext(websocket=MagicMock())
- context.ws_comm = cast(
- Any,
- SimpleNamespace(
- send_message=send_message,
- throw_error=AsyncMock(),
- ),
- )
- context.extracted_params = ExtractedParams(
- stack="html_tailwind",
- input_mode="image",
- should_generate_images=True,
- openai_api_key="key",
- anthropic_api_key="key",
- openai_base_url=None,
- generation_type="create",
- prompt={"text": "Build this screenshot", "images": ["data:image/png;base64,abc"], "videos": []},
- history=[],
- file_state=None,
- option_codes=[],
- )
-
- middleware = StatusBroadcastMiddleware()
- next_called = False
-
- async def next_func() -> None:
- nonlocal next_called
- next_called = True
-
- await middleware.process(context, next_func)
-
- assert sent_messages[0] == ("variantCount", "2", 0)
- status_messages = [m for m in sent_messages if m[0] == "status"]
- assert len(status_messages) == 2
- assert [m[2] for m in status_messages] == [0, 1]
- assert next_called is True