Skip to content

Free, open-source 3D sculpting for Linux, macOS and Windows: dense meshes, remeshing, painting, built-in AI (image/text to 3D), Send to Unreal, game-ready LODs, Gaussian splats and OpenUSD.

Predictive strokes back to off by default for 0.10.2 (not yet identical in every run); ui_stroke_resize disabled again

islandmeda1e6c3072f4e
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c062d7b2..1604cdad 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,9 +11,8 @@ All notable changes to SculptForge are listed here. The format follows
default). SculptForge no longer listens on any port for other programs.
### Changed
-- **Predictive strokes are on by default**: big brushes on dense meshes keep up with the pen (21M triangles: frames
- about 9 ms instead of 70, the brush 1-2 px behind the pointer instead of 40, no pause when you lift the pen). The
- result is identical, bit for bit, to a stroke placed without them (checked by `ui_stroke_resize`).
+- Predictive strokes stay an experiment, off by default (Preferences > Performance): a surface-cursor race that
+ could change a stroke is fixed, but a stroke is not yet identical to one placed without them in every run.
- Draft strokes are no longer chosen by any hardware tier or on battery (they measured no faster and aren't yet
identical to a full stroke); the Draft Strokes setting still turns them on.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 38ba28e7..9564277d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -595,7 +595,7 @@ if(SCULPTFORGE_BUILD_TESTS)
# was handed (no data race with the solver thread), replaying the stroke without the thread gives the same
# mesh, bit for bit, and its undo the mesh it started from.
add_test(NAME ui_stroke_resize COMMAND sculptforge --run "new_sphere" --measure-stroke 1.5)
- set_tests_properties(ui_stroke_resize PROPERTIES LABELS ui TIMEOUT 60
+ set_tests_properties(ui_stroke_resize PROPERTIES LABELS ui TIMEOUT 60 DISABLED TRUE # predictive strokes: not yet identical in every run
ENVIRONMENT "SF_NO_UPDATE_CHECK=1;SF_MEASURE_RESIZE=1;SF_MEASURE_VERIFY=1;SF_PREDICTIVE_STROKE=1")
# The guide's keyboard table must match the app's default shortcuts (tools/guide/update_shortcuts.py).
if(Python3_Interpreter_FOUND)
diff --git a/src/app/AsyncStroke.cpp b/src/app/AsyncStroke.cpp
index 42a99906..c5abee2e 100644
--- a/src/app/AsyncStroke.cpp
+++ b/src/app/AsyncStroke.cpp
@@ -237,7 +237,6 @@ void App::pumpStroke() {
s.finalize = true;
s.view.camera = camera_;
s.view.canvas = canvasRect();
- if (std::getenv("SF_TMP_CANVAS")) std::fprintf(stderr, "batch canvas %.0f x %.0f %.0f %.0f aspect %.4f n %zu\n", s.view.canvas.w, s.view.canvas.h, s.view.canvas.x, s.view.canvas.y, camera_.aspect, s.batch.size()); // TEMP
s.view.probe = nullptr;
s.view.radiusProbe = nullptr;
s.view.settings = dabSettings();
diff --git a/src/app/Config.h b/src/app/Config.h
index 4619bac9..746dc117 100644
--- a/src/app/Config.h
+++ b/src/app/Config.h
@@ -44,7 +44,7 @@ struct UiPrefs {
bool multithreading = true; // brushes, normals and BVH updates on every core (off: one thread)
// Sculpt strokes solved on their own thread with a GPU preview of the dabs still to come, the cursor and the
// stroke's head predicted a frame ahead (app/AsyncStroke.cpp). Off: the dabs are placed in the frame loop.
- bool predictiveStrokes = true;
+ bool predictiveStrokes = false; // experimental: not yet bit-identical to the serial path in every run
// Draft strokes (with predictive strokes): dabs move the vertices only; the normals, cavities and culling
// bounds of what they touched are worked out once, when the pen lifts (Sculptor::draftStrokes). Off by
// default; meant for laptops and battery (a hardware tier will turn it on).
diff --git a/tests/ui/performance.sfui b/tests/ui/performance.sfui
index a9d7277e..5be1b87d 100644
--- a/tests/ui/performance.sfui
+++ b/tests/ui/performance.sfui
@@ -22,13 +22,13 @@ hover "Predictive Strokes"
expect_help "exactly the same"
hold none
-# Predictive Strokes: on by default, off and on again.
+# Predictive Strokes: off by default (experimental), on and off again.
+expect_value predictive_strokes == 0
+click "Predictive Strokes"
expect_value predictive_strokes == 1
click "Predictive Strokes"
expect_value predictive_strokes == 0
expect_status "Predictive strokes off"
-click "Predictive Strokes"
-expect_value predictive_strokes == 1
# Antialiasing off and back; 8x.
click "AA Off##perf.aa_1"