SeaweedFS is a distributed storage system for object storage (S3), file systems, Iceberg table buckets, and Lance vector buckets, designed to handle billions of files with O(1) disk access and effortless horizontal scaling.
Go blob-storagecloud-drivedistributed-file-systemdistributed-storageerasure-codingfusehadoop-hdfshdfskuberneteslancelancedbobject-storageposixs3s3-storageseaweedfstiered-file-systemvector-search
shell: return flag parse errors from s3.bucket.create (#12544)
Saarthak Gupta017e42633f15
diff --git a/weed/shell/command_s3_bucket_create.go b/weed/shell/command_s3_bucket_create.goindex 07f0eab1db..4e08dda5e4 100644--- a/weed/shell/command_s3_bucket_create.go+++ b/weed/shell/command_s3_bucket_create.go@@ -59,7 +59,7 @@ func (c *commandS3BucketCreate) Do(args []string, commandEnv *CommandEnv, writerbucketOwner := bucketCommand.String("owner", "", "bucket owner identity name (for S3 IAM authentication)")withLock := bucketCommand.Bool("withLock", false, "enable Object Lock on the bucket (requires and enables versioning)")if err = bucketCommand.Parse(args); err != nil {- return nil+ return err}if *bucketName == "" {diff --git a/weed/shell/command_s3_bucket_create_test.go b/weed/shell/command_s3_bucket_create_test.goindex c409585fa3..8834c0791b 100644--- a/weed/shell/command_s3_bucket_create_test.go+++ b/weed/shell/command_s3_bucket_create_test.go@@ -62,6 +62,17 @@ func TestS3BucketCreateRequestsExclusiveCreate(t *testing.T) {assert.Equal(t, "my-bucket", req.Entry.Name)}+func TestS3BucketCreateReturnsFlagParseError(t *testing.T) {+ filerServer := &bucketCreateTestFilerServer{}+ commandEnv, cleanup := newBucketCreateTestCommandEnv(t, filerServer)+ defer cleanup()++ var output bytes.Buffer+ err := (&commandS3BucketCreate{}).Do([]string{"-name", "my-bucket", "-withlock"}, commandEnv, &output)+ require.EqualError(t, err, "flag provided but not defined: -withlock")+ assert.Empty(t, filerServer.createRequests())+}+func newBucketCreateTestCommandEnv(t *testing.T, filerServer filer_pb.SeaweedFilerServer) (*CommandEnv, func()) {t.Helper()