SeaweedFS is a distributed storage system for object storage (S3), file systems, Iceberg table buckets, and Lance vector buckets, designed to handle billions of files with O(1) disk access and effortless horizontal scaling.
Go blob-storagecloud-drivedistributed-file-systemdistributed-storageerasure-codingfusehadoop-hdfshdfskuberneteslancelancedbobject-storageposixs3s3-storageseaweedfstiered-file-systemvector-search
fix(filer): prevent nil pointer dereference in CompactFileChunks when context is cancelled (#11690)
Mohd Quamar Tyagi72da592b2706
diff --git a/weed/filer/filechunks.go b/weed/filer/filechunks.goindex 3a61ed3b54..835c717f6c 100644--- a/weed/filer/filechunks.go+++ b/weed/filer/filechunks.go@@ -79,6 +79,9 @@ func CompactFileChunks(ctx context.Context, lookupFileIdFn wdclient.LookupFileId}func SeparateGarbageChunks(visibles *IntervalList[*VisibleInterval], chunks []*filer_pb.FileChunk) (compacted []*filer_pb.FileChunk, garbage []*filer_pb.FileChunk) {+ if visibles == nil {+ return chunks, nil+ }fileIds := make(map[string]bool)for x := visibles.Front(); x != nil; x = x.Next {interval := x.Value@@ -225,6 +228,9 @@ func ViewFromVisibleIntervals(visibles *IntervalList[*VisibleInterval], offset i}chunkViews = NewIntervalList[*ChunkView]()+ if visibles == nil {+ return chunkViews+ }for x := visibles.Front(); x != nil; x = x.Next {chunk := x.Valuediff --git a/weed/filer/filechunks_test.go b/weed/filer/filechunks_test.goindex 716e077a3d..81eed9607a 100644--- a/weed/filer/filechunks_test.go+++ b/weed/filer/filechunks_test.go@@ -583,3 +583,36 @@ func TestCompactFileChunks3(t *testing.T) {t.Fatalf("unexpected compacted: %d", len(compacted))}}++func TestSeparateGarbageChunksNilVisibles(t *testing.T) {+ chunks := []*filer_pb.FileChunk{+ {Offset: 10, Size: 100, FileId: "abc", ModifiedTsNs: 50},+ }+ compacted, garbage := SeparateGarbageChunks(nil, chunks)+ if len(compacted) != 1 || len(garbage) != 0 {+ t.Fatalf("expected fallback to original chunks with nil garbage")+ }+}++func TestViewFromVisibleIntervalsNilVisibles(t *testing.T) {+ views := ViewFromVisibleIntervals(nil, 0, 100)+ if views == nil || views.Front() != nil {+ t.Fatalf("expected empty interval list")+ }+}++func TestViewFromChunksPropagatesError(t *testing.T) {+ ctx, cancel := context.WithCancel(context.Background())+ cancel()++ chunks := []*filer_pb.FileChunk{+ {Offset: 0, Size: 100, FileId: "abc", ModifiedTsNs: 50, IsChunkManifest: true},+ }+ views, err := ViewFromChunks(ctx, nil, chunks, 0, math.MaxInt64)+ if err == nil {+ t.Fatal("expected error on cancelled context")+ }+ if views != nil {+ t.Fatalf("expected nil views on error, got %v", views)+ }+}