Skip to content

SeaweedFS is a distributed storage system for object storage (S3), file systems, Iceberg table buckets, and Lance vector buckets, designed to handle billions of files with O(1) disk access and effortless horizontal scaling.

fix(ec): reject oversized bitrot payload before narrowing to u32 (#10172)

Chris Luce3ba31bcdd0
diff --git a/seaweed-volume/src/storage/erasure_coding/ec_bitrot.rs b/seaweed-volume/src/storage/erasure_coding/ec_bitrot.rs
index 06a31167fc..1d959ce819 100644
--- a/seaweed-volume/src/storage/erasure_coding/ec_bitrot.rs
+++ b/seaweed-volume/src/storage/erasure_coding/ec_bitrot.rs
@@ -248,6 +248,19 @@ impl ShardChecksumBuilder {
/// Atomically writes `prot` to `path`, wrapped in the on-disk header with a
/// CRC32C over the serialized payload (temp file + rename).
pub fn save_bitrot_sidecar(path: &str, prot: &EcBitrotProtection) -> io::Result<()> {
+ // The header records payload_len as a uint32 and the buffer allocation below
+ // adds it to a constant. Bound the payload well under any overflow (a real
+ // manifest is a few KB) so neither the length field nor the buffer can wrap.
+ // Check the encoded length BEFORE serializing so an oversized manifest never
+ // allocates a huge buffer. Mirrors Go's SaveBitrotSidecar maxBitrotPayloadSize.
+ const MAX_BITROT_PAYLOAD_SIZE: usize = 1 << 30; // 1 GiB, vastly above any real sidecar
+ let payload_len = prot.encoded_len();
+ if payload_len > MAX_BITROT_PAYLOAD_SIZE {
+ return Err(io::Error::new(
+ io::ErrorKind::InvalidData,
+ format!("bitrot sidecar payload too large: {} bytes", payload_len),
+ ));
+ }
let payload = prot.encode_to_vec();
let mut buf = Vec::with_capacity(BITROT_HEADER_SIZE + payload.len());
buf.extend_from_slice(&BITROT_MAGIC.to_be_bytes());