Skip to content

Open-source personal finance manager. Self-hosted, privacy-first.

Allow disabling asset sync per connection (#386)

Romulo Gatto00d0d684b5dd
diff --git a/backend/app/api/connections.py b/backend/app/api/connections.py
index 771cd111..7d74d400 100644
--- a/backend/app/api/connections.py
+++ b/backend/app/api/connections.py
@@ -106,6 +106,7 @@ async def oauth_callback(
data.code,
provider_name=data.provider,
state=data.state,
+ sync_assets=data.sync_assets,
)
return connection
except ProviderUserActionRequired as e:
diff --git a/backend/app/providers/__init__.py b/backend/app/providers/__init__.py
index 221aa075..78143a81 100644
--- a/backend/app/providers/__init__.py
+++ b/backend/app/providers/__init__.py
@@ -23,6 +23,7 @@ KNOWN_PROVIDERS = [
"description": "Open finance provider for Brazilian banks",
"flow_type": "widget",
"requires_institution_select": False,
+ "supports_asset_sync": True,
},
{
"name": "enable_banking",
@@ -30,6 +31,7 @@ KNOWN_PROVIDERS = [
"description": "European banks via PSD2 open banking",
"flow_type": "oauth",
"requires_institution_select": True,
+ "supports_asset_sync": False,
},
{
"name": "simplefin",
@@ -37,6 +39,7 @@ KNOWN_PROVIDERS = [
"description": "US and international banks via SimpleFIN Bridge",
"flow_type": "token",
"requires_institution_select": False,
+ "supports_asset_sync": True,
},
]
diff --git a/backend/app/schemas/bank_connection.py b/backend/app/schemas/bank_connection.py
index a2646508..08a79020 100644
--- a/backend/app/schemas/bank_connection.py
+++ b/backend/app/schemas/bank_connection.py
@@ -37,6 +37,7 @@ class OAuthCallbackRequest(BaseModel):
code: str
state: Optional[str] = None
provider: Optional[str] = None
+ sync_assets: Optional[bool] = None
class ReauthUrlResponse(BaseModel):
@@ -75,3 +76,4 @@ class ConnectionSettingsUpdate(BaseModel):
display_name: Optional[str] = None
payee_source: Optional[Literal["auto", "merchant", "payment_data", "description", "none"]] = None
import_pending: Optional[bool] = None
+ sync_assets: Optional[bool] = None
diff --git a/backend/app/services/connection_service.py b/backend/app/services/connection_service.py
index cf0a8ded..d438fd13 100644
--- a/backend/app/services/connection_service.py
+++ b/backend/app/services/connection_service.py
@@ -80,6 +80,15 @@ PLUGGY_CATEGORY_MAP = {
}
+def _sync_assets_enabled(settings: Optional[dict]) -> bool:
+ """Return whether provider investment holdings should sync for a connection.
+
+ Missing settings keep the legacy behavior (enabled). Users can opt out per
+ connection via Connection settings without disabling account/transaction sync.
+ """
+ return (settings or {}).get("sync_assets", True) is not False
+
+
async def _sync_holdings(
session: AsyncSession,
user_id: uuid.UUID,
@@ -491,6 +500,7 @@ async def handle_oauth_callback(
code: str,
provider_name: Optional[str] = None,
state: Optional[str] = None,
+ sync_assets: Optional[bool] = None,
) -> BankConnection:
state_payload: dict = {}
if state:
@@ -528,6 +538,14 @@ async def handle_oauth_callback(
await session.refresh(existing)
return existing
+ flow_params = dict(state_payload.get("flow_params") or {})
+ flow_sync_assets = flow_params.pop("sync_assets", None)
+ initial_settings: dict[str, object] = {"flow_params": flow_params}
+ if sync_assets is None and isinstance(flow_sync_assets, bool):
+ sync_assets = flow_sync_assets
+ if sync_assets is not None:
+ initial_settings["sync_assets"] = sync_assets
+
connection = BankConnection(
workspace_id=workspace_id,
user_id=user_id,
@@ -536,7 +554,7 @@ async def handle_oauth_callback(
institution_name=connection_data.institution_name,
logo_url=_clean_logo_url(connection_data.logo_url),
credentials=connection_data.credentials,
- settings={"flow_params": state_payload.get("flow_params") or {}},
+ settings=initial_settings,
status="active",
)
session.add(connection)
@@ -668,9 +686,10 @@ async def handle_oauth_callback(
await detect_transfer_pairs(session, workspace_id, candidate_ids=new_tx_ids)
# Investment holdings live on /investments — separate endpoint from
- # /accounts. Pulled after account setup so holdings are available on
- # the Assets page immediately after the widget closes.
- await _sync_holdings(session, user_id, connection, connection_data.credentials)
+ # /accounts. Pulled after account setup when enabled so holdings are
+ # available on the Assets page immediately after the widget closes.
+ if _sync_assets_enabled(connection.settings):
+ await _sync_holdings(session, user_id, connection, connection_data.credentials)
connection.last_sync_at = datetime.now(timezone.utc)
await session.commit()
@@ -1429,10 +1448,11 @@ async def sync_connection(
await _cleanup_phantom_duplicates(session, connection.id)
# Refresh investment holdings (brokerage, fixed income, funds,
- # etc.). Errors here are logged but don't fail the sync; a bank
- # connector that doesn't expose /investments shouldn't block the
- # transaction sync that just succeeded.
- await _sync_holdings(session, user_id, connection, credentials)
+ # etc.) when enabled for this connection. Errors here are logged but
+ # don't fail the sync; a bank connector that doesn't expose
+ # /investments shouldn't block the transaction sync that just succeeded.
+ if _sync_assets_enabled(conn_settings):
+ await _sync_holdings(session, user_id, connection, credentials)
connection.last_sync_at = datetime.now(timezone.utc)
connection.status = "active"
diff --git a/backend/tests/test_connection_service.py b/backend/tests/test_connection_service.py
index 01830c25..b2d9fc92 100644
--- a/backend/tests/test_connection_service.py
+++ b/backend/tests/test_connection_service.py
@@ -7,10 +7,18 @@ import pytest
from sqlalchemy import select
from sqlalchemy.ext.asyncio import AsyncSession
+from app.models.asset import Asset
from app.models.bank_connection import BankConnection
from app.models.category import Category
from app.models.transaction import Transaction
-from app.providers.base import AccountData, BillData, ConnectionData, ConnectTokenData, TransactionData
+from app.providers.base import (
+ AccountData,
+ BillData,
+ ConnectionData,
+ ConnectTokenData,
+ HoldingData,
+ TransactionData,
+)
from app.services.connection_service import (
_description_similarity,
_match_pluggy_category,
@@ -244,6 +252,106 @@ async def test_update_settings_preserves_existing(session: AsyncSession, test_us
assert updated.settings["import_pending"] is False
+async def test_update_settings_sync_assets(session: AsyncSession, test_user, test_workspace):
+ """Per-connection asset sync can be disabled without clobbering other settings."""
+ conn = await _make_connection(
+ session, test_user.id, "Asset Settings Test",
+ settings={"payee_source": "auto", "import_pending": True},
+ )
+
+ updated = await update_connection_settings(
+ session, conn.id, test_workspace.id, {"sync_assets": False},
+ )
+ assert updated is not None
+ assert updated.settings["payee_source"] == "auto"
+ assert updated.settings["import_pending"] is True
+ assert updated.settings["sync_assets"] is False
+
+
+async def test_oauth_callback_respects_initial_asset_sync_opt_out(
+ session: AsyncSession, test_user, test_workspace
+):
+ """Initial connection creation can opt out before holdings are imported."""
+ mock_provider = AsyncMock()
+ mock_provider.handle_oauth_callback = AsyncMock(return_value=ConnectionData(
+ external_id="ext-no-assets",
+ institution_name="No Assets Bank",
+ credentials={"token": "x"},
+ accounts=[],
+ ))
+ mock_provider.get_holdings = AsyncMock(return_value=[
+ HoldingData(
+ external_id="holding-1", name="Provider Fund",
+ currency="BRL", current_value=Decimal("1234.56"),
+ ),
+ ])
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider), \
+ patch("app.services.connection_service.detect_transfer_pairs", new_callable=AsyncMock):
+ connection = await handle_oauth_callback(
+ session,
+ test_workspace.id,
+ test_user.id,
+ "code",
+ "pluggy",
+ sync_assets=False,
+ )
+
+ assert connection.settings["sync_assets"] is False
+ mock_provider.get_holdings.assert_not_awaited()
+ assets = (await session.execute(select(Asset))).scalars().all()
+ assert assets == []
+
+
+async def test_oauth_callback_respects_state_asset_sync_opt_out(
+ session: AsyncSession, test_user, test_workspace
+):
+ """Redirect OAuth stores the initial opt-out in state before the callback."""
+ mock_provider = AsyncMock()
+ mock_provider.handle_oauth_callback = AsyncMock(return_value=ConnectionData(
+ external_id="ext-oauth-no-assets",
+ institution_name="OAuth No Assets Bank",
+ credentials={"token": "x"},
+ accounts=[],
+ ))
+ mock_provider.get_holdings = AsyncMock(return_value=[
+ HoldingData(
+ external_id="holding-1", name="Provider Fund",
+ currency="BRL", current_value=Decimal("1234.56"),
+ ),
+ ])
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider), \
+ patch("app.services.connection_service.oauth_state.consume_state", new_callable=AsyncMock, return_value={
+ "user_id": str(test_user.id),
+ "workspace_id": str(test_workspace.id),
+ "provider": "test",
+ "flow_params": {
+ "country": "BR",
+ "institution_name": "OAuth No Assets Bank",
+ "sync_assets": False,
+ },
+ }), \
+ patch("app.services.connection_service.detect_transfer_pairs", new_callable=AsyncMock):
+ connection = await handle_oauth_callback(
+ session,
+ test_workspace.id,
+ test_user.id,
+ "code",
+ state="stored-state",
+ )
+
+ assert connection.settings["sync_assets"] is False
+ assert connection.settings["flow_params"] == {
+ "country": "BR",
+ "institution_name": "OAuth No Assets Bank",
+ }
+ mock_provider.get_holdings.assert_not_awaited()
+
+
@pytest.mark.asyncio
async def test_update_settings_ignores_none(session: AsyncSession, test_user, test_workspace):
"""None values in settings_update are not written."""
@@ -603,6 +711,80 @@ async def test_sync_connection_skips_pending(session: AsyncSession, test_user, t
assert result_conn.status == "active"
+async def test_sync_connection_skips_holdings_when_asset_sync_disabled(
+ session: AsyncSession, test_user, test_workspace
+):
+ """sync_assets=False keeps account/transaction sync active but never fetches holdings."""
+ conn = await _make_connection(
+ session, test_user.id, "No Assets Bank",
+ settings={"sync_assets": False},
+ )
+ mock_provider = AsyncMock()
+ mock_provider.refresh_credentials = AsyncMock(return_value={"token": "t"})
+ mock_provider.get_institution_logo = AsyncMock(return_value=None)
+ mock_provider.get_accounts = AsyncMock(return_value=[
+ AccountData(
+ external_id="no-assets-acc-1", name="Checking",
+ type="checking", balance=Decimal("100"), currency="BRL",
+ ),
+ ])
+ mock_provider.get_transactions = AsyncMock(return_value=[])
+ mock_provider.get_holdings = AsyncMock(return_value=[
+ HoldingData(
+ external_id="holding-1", name="Provider Fund",
+ currency="BRL", current_value=Decimal("1234.56"),
+ ),
+ ])
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider), \
+ patch("app.services.connection_service.detect_transfer_pairs", new_callable=AsyncMock), \
+ patch("app.services.connection_service.stamp_primary_amount", new_callable=AsyncMock), \
+ patch("app.services.connection_service.apply_rules_to_transaction", new_callable=AsyncMock):
+ result_conn, _ = await sync_connection(session, conn.id, test_workspace.id, test_user.id)
+
+ assert result_conn.status == "active"
+ mock_provider.get_holdings.assert_not_awaited()
+ assets = (await session.execute(select(Asset))).scalars().all()
+ assert assets == []
+
+
+async def test_sync_connection_imports_holdings_by_default(
+ session: AsyncSession, test_user, test_workspace
+):
+ """Missing sync_assets setting preserves legacy asset-sync behavior."""
+ conn = await _make_connection(session, test_user.id, "Assets Bank")
+ mock_provider = AsyncMock()
+ mock_provider.refresh_credentials = AsyncMock(return_value={"token": "t"})
+ mock_provider.get_institution_logo = AsyncMock(return_value=None)
+ mock_provider.get_accounts = AsyncMock(return_value=[
+ AccountData(
+ external_id="assets-acc-1", name="Checking",
+ type="checking", balance=Decimal("100"), currency="BRL",
+ ),
+ ])
+ mock_provider.get_transactions = AsyncMock(return_value=[])
+ mock_provider.get_holdings = AsyncMock(return_value=[
+ HoldingData(
+ external_id="holding-1", name="Provider Fund",
+ currency="BRL", current_value=Decimal("1234.56"),
+ ),
+ ])
+
+ with patch("app.services.connection_service.get_provider", return_value=mock_provider), \
+ patch("app.services.connection_service.detect_transfer_pairs", new_callable=AsyncMock), \
+ patch("app.services.connection_service.stamp_primary_amount", new_callable=AsyncMock), \
+ patch("app.services.connection_service.apply_rules_to_transaction", new_callable=AsyncMock):
+ result_conn, _ = await sync_connection(session, conn.id, test_workspace.id, test_user.id)
+
+ assert result_conn.status == "active"
+ mock_provider.get_holdings.assert_awaited_once()
+ asset = (await session.execute(select(Asset).where(Asset.external_id == "holding-1"))).scalar_one()
+ assert asset.name == "Provider Fund"
+ assert asset.connection_id == conn.id
+
+
@pytest.mark.asyncio
async def test_sync_connection_does_not_revive_ignored_transaction(
session: AsyncSession, test_user, test_workspace,
diff --git a/backend/tests/test_connection_settings_api.py b/backend/tests/test_connection_settings_api.py
index e9ba408e..8479ae6e 100644
--- a/backend/tests/test_connection_settings_api.py
+++ b/backend/tests/test_connection_settings_api.py
@@ -35,6 +35,21 @@ async def test_update_import_pending(
assert data["settings"]["import_pending"] is False
+async def test_update_sync_assets(
+ client: AsyncClient, auth_headers, test_connection: BankConnection
+):
+ """PATCH connection settings updates sync_assets."""
+ resp = await client.patch(
+ f"/api/connections/{test_connection.id}/settings",
+ headers=auth_headers,
+ json={"sync_assets": False},
+ )
+ assert resp.status_code == 200
+ data = resp.json()
+ assert data["settings"]["sync_assets"] is False
+
+
@pytest.mark.asyncio
async def test_update_both_settings(
client: AsyncClient, auth_headers, test_connection: BankConnection
diff --git a/backend/tests/test_connections_api.py b/backend/tests/test_connections_api.py
index d3d22c40..b475c2d9 100644
--- a/backend/tests/test_connections_api.py
+++ b/backend/tests/test_connections_api.py
@@ -20,9 +20,14 @@ async def test_list_providers(client: AsyncClient, auth_headers):
assert "pluggy" in by_name
assert by_name["pluggy"]["configured"] is False
assert by_name["pluggy"]["flow_type"] == "widget"
+ assert by_name["pluggy"]["supports_asset_sync"] is True
assert "enable_banking" in by_name
assert by_name["enable_banking"]["flow_type"] == "oauth"
assert by_name["enable_banking"]["requires_institution_select"] is True
+ # Enable Banking (PSD2) exposes no investment holdings, so the asset-sync
+ # opt-out is hidden for it; connectors that import holdings advertise it.
+ assert by_name["enable_banking"]["supports_asset_sync"] is False
+ assert by_name["simplefin"]["supports_asset_sync"] is True
@pytest.mark.asyncio
diff --git a/docs/pr-386-disable-asset-sync/connection-settings-asset-sync-disabled.png b/docs/pr-386-disable-asset-sync/connection-settings-asset-sync-disabled.png
new file mode 100644
index 00000000..41615289
Binary files /dev/null and b/docs/pr-386-disable-asset-sync/connection-settings-asset-sync-disabled.png differ
diff --git a/docs/pr-386-disable-asset-sync/initial-connection-asset-sync-opt-out.png b/docs/pr-386-disable-asset-sync/initial-connection-asset-sync-opt-out.png
new file mode 100644
index 00000000..09bb5acb
Binary files /dev/null and b/docs/pr-386-disable-asset-sync/initial-connection-asset-sync-opt-out.png differ
diff --git a/frontend/src/components/bank-connect-dialog.tsx b/frontend/src/components/bank-connect-dialog.tsx
index b00b9a47..e2815516 100644
--- a/frontend/src/components/bank-connect-dialog.tsx
+++ b/frontend/src/components/bank-connect-dialog.tsx
@@ -5,6 +5,15 @@ import { PluggyConnect } from 'react-pluggy-connect'
import { connections } from '@/lib/api'
import { invalidateFinancialQueries } from '@/lib/invalidate-queries'
import { toast } from 'sonner'
+import {
+ Dialog,
+ DialogContent,
+ DialogFooter,
+ DialogHeader,
+ DialogTitle,
+} from '@/components/ui/dialog'
+import { Button } from '@/components/ui/button'
+import { Label } from '@/components/ui/label'
interface BankConnectDialogProps {
open: boolean
@@ -12,6 +21,7 @@ interface BankConnectDialogProps {
reconnectConnectionId?: string
updateItemId?: string
provider?: string
+ supportsAssetSync?: boolean
}
export function BankConnectDialog({
@@ -20,17 +30,26 @@ export function BankConnectDialog({
reconnectConnectionId,
updateItemId,
provider = 'pluggy',
+ supportsAssetSync = false,
}: BankConnectDialogProps) {
const { t } = useTranslation()
const queryClient = useQueryClient()
const [connectToken, setConnectToken] = useState<string | null>(null)
+ const [syncAssets, setSyncAssets] = useState(true)
+ const [optionsConfirmed, setOptionsConfirmed] = useState(false)
+ // Only prompt for asset-sync when the provider actually imports holdings.
+ const needsInitialOptions = !reconnectConnectionId && supportsAssetSync
useEffect(() => {
if (!open) {
setConnectToken(null)
+ setSyncAssets(true)
+ setOptionsConfirmed(false)
return
}
+ if (needsInitialOptions && !optionsConfirmed) return
+
let cancelled = false
const fetchToken = async () => {
try {
@@ -48,14 +67,19 @@ export function BankConnectDialog({
fetchToken()
return () => { cancelled = true }
- }, [open, reconnectConnectionId, provider])
+ }, [open, reconnectConnectionId, provider, needsInitialOptions, optionsConfirmed])
const handleSuccess = async (data: { item: { id: string } }) => {
try {
if (reconnectConnectionId) {
await connections.sync(reconnectConnectionId)
} else {
- await connections.handleCallback(data.item.id, provider)
+ await connections.handleCallback(
+ data.item.id,
+ provider,
+ undefined,
+ supportsAssetSync ? { sync_assets: syncAssets } : undefined,
+ )
}
invalidateFinancialQueries(queryClient)
queryClient.invalidateQueries({ queryKey: ['connections'] })
@@ -72,6 +96,36 @@ export function BankConnectDialog({
onClose()
}
+ if (open && needsInitialOptions && !optionsConfirmed) {
+ return (
+ <Dialog open={open} onOpenChange={(v) => !v && handleClose()}>
+ <DialogContent className="sm:max-w-md">
+ <DialogHeader>
+ <DialogTitle>{t('connections.initialSyncSettings')}</DialogTitle>
+ <p className="text-sm text-muted-foreground">{t('connections.initialSyncSettingsDesc')}</p>
+ </DialogHeader>
+ <div className="flex items-start justify-between gap-4 rounded-lg border border-border p-3">
+ <div className="space-y-1">
+ <Label htmlFor="initial-sync-assets">{t('connections.syncAssets')}</Label>
+ <p className="text-xs text-muted-foreground">{t('connections.syncAssetsHint')}</p>
+ </div>
+ <input
+ id="initial-sync-assets"
+ type="checkbox"
+ checked={syncAssets}
+ onChange={(e) => setSyncAssets(e.target.checked)}
+ className="mt-1 h-4 w-4 rounded border-border text-primary focus:ring-primary"
+ />
+ </div>
+ <DialogFooter>
+ <Button variant="outline" onClick={handleClose}>{t('common.cancel')}</Button>
+ <Button onClick={() => setOptionsConfirmed(true)}>{t('connections.continueToConnector')}</Button>
+ </DialogFooter>
+ </DialogContent>
+ </Dialog>
+ )
+ }
+
if (!open || !connectToken) return null
return (
diff --git a/frontend/src/components/connection-settings-dialog.tsx b/frontend/src/components/connection-settings-dialog.tsx
index c7ef4c0c..72b29349 100644
--- a/frontend/src/components/connection-settings-dialog.tsx
+++ b/frontend/src/components/connection-settings-dialog.tsx
@@ -21,12 +21,14 @@ interface ConnectionSettingsDialogProps {
open: boolean
onClose: () => void
connection: BankConnection | null
+ supportsAssetSync?: boolean
}
export function ConnectionSettingsDialog({
open,
onClose,
connection,
+ supportsAssetSync = false,
}: ConnectionSettingsDialogProps) {
const { t } = useTranslation()
const queryClient = useQueryClient()
@@ -34,12 +36,14 @@ export function ConnectionSettingsDialog({
const [displayName, setDisplayName] = useState('')
const [payeeSource, setPayeeSource] = useState<PayeeSource>('auto')
const [importPending, setImportPending] = useState(true)
+ const [syncAssets, setSyncAssets] = useState(true)
useEffect(() => {
if (connection) {
setDisplayName(connection.display_name ?? '')
setPayeeSource(connection.settings?.payee_source ?? 'auto')
setImportPending(connection.settings?.import_pending ?? true)
+ setSyncAssets(connection.settings?.sync_assets ?? true)
}
}, [connection])
@@ -49,6 +53,8 @@ export function ConnectionSettingsDialog({
display_name: displayName.trim() || null,
payee_source: payeeSource,
import_pending: importPending,
+ // Only persist asset-sync for connectors that actually import holdings.
+ ...(supportsAssetSync ? { sync_assets: syncAssets } : {}),
}),
onSuccess: () => {
queryClient.invalidateQueries({ queryKey: ['connections'] })
@@ -100,6 +106,21 @@ export function ConnectionSettingsDialog({
className="h-4 w-4 rounded border-border text-primary focus:ring-primary"
/>
</div>
+ {supportsAssetSync && (
+ <div className="flex items-start justify-between gap-4">
+ <div className="space-y-1">
+ <Label htmlFor="sync-assets">{t('connections.syncAssets')}</Label>
+ <p className="text-[11px] text-muted-foreground">{t('connections.syncAssetsHint')}</p>
+ </div>
+ <input
+ id="sync-assets"
+ type="checkbox"
+ checked={syncAssets}
+ onChange={(e) => setSyncAssets(e.target.checked)}
+ className="mt-1 h-4 w-4 rounded border-border text-primary focus:ring-primary"
+ />
+ </div>
+ )}
</div>
<DialogFooter>
<Button variant="outline" onClick={onClose}>
diff --git a/frontend/src/components/connector-select-dialog.tsx b/frontend/src/components/connector-select-dialog.tsx
index 692fc96b..206e7303 100644
--- a/frontend/src/components/connector-select-dialog.tsx
+++ b/frontend/src/components/connector-select-dialog.tsx
@@ -16,6 +16,7 @@ export interface Provider {
flow_type: string
configured: boolean
requires_institution_select?: boolean
+ supports_asset_sync?: boolean
}
interface ConnectorSelectDialogProps {
diff --git a/frontend/src/components/oauth-connect-dialog.tsx b/frontend/src/components/oauth-connect-dialog.tsx
index aab76934..eb1d0558 100644
--- a/frontend/src/components/oauth-connect-dialog.tsx
+++ b/frontend/src/components/oauth-connect-dialog.tsx
@@ -22,6 +22,7 @@ interface OAuthConnectDialogProps {
open: boolean
onClose: () => void
provider: string
+ supportsAssetSync?: boolean
}
const LAST_COUNTRY_KEY = 'securo:lastOAuthCountry'
@@ -39,7 +40,7 @@ function countryLabel(code: string): string {
return REGION_NAMES.of(code) || code
}
-export function OAuthConnectDialog({ open, onClose, provider }: OAuthConnectDialogProps) {
+export function OAuthConnectDialog({ open, onClose, provider, supportsAssetSync = false }: OAuthConnectDialogProps) {
const { t } = useTranslation()
const [step, setStep] = useState<'country' | 'bank'>('country')
const [country, setCountry] = useState<string | null>(null)
@@ -48,6 +49,7 @@ export function OAuthConnectDialog({ open, onClose, provider }: OAuthConnectDial
const [loading, setLoading] = useState(false)
const [error, setError] = useState<string | null>(null)
const [redirecting, setRedirecting] = useState(false)
+ const [syncAssets, setSyncAssets] = useState(true)
// Reset when dialog opens.
useEffect(() => {
@@ -57,6 +59,7 @@ export function OAuthConnectDialog({ open, onClose, provider }: OAuthConnectDial
setInstitutions([])
setError(null)
setRedirecting(false)
+ setSyncAssets(true)
setLoading(true)
connections
.listInstitutions(provider)
@@ -105,6 +108,7 @@ export function OAuthConnectDialog({ open, onClose, provider }: OAuthConnectDial
const url = await connections.getOAuthUrl(provider, {
country,
institution_name: institution.name,
+ ...(supportsAssetSync ? { sync_assets: syncAssets } : {}),
})
window.location.assign(url)
} catch (e) {
@@ -137,6 +141,24 @@ export function OAuthConnectDialog({ open, onClose, provider }: OAuthConnectDial
</p>
</DialogHeader>
+ {!redirecting && supportsAssetSync && (
+ <div className="flex items-start justify-between gap-4 rounded-lg border border-border p-3">
+ <div className="space-y-1">
+ <label htmlFor="oauth-sync-assets" className="text-sm font-medium text-foreground">
+ {t('connections.syncAssets')}
+ </label>
+ <p className="text-xs text-muted-foreground">{t('connections.syncAssetsHint')}</p>
+ </div>
+ <input
+ id="oauth-sync-assets"
+ type="checkbox"
+ checked={syncAssets}
+ onChange={(e) => setSyncAssets(e.target.checked)}
+ className="mt-1 h-4 w-4 rounded border-border text-primary focus:ring-primary"
+ />
+ </div>
+ )}
+
{redirecting ? (
<div className="py-12 flex flex-col items-center gap-3">
<div className="h-6 w-6 animate-spin rounded-full border-2 border-primary border-t-transparent" />
diff --git a/frontend/src/components/token-connect-dialog.tsx b/frontend/src/components/token-connect-dialog.tsx
index 4ba03d2f..d8a27ce5 100644
--- a/frontend/src/components/token-connect-dialog.tsx
+++ b/frontend/src/components/token-connect-dialog.tsx
@@ -19,22 +19,25 @@ interface TokenConnectDialogProps {
open: boolean
onClose: () => void
provider: string
+ supportsAssetSync?: boolean
}
const PROVIDER_BRIDGE_URLS: Record<string, string> = {
simplefin: 'https://bridge.simplefin.org/simplefin/create',
}
-export function TokenConnectDialog({ open, onClose, provider }: TokenConnectDialogProps) {
+export function TokenConnectDialog({ open, onClose, provider, supportsAssetSync = false }: TokenConnectDialogProps) {
const { t } = useTranslation()
const queryClient = useQueryClient()
const [token, setToken] = useState('')
const [submitting, setSubmitting] = useState(false)
+ const [syncAssets, setSyncAssets] = useState(true)
useEffect(() => {
if (!open) {
setToken('')
setSubmitting(false)
+ setSyncAssets(true)
}
}, [open])
@@ -45,7 +48,12 @@ export function TokenConnectDialog({ open, onClose, provider }: TokenConnectDial
if (!token.trim()) return
setSubmitting(true)
try {
- await connections.handleCallback(token.trim(), provider)
+ await connections.handleCallback(
+ token.trim(),
+ provider,
+ undefined,
+ supportsAssetSync ? { sync_assets: syncAssets } : undefined,
+ )
invalidateFinancialQueries(queryClient)
queryClient.invalidateQueries({ queryKey: ['connections'] })
toast.success(t('accounts.connected'))
@@ -82,6 +90,25 @@ export function TokenConnectDialog({ open, onClose, provider }: TokenConnectDial
</Button>
)}
+ {supportsAssetSync && (
+ <div className="flex items-start justify-between gap-4 rounded-lg border border-border p-3">
+ <div className="space-y-1">
+ <label htmlFor="token-sync-assets" className="text-sm font-medium text-foreground">
+ {t('connections.syncAssets')}
+ </label>
+ <p className="text-xs text-muted-foreground">{t('connections.syncAssetsHint')}</p>
+ </div>
+ <input
+ id="token-sync-assets"
+ type="checkbox"
+ checked={syncAssets}
+ onChange={(e) => setSyncAssets(e.target.checked)}
+ className="mt-1 h-4 w-4 rounded border-border text-primary focus:ring-primary"
+ disabled={submitting}
+ />
+ </div>
+ )}
+
<div className="space-y-1.5">
<label className="text-sm font-medium" htmlFor="securo-token-input">
{t('accounts.tokenConnect.tokenLabel')}
diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts
index 76897470..a7a4a286 100644
--- a/frontend/src/lib/api.ts
+++ b/frontend/src/lib/api.ts
@@ -294,7 +294,7 @@ export const connections = {
const { data } = await api.get('/connections')
return data
},
- getProviders: async (): Promise<{ name: string; display_name: string; description: string; flow_type: string; configured: boolean; requires_institution_select?: boolean }[]> => {
+ getProviders: async (): Promise<{ name: string; display_name: string; description: string; flow_type: string; configured: boolean; requires_institution_select?: boolean; supports_asset_sync?: boolean }[]> => {
const { data } = await api.get('/connections/providers')
return data.providers
},
@@ -327,8 +327,18 @@ export const connections = {
})
return data
},
- handleCallback: async (code: string, provider: string, state?: string): Promise<BankConnection> => {
- const { data } = await api.post('/connections/oauth/callback', { code, provider, state })
+ handleCallback: async (
+ code: string,
+ provider: string,
+ state?: string,
+ settings?: Pick<ConnectionSettings, 'sync_assets'>,
+ ): Promise<BankConnection> => {
+ const { data } = await api.post('/connections/oauth/callback', {
+ code,
+ provider,
+ state,
+ ...settings,
+ })
return data
},
getReauthUrl: async (connectionId: string): Promise<string> => {
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index e4953010..22e8c3fa 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Zahler-/Empfängername",
"payeeDescription": "Transaktionsbeschreibung",
"payeeNone": "Keinen Zahlungsempfänger festlegen",
- "importPending": "Ausstehende Transaktionen importieren"
+ "importPending": "Ausstehende Transaktionen importieren",
+ "syncAssets": "Investment-Assets importieren",
+ "syncAssetsHint": "Wenn deaktiviert, synchronisiert diese Verbindung Konten und Transaktionen, lässt aber Investment-Bestände des Anbieters unverändert.",
+ "initialSyncSettings": "Synchronisierungsoptionen",
+ "initialSyncSettingsDesc": "Wähle aus, was Securo importieren soll, bevor der Connector geöffnet wird.",
+ "continueToConnector": "Weiter zum Connector"
},
"settings": {
"rules": "Regeln",
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index bc726334..dc1684b8 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Payer/receiver name",
"payeeDescription": "Transaction description",
"payeeNone": "Don't set payee",
- "importPending": "Import pending transactions"
+ "importPending": "Import pending transactions",
+ "syncAssets": "Import investment assets",
+ "syncAssetsHint": "When disabled, this connection syncs accounts and transactions but leaves provider investment holdings untouched.",
+ "initialSyncSettings": "Sync options",
+ "initialSyncSettingsDesc": "Choose what Securo should import before opening the connector.",
+ "continueToConnector": "Continue to connector"
},
"settings": {
"rules": "Rules",
diff --git a/frontend/src/locales/es.json b/frontend/src/locales/es.json
index 97a6676b..af1b22d8 100644
--- a/frontend/src/locales/es.json
+++ b/frontend/src/locales/es.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Nombre del pagador/receptor",
"payeeDescription": "Descripción de la transacción",
"payeeNone": "No asignar beneficiario",
- "importPending": "Importar transacciones pendientes"
+ "importPending": "Importar transacciones pendientes",
+ "syncAssets": "Importar activos de inversión",
+ "syncAssetsHint": "Cuando está desactivado, esta conexión sincroniza cuentas y transacciones, pero deja intactas las inversiones del proveedor.",
+ "initialSyncSettings": "Opciones de sincronización",
+ "initialSyncSettingsDesc": "Elige qué debe importar Securo antes de abrir el conector.",
+ "continueToConnector": "Continuar al conector"
},
"settings": {
"rules": "Reglas",
diff --git a/frontend/src/locales/it.json b/frontend/src/locales/it.json
index 3289a26b..32ac04c5 100644
--- a/frontend/src/locales/it.json
+++ b/frontend/src/locales/it.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Nome pagante/ricevente",
"payeeDescription": "Descrizione transazione",
"payeeNone": "Non impostare il beneficiario",
- "importPending": "Importa transazioni in sospeso"
+ "importPending": "Importa transazioni in sospeso",
+ "syncAssets": "Importa asset di investimento",
+ "syncAssetsHint": "Se disattivato, questa connessione sincronizza conti e transazioni ma lascia invariati gli investimenti del provider.",
+ "initialSyncSettings": "Opzioni di sincronizzazione",
+ "initialSyncSettingsDesc": "Scegli cosa deve importare Securo prima di aprire il connettore.",
+ "continueToConnector": "Continua al connettore"
},
"settings": {
"rules": "Regole",
diff --git a/frontend/src/locales/pl.json b/frontend/src/locales/pl.json
index 4ba18b71..644558a6 100644
--- a/frontend/src/locales/pl.json
+++ b/frontend/src/locales/pl.json
@@ -667,7 +667,12 @@
"payeePaymentData": "Nazwa płatnika/odbiorcy",
"payeeDescription": "Opis transakcji",
"payeeNone": "Nie ustawiaj odbiorcy",
- "importPending": "Importuj transakcje oczekujące"
+ "importPending": "Importuj transakcje oczekujące",
+ "syncAssets": "Importuj aktywa inwestycyjne",
+ "syncAssetsHint": "Gdy wyłączone, to połączenie synchronizuje konta i transakcje, ale nie zmienia inwestycji dostawcy.",
+ "initialSyncSettings": "Opcje synchronizacji",
+ "initialSyncSettingsDesc": "Wybierz, co Securo ma zaimportować przed otwarciem konektora.",
+ "continueToConnector": "Przejdź do konektora"
},
"settings": {
"rules": "Reguły",
diff --git a/frontend/src/locales/pt-BR.json b/frontend/src/locales/pt-BR.json
index b9029c53..50af277a 100644
--- a/frontend/src/locales/pt-BR.json
+++ b/frontend/src/locales/pt-BR.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Nome do pagador/recebedor",
"payeeDescription": "Descrição da transação",
"payeeNone": "Não definir beneficiário",
- "importPending": "Importar transações pendentes"
+ "importPending": "Importar transações pendentes",
+ "syncAssets": "Importar ativos de investimento",
+ "syncAssetsHint": "Quando desativado, esta conexão sincroniza contas e transações, mas não altera os investimentos do provedor.",
+ "initialSyncSettings": "Opções de sincronização",
+ "initialSyncSettingsDesc": "Escolha o que o Securo deve importar antes de abrir o conector.",
+ "continueToConnector": "Continuar para o conector"
},
"settings": {
"rules": "Regras",
diff --git a/frontend/src/locales/ru.json b/frontend/src/locales/ru.json
index 950e431f..8a9e10d6 100644
--- a/frontend/src/locales/ru.json
+++ b/frontend/src/locales/ru.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Имя плательщика/получателя",
"payeeDescription": "Описание транзакции",
"payeeNone": "Не устанавливать получателя",
- "importPending": "Импортировать ожидающие транзакции"
+ "importPending": "Импортировать ожидающие транзакции",
+ "syncAssets": "Импортировать инвестиционные активы",
+ "syncAssetsHint": "Если выключено, это подключение синхронизирует счета и транзакции, но не изменяет инвестиционные активы провайдера.",
+ "initialSyncSettings": "Параметры синхронизации",
+ "initialSyncSettingsDesc": "Выберите, что Securo должен импортировать перед открытием коннектора.",
+ "continueToConnector": "Перейти к коннектору"
},
"settings": {
"rules": "Правила",
diff --git a/frontend/src/locales/uk.json b/frontend/src/locales/uk.json
index 81695fb1..799b0361 100644
--- a/frontend/src/locales/uk.json
+++ b/frontend/src/locales/uk.json
@@ -631,7 +631,12 @@
"payeePaymentData": "Ім'я платника/отримувача",
"payeeDescription": "Опис транзакції",
"payeeNone": "Не встановлювати отримувача",
- "importPending": "Імпортувати очікувані транзакції"
+ "importPending": "Імпортувати очікувані транзакції",
+ "syncAssets": "Імпортувати інвестиційні активи",
+ "syncAssetsHint": "Якщо вимкнено, це підключення синхронізує рахунки й транзакції, але не змінює інвестиційні активи провайдера.",
+ "initialSyncSettings": "Параметри синхронізації",
+ "initialSyncSettingsDesc": "Виберіть, що Securo має імпортувати перед відкриттям конектора.",
+ "continueToConnector": "Перейти до конектора"
},
"settings": {
"rules": "Правила",
diff --git a/frontend/src/pages/accounts.tsx b/frontend/src/pages/accounts.tsx
index d2cbd029..0287428d 100644
--- a/frontend/src/pages/accounts.tsx
+++ b/frontend/src/pages/accounts.tsx
@@ -613,6 +613,7 @@ export default function AccountsPage() {
open={!!selectedProvider && selectedProvider.flow_type === 'widget'}
onClose={() => setSelectedProvider(null)}
provider={selectedProvider?.name}
+ supportsAssetSync={selectedProvider?.supports_asset_sync ?? false}
/>
{/* OAuth Connect Dialog — institution-pickers (Enable Banking) */}
@@ -620,6 +621,7 @@ export default function AccountsPage() {
open={!!selectedProvider && selectedProvider.flow_type === 'oauth'}
onClose={() => setSelectedProvider(null)}
provider={selectedProvider?.name ?? ''}
+ supportsAssetSync={selectedProvider?.supports_asset_sync ?? false}
/>
{/* Token Connect Dialog — paste-a-token flow (SimpleFIN) */}
@@ -627,6 +629,7 @@ export default function AccountsPage() {
open={!!selectedProvider && selectedProvider.flow_type === 'token'}
onClose={() => setSelectedProvider(null)}
provider={selectedProvider?.name ?? ''}
+ supportsAssetSync={selectedProvider?.supports_asset_sync ?? false}
/>
{/* Reconnect Dialog */}
@@ -642,6 +645,11 @@ export default function AccountsPage() {
open={!!settingsConnection}
onClose={() => setSettingsConnection(null)}
connection={settingsConnection}
+ supportsAssetSync={
+ settingsConnection
+ ? providersByName.get(settingsConnection.provider)?.supports_asset_sync ?? false
+ : false
+ }
/>
{/* Account Dialog */}
diff --git a/frontend/src/types/index.ts b/frontend/src/types/index.ts
index 2db5d25b..344c35f5 100644
--- a/frontend/src/types/index.ts
+++ b/frontend/src/types/index.ts
@@ -118,6 +118,7 @@ export interface BankConnection {
export interface ConnectionSettings {
payee_source?: 'auto' | 'merchant' | 'payment_data' | 'description' | 'none'
import_pending?: boolean
+ sync_assets?: boolean
}
export interface Account {